From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.51 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794866427; b=qbxTwJwPCiZUSBRrXD/94SrRaCtQzQdWEswBYorKTLPAIFrcizqwI9z/YhLkgY/P/Q+P 31auQs1DmnzTm70M02hdW6txKgBlAyJ6nzsWWL2m73R/FI4YDauO9+uxpTVfl7USVUSXa i+8ptJ0duyWcnydRl71fYttCVPiHJu3m1wJQfuVPTovlB3C9Rzwg/wfGyyc1i9ANO9jMl JdqQ8e2rDkAXOROvebLQM1gR7gPuIQ2VylCQIDqQ96GngLkzrOeo6YYu4pnG62uNLbY52 Hu88O1BLl9aw4L3vNPECqY1mU43z8BKlpRasqmZDojUPeJfVKIx9vNk/hE1Df4dMGHA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794866427; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=BTPE9Q1KzFgXOzghIcy1Do+zsJcn2B9P+6aO9CoEBkg=; b=zXnD5pEcIE/6pJEQ8xbTm0cKJZFFDSzcpXVf2qV2kiojr6i1xy5IIB2q8Oh7MLGBoRCN Jg/K8yhuYdRaR4DXdEnEFy4SxNOht5YIgUfryYSv/OuVVXyTcpP7ilE692A+FJ2K58nMJ luNzE3dKxPLx3tvXp9daUk0nxVWdKFhsHfDENSIyLPVKgf72BS1F6YW5l7ZmRP1A6KL+t 2RtAg7s55k96wTcskJM/VVSNRaEITNfRQrxOAFPZKwQ3dVOtEamgv6qf0sptEdNS8qfob SHKleLaIKre76rpkluQCFkyeXLJUbuzjJTCbNKbAGlZnyDpQP0bGiZIvq6YFd4Asrjg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Wgaz3sxI; arc=none smtp.remote-ip=209.85.128.51 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99E17606A323 for ; Mon, 16 Nov 2026 22:00:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 99E17606A323 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Wgaz3sxI Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4a1b07c3c5fso45323915e9.1 for ; Mon, 16 Nov 2026 14:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794866425; x=1795471225; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BTPE9Q1KzFgXOzghIcy1Do+zsJcn2B9P+6aO9CoEBkg=; b=Wgaz3sxIxWZLDFT7xVEdmX1ppNgZ14lH2Bd/pkkQY8LuwSm23WSJcoASZdiEoRzwgY NrDnUGRd8QWiPBQaGHTSVC3t/pfUMPwHHDcS6QN4v/rhN4wcNK+PQW58WH9kQyQh51/m dodS6K1TM1o95Uso14CGLlGiQg+16nqE76ucJu+hS8G1eDddvX5CmuQKKYzcYv+lHhiW QsraJwnG1B74v4hIV4DQcwYn+NAEt5Px5tM+fx+hA/Li4DkDMHyRmupnWh4tg+1nAAGd PX1eRA47BtO4ClJlF/DMwUrc9Bnw4tkHBPbbcwTtOdOOCduf50BdrndDMGZh5wGc0uyb ELFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794866425; x=1795471225; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BTPE9Q1KzFgXOzghIcy1Do+zsJcn2B9P+6aO9CoEBkg=; b=fQYxTHt8j94Wl9qqx4Ll+u5Yk+Blkaj+PP/xW/1pEP7zBSsckWAwWmiNG7PlSItasD sdtBSGP6PsWlEwVjposMn6vCFGr3AdXUPkykM4Yes2HafLYgT75BK5hFkOJPdurHnKua m+UM35e9wslK9n7R8tY7UVUhOYNxVeaESmNgJUWR2qur2YW7OkCaMz9/m5xzZhv8Knmy IXleXncncER/b4HR2u/Ht8UpTDL6ICdcQ6A99E5NxeXOvOqLV6pvlQSjtfcw7IJ+lgai S7siWgwmHROno69eJcLoTzrxO5aILrR4/jOa+0PAfWMYM4AFKu2iiH8K/i0+tqDep4fd 0dNw== X-Forwarded-Encrypted: i=1; AL+hErG20qDcC/eyr/GY3MhdOO8xrCszgMDRQSguCIVjhP+gC3iOT4nnGIGlF6NS/CQ+2RVZ/uV9dmkggpajJMA=@vger.kernel.org X-Gm-Message-State: APuU4Z8l8ofu7ocOeV9DqQFFyolgDoxlAlpnu3XijGpbex9L7z3l7f5m syauwQyg0O0OQK1QqPDPj3zdmVcDLjDZGPrmeXqu9hlzf1KctNMdb7qh X-Gm-Gg: AYBFou2pYNkL7/l4tgubsWEPrUATWMSvrURCUM6+YsdAIgOBWTDni1cCPqzaHfXpanw vC4zMooiLgJYVZIXVNsuawu5q6KIx+xQDYXGt4WwBsqdmY2vj2G2wfe6VwW4N0xPHJoGhvWeksY jz8iCABDbcJSLGghziI+aWnVjvDMysYaje2r/943DzdopJzobd6T7d18sv9DaaQ7kLikY+Dbcan 0wahwdVBm4SsF6jI8s8JKVGXlZ5UUOQVKxz6tC+sDp6NXCR4wx8BiEmFLEMWSSC/QKK2DmEaKb0 T79oyMOQjEr1bcROpwo3Iy3L+CrC1jykpxG2Mrle7gOOMtp7WJVmTvF6hIMSYkn8eM/lCCIJkJS j6n9fq3FeJ/DVcb4jVMtalhgL/fyukwaWg/QI668xGUzbgSiRQ1pgomiDtu/SKdTKK+tN8iDGP7 LUcZDm/1w1Yy1fDz7Co8BgzmWiu0GFmnmqh7qpyIjyBdpkLTE3KzIYurqkZ3EZ5Hww9VJ52EXWp GiGdFb/Nsx0ftaqoYtWnDJ81ViDksSmAzuM7ofNIk6rv6eK22eehtJrIrZuzVwooXrYYFgGwKIb jYYVc2y/p2raMVPH2efbcrxAfI+9gw== X-Received: by 2002:a05:600c:34d0:b0:4a2:133:45e1 with SMTP id 5b1f17b1804b1-4bb55a59f41mr249245185e9.24.1794866424901; Mon, 16 Nov 2026 14:00:24 -0800 (PST) Received: from [10.10.0.26] ([85.105.252.11]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb56f97257sm207857645e9.4.2026.11.16.14.00.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Nov 2026 14:00:24 -0800 (PST) Message-ID: <228df241-da5e-49cb-b29f-6b9158557f55@gmail.com> Date: Tue, 17 Nov 2026 01:00:20 +0300 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] platform/x86: asus-wmi: add TUF keyboard RGB readback support To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Denis Benato Cc: Corentin Chary , "Luke D. Jones" , Hans de Goede , platform-driver-x86@vger.kernel.org, LKML , linux-api@vger.kernel.org, Denis Benato References: <20261029-asus-tuf-rgb-v4-v4-0-0d3b877d2c30@gmail.com> <20261029-asus-tuf-rgb-v4-v4-1-0d3b877d2c30@gmail.com> Content-Language: en-US From: bartu alev In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/9/26 9:02 PM, Ilpo Järvinen wrote: > What do you (or Denis) think on sashiko's mention about  > asus_wmi_evaluate_method_buf() casting integer.value to int which might  > end up aliasing high-bit on return values with errnos? >  > The other caller seems to also return that value directly out of _store  > function(). Hi Ilpo and Denis, I checked the DSDTs across 102 ASUS models we have dumped as well as the UEFI/SMM path on my FA507NV (BIOS 318) to see what firmware actually returns on the DSTS path: 1. Across the 102 DSDTs, no static DSTS branch returns 0xFFFFFFFF or    Ones. Models without 0x0010005B either hit a DSTS tail of    0xFFFFFFFE (15), fall through to WMNB's trailing 0xFFFFFFFE (45),    or return Zero (3 older models: GL553VD, GL553VE, FX505DT). 2. On modern models (including FA507NV, FX517, GA403, GA605WI), DSTS    delegates unlisted DEVIDs via WCHK/W15H (SW SMI 0xAA, cmd 0x9603).    Disassembling the FA507NV modules (AsusSmmService ->    AsusWmiToProtocol -> QuantaDxeWrapperPkg) shows that this dynamic    chain also returns 0 (unmatched consumer / missing table entry), 1,    capability/presence bits (e.g. 0x00010000 for 0x00100056/57), MMIO    reads, or 0xFFFFFFFE -- never 0xFFFFFFFF.    (Note: on FA507NV, 0x0010005B itself is static in AML and calls    EC0.KBLS(), while 0x00100056/57 go through WCHK/W15H and return    0x00010000 on DSTS.) However, checking those tables did uncover one real mismatch and a clean reason to still harden asus_wmi_evaluate_method_buf(): - On models like FX505DT, DSTS(0x00100056/57) returns 0x00010000 (so   kbd_rgb_mode/kbd_rgb_state are registered), while 0x0010005B hits the   DSTS tail Return (Zero).  asus_wmi_evaluate_method_buf() turns 0 into   -ENODATA, so v4's `err < 0 ? err : -ENODEV` would return -ENODATA   instead of -ENODEV as documented in the ABI patch.  The same happens   if W15H hits an unmatched consumer/table miss in SMM (returns 0). - Even though 0xFFFFFFFF didn't show up in this set, an unseen BIOS or   SMM branch returning 0xFFFFFFFF or any bit-31-set integer would still   alias a negative errno in asus_wmi_evaluate_method_buf(). To avoid disturbing older devices, would a minimal approach like this be acceptable for v5? 1. Add a small prep patch to asus_wmi_evaluate_method_buf() using a u32    retval: keep 0xFFFFFFFE -> -ENODEV and 0 -> -ENODATA as today, also    map (u32)~0 (0xFFFFFFFF) -> -ENODEV (matching asus_wmi_get_devstate()),    and return -ENODATA for any other unexpected integer (matching the    `default:` case; the only existing caller fan_curve_get_factory_default()    already treats any non-zero return as failure). 2. In kbd_rgb_read_status(), translate -ENODATA to -ENODEV so FX505DT /    0-returning firmware matches the ABI while preserving -EIO / -ENOSPC. Thanks, Bartu