From: David Ahern <dsahern@kernel.org>
To: Richard Gobert <richardbgobert@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, willemdebruijn.kernel@gmail.com,
tom@herbertland.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, gal@nvidia.com
Subject: Re: [PATCH 1/1] net: gro: fix misuse of CB in udp socket lookup
Date: Mon, 10 Jul 2023 09:50:28 -0600 [thread overview]
Message-ID: <2291aa12-3081-5e65-dc64-bf3d4349dfea@kernel.org> (raw)
In-Reply-To: <20230710145817.GB22009@debian>
On 7/10/23 8:58 AM, Richard Gobert wrote:
>> put your cover letter details in here; no need for a cover letter for a
>> single patch.
>
> I believe some details are irrelevant to the bugfix itself,
> I prefer to avoid overloading the commit message...
> Do you think there is a specific part of the cover letter that
> should be added to the commit message?
>
>> there are existing iif and sdif lookup functions. I believe this gro
>> path needs a different version, but it should have a comment of when it
>> can be used vs the existing ones. Also, it is small enough to be an
>> inline like the existing ones. e.g., see inet_sdif
>
> I was under the impression the coding style of Linux does not
> encourage placing the inline keyword.
> In which cases do you think I should add it?
See the existing *_sdif helpers in include/net/ip.h,
include/linux/ipv6.h and include/net/tcp.h.
next prev parent reply other threads:[~2023-07-10 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 12:16 [PATCH 0/1] " Richard Gobert
2023-07-07 12:26 ` [PATCH 1/1] " Richard Gobert
2023-07-07 13:44 ` Eric Dumazet
2023-07-10 14:54 ` Richard Gobert
2023-07-07 18:42 ` Kuniyuki Iwashima
2023-07-07 21:40 ` David Ahern
2023-07-10 14:58 ` Richard Gobert
2023-07-10 15:50 ` David Ahern [this message]
2023-07-17 10:41 ` Gal Pressman
2023-07-19 7:27 ` Richard Gobert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2291aa12-3081-5e65-dc64-bf3d4349dfea@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
--cc=tom@herbertland.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome