From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A87C7EE23 for ; Wed, 7 Jun 2023 17:33:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231866AbjFGRdF (ORCPT ); Wed, 7 Jun 2023 13:33:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229589AbjFGRdD (ORCPT ); Wed, 7 Jun 2023 13:33:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 765C21993 for ; Wed, 7 Jun 2023 10:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686159116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xc3kt7fbXK4RZZ9hervM2RINSzi1H8nscf+Y8dFfX2M=; b=gzRfe07XNfJJLs7rWptVLImuWFkxBs9Znl3LQhf07dzocEd9CirNiKaJQitHtqQ7qZSu5b c2Woy6Avx90lw7Iij7flZfgUTGO5bTCVRY1A5PHGDoj5qejOGj/FTaQKzvRQTUQSTbAa5x DBHioXzFrAcpu4bjEUwmvrmY2BDJnfM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-255-6fb_cFy7NMyCZG_m0dqakA-1; Wed, 07 Jun 2023 13:31:54 -0400 X-MC-Unique: 6fb_cFy7NMyCZG_m0dqakA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A24F610328C9; Wed, 7 Jun 2023 17:31:12 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF14A2166B25; Wed, 7 Jun 2023 17:31:10 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <2291292.1686158954@warthog.procyon.org.uk> References: <2291292.1686158954@warthog.procyon.org.uk> <20230607101945.65c5df51@kernel.org> <20230607140559.2263470-1-dhowells@redhat.com> <20230607140559.2263470-12-dhowells@redhat.com> To: Jakub Kicinski Cc: dhowells@redhat.com, netdev@vger.kernel.org, Linus Torvalds , Chuck Lever , Boris Pismenny , John Fastabend , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 11/14] tls/sw: Support MSG_SPLICE_PAGES MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2293094.1686159070.1@warthog.procyon.org.uk> Date: Wed, 07 Jun 2023 18:31:10 +0100 Message-ID: <2293095.1686159070@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Howells wrote: > > > - tls_ctx->pending_open_record_frags = true; > > > copied += try_to_copy; > > > +copied: > > > + tls_ctx->pending_open_record_frags = true; > > > > Why move pending-open-record-frags setting if it's also set before > > jumping? > > I should probably remove it from before the goto - unless you'd prefer to do > it in both places. Actually, I need to keep the one before the goto. David