From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757343AbcIGUWP (ORCPT ); Wed, 7 Sep 2016 16:22:15 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36814 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260AbcIGUWI (ORCPT ); Wed, 7 Sep 2016 16:22:08 -0400 Subject: Re: [patch 2/2] leds: add driver for Mellanox systems leds To: vadimp@mellanox.com, rpurdie@rpsys.net, j.anaszewski@samsung.com References: <1473259995-196607-1-git-send-email-vadimp@mellanox.com> Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, jiri@resnulli.us, michaelsh@mellanox.com From: Jacek Anaszewski Message-ID: <22943812-c4f8-3440-92a3-49b1827d3516@gmail.com> Date: Wed, 7 Sep 2016 22:21:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473259995-196607-1-git-send-email-vadimp@mellanox.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vadim, Please just include these changes to the new version of the patch. On 09/07/2016 04:53 PM, vadimp@mellanox.com wrote: > From: Vadim Pasternak > > Fix in comments 3KHz and 6KHz to 3Hz and 6Hz respectively. > > Signed-off-by: Vadim Pasternak > --- > drivers/leds/leds-mlxcpld.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/leds/leds-mlxcpld.c b/drivers/leds/leds-mlxcpld.c > index 0ec2375..eeed35c 100644 > --- a/drivers/leds/leds-mlxcpld.c > +++ b/drivers/leds/leds-mlxcpld.c > @@ -47,8 +47,8 @@ > #define MLXPLAT_CPLD_LPC_REG_BASE_ADRR 0x2500 /* LPC bus access */ > > /* Color codes for leds */ > -#define LED_OFFSET_HALF 0x01 /* Offset from solid for 3KHz blink */ > -#define LED_OFFSET_FULL 0x02 /* Offset from solid for 6KHz blink */ > +#define LED_OFFSET_HALF 0x01 /* Offset from solid for 3Hz blink */ > +#define LED_OFFSET_FULL 0x02 /* Offset from solid for 6Hz blink */ > #define LED_IS_OFF 0x00 /* Off */ > #define LED_RED_STATIC_ON 0x05 /* Solid red */ > #define LED_RED_BLINK_HALF (LED_RED_STATIC_ON + LED_OFFSET_HALF) > @@ -237,7 +237,7 @@ static void mlxcpld_led_store_hw(u8 mask, u8 off, u8 vset) > /* Each led is controlled through low or high nibble of the relevant > * CPLD register. Register offset is specified by off parameter. > * Parameter vset provides color code: 0x0 for off, 0x5 for solid red, > - * 0x6 for 3KHz blink red, 0xd for solid green, 0xe for 3KHz blink > + * 0x6 for 3Hz blink red, 0xd for solid green, 0xe for 3Hz blink > * green. > * Parameter mask specifies which nibble is used for specific led: mask > * 0xf0 - lower nibble is to be used (bits from 0 to 3), mask 0x0f - > @@ -274,8 +274,8 @@ static int mlxcpld_led_blink(struct led_classdev *led, > { > struct mlxcpld_led_priv *pled = cdev_to_priv(led); > > - /* HW supports two types of blinking: full (6KHz) and half (3KHz). > - * For delay on/off zero default setting 3KHz is used. > + /* HW supports two types of blinking: full (6Hz) and half (3Hz). > + * For delay on/off zero default setting 3Hz is used. > */ > if (!(*delay_on == 0 && *delay_off == 0) && > !(*delay_on == LED_BLINK_3HZ && *delay_off == LED_BLINK_3HZ) && > -- Best regards, Jacek Anaszewski