From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Rob Herring <robh@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-perf-users <linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH RFC v1 2/3] perf: Add perf_event_attr::config3
Date: Wed, 31 Aug 2022 17:07:25 -0300 [thread overview]
Message-ID: <2295C0C0-6F55-4554-8062-D10BFED58323@gmail.com> (raw)
In-Reply-To: <CAL_Jsq+wviPPgnFc0vj9j6cKqqnL8HRO8wa8MFeX2fP5J8BcUA@mail.gmail.com>
On August 31, 2022 4:06:40 PM GMT-03:00, Rob Herring <robh@kernel.org> wrote:
>On Thu, Aug 25, 2022 at 1:08 PM Rob Herring <robh@kernel.org> wrote:
>>
>> Arm SPEv1.2 adds another 64-bits of event filtering control. As the
>> existing perf_event_attr::configN fields are all used up for SPE PMU, an
>> additional field is needed. Add a new 'config3' field.
>
>In testing this, just exposing 'config3' in the format attributes
>causes the SPE PMU to be disabled. So we can't add this without
>breaking existing perf. Shouldn't perf just skip any format fields it
>doesn't know about?
Something it doesn't know about, even more at the main perf_event_attr level, may preclude it to grok new records.
"May" is the key word, as perf_event_hdr has a size field, maybe sometimes it's possible to do as you say.
If you're interested propose patches to make perf ignore things when possible.
- Arnaldo
next prev parent reply other threads:[~2022-08-31 20:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 18:07 [PATCH RFC v1 0/3] perf: Arm SPEv1.2 support Rob Herring
2022-08-25 18:08 ` [PATCH RFC v1 1/3] perf: arm_spe: Support new SPEv1.2/v8.7 'not taken' event Rob Herring
2022-08-25 18:08 ` [PATCH RFC v1 2/3] perf: Add perf_event_attr::config3 Rob Herring
2022-08-25 19:31 ` Arnaldo Carvalho de Melo
2022-08-25 19:43 ` Rob Herring
2022-08-25 19:53 ` Arnaldo Carvalho de Melo
2022-08-31 19:06 ` Rob Herring
2022-08-31 20:07 ` Arnaldo Carvalho de Melo [this message]
2022-08-25 18:08 ` [PATCH RFC v1 3/3] perf: arm_spe: Add support for SPEv1.2 inverted event filtering Rob Herring
2022-09-05 14:55 ` James Clark
2022-09-06 13:48 ` Rob Herring
2022-09-12 8:53 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2295C0C0-6F55-4554-8062-D10BFED58323@gmail.com \
--to=arnaldo.melo@gmail.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=catalin.marinas@arm.com \
--cc=jolsa@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®