From: Joe Perches <joe@perches.com>
To: Antoine Robertson <antoinerbrtsn@gmail.com>, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: moxa: Fix coding style issues
Date: Sat, 19 Jan 2019 14:11:39 -0800 [thread overview]
Message-ID: <229635c22b0b7e11999df96a9d25f599cd391ded.camel@perches.com> (raw)
In-Reply-To: <20190119220558.28927-1-antoinerbrtsn@gmail.com>
On Sat, 2019-01-19 at 17:05 -0500, Antoine Robertson wrote:
> Fix coding style issues
[]
> diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
[]
> @@ -74,8 +74,7 @@ enum {
> MOXA_BOARD_CP204J,
> };
>
> -static char *moxa_brdname[] =
> -{
> +static char *moxa_brdname[] = {
If you're going to fix this, might as well make it static const char *
> "C218 Turbo PCI series",
> "C218 Turbo ISA series",
> "C320 Turbo PCI series",
[]
> @@ -1357,8 +1355,7 @@ static void moxa_new_dcdstate(struct moxa_port *p, u8 dcd)
> spin_unlock_irqrestore(&p->port.lock, flags);
> if (!dcd)
> tty_port_tty_hangup(&p->port, true);
> - }
> - else
> + } else
and use } else {
> spin_unlock_irqrestore(&p->port.lock, flags);
> }
prev parent reply other threads:[~2019-01-19 22:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 22:05 Antoine Robertson
2019-01-19 22:11 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=229635c22b0b7e11999df96a9d25f599cd391ded.camel@perches.com \
--to=joe@perches.com \
--cc=antoinerbrtsn@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®