From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org by pdx-caf-mail.web.codeaurora.org (Dovecot) with LMTP id icViDs4lGVsGbwAAmS7hNA ; Thu, 07 Jun 2018 12:32:17 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id CD1F4608B8; Thu, 7 Jun 2018 12:32:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by smtp.codeaurora.org (Postfix) with ESMTP id 36C1E601C3; Thu, 7 Jun 2018 12:32:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 36C1E601C3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=holtmann.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753601AbeFGMcN convert rfc822-to-8bit (ORCPT + 25 others); Thu, 7 Jun 2018 08:32:13 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:39664 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753114AbeFGMcK (ORCPT ); Thu, 7 Jun 2018 08:32:10 -0400 Received: from marcel-macpro.fritz.box (p5B3D24B5.dip0.t-ipconnect.de [91.61.36.181]) by mail.holtmann.org (Postfix) with ESMTPSA id F2F42CF356; Thu, 7 Jun 2018 14:38:49 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: [PATCH 04/19] Bluetooth: hci_nokia: Add serdev_id_table From: Marcel Holtmann In-Reply-To: <20180607102740.GD4372@localhost> Date: Thu, 7 Jun 2018 14:32:08 +0200 Cc: Ricardo Ribalda Delgado , LKML , linux-serial@vger.kernel.org, Johan Hedberg , Rob Herring , Johan Hovold , linux-bluetooth@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <22CF0FC7-6DC7-4DD2-9EA1-9F51B40F53E5@holtmann.org> References: <20180529131014.18641-1-ricardo.ribalda@gmail.com> <20180529131014.18641-5-ricardo.ribalda@gmail.com> <20180607102740.GD4372@localhost> To: Pavel Machek X-Mailer: Apple Mail (2.3445.8.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, >>> Describe which hardware is supported by the current driver. >>> >>> Cc: Marcel Holtmann >>> Cc: Johan Hedberg >>> Cc: Rob Herring >>> Cc: Johan Hovold >>> Cc: linux-bluetooth@vger.kernel.org >>> Signed-off-by: Ricardo Ribalda Delgado >>> --- >>> drivers/bluetooth/hci_nokia.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/drivers/bluetooth/hci_nokia.c b/drivers/bluetooth/hci_nokia.c >>> index 3539fd03f47e..e32dfcd56b8d 100644 >>> --- a/drivers/bluetooth/hci_nokia.c >>> +++ b/drivers/bluetooth/hci_nokia.c >>> @@ -801,6 +801,11 @@ static const struct of_device_id nokia_bluetooth_of_match[] = { >>> MODULE_DEVICE_TABLE(of, nokia_bluetooth_of_match); >>> #endif >>> >>> +static struct serdev_device_id nokia_bluetooth_serdev_id[] = { >>> + { "hp4-bluetooth", }, >>> + {}, >>> +}; >>> + >>> static struct serdev_device_driver nokia_bluetooth_serdev_driver = { >>> .probe = nokia_bluetooth_serdev_probe, >>> .remove = nokia_bluetooth_serdev_remove, >>> @@ -809,6 +814,7 @@ static struct serdev_device_driver nokia_bluetooth_serdev_driver = { >>> .pm = &nokia_bluetooth_pm_ops, >>> .of_match_table = of_match_ptr(nokia_bluetooth_of_match), >>> }, >>> + .id_table = nokia_bluetooth_serdev_id, >>> }; >> >> I would actually skip this hardware. First of all it is such a dedicated custom Nokia transport and hardware, and secondly it is no longer produced anyway. >> > > Would it make sense to cc: sre here? We want good support even for old > hardware, and this is n9/n950, it is still on "top ten supported > phones" list... Probably even top 5. but that is not what this patch series is about. We do not need new_id kinda support for the existing hardware. My point is there will be no newly designed hardware using this driver. Regards Marcel