From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=40.93.195.32 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1795106970; b=dU3KihDMfVB/QFYqeax6ZSv6AQx2O9WHT+SwAS0iOhSthQu1hdLiwZ6kZ72GNG646nbs dcNUdGFUucENjfBK65lYg6YrJpywc31THSg/FK73mEV9NtcjTbN1Er4ly+xGseTUEIf0n qLWBaOGF0U2h0/EygDthD6jmKPUfNx49CPAjYBNALNId+RaNVaB7PReS9Y3NZSPRyvHM0 Klo76AQD5nCFwBC0II4EEu5Lrtvh5NB8ObGi3xoyybzQeO9vBdub9xKNIHM4A0gzhVm3Z RPiS3d/XiwZOH+LJcqF121Iu/vx4jhfgxDne0eyV1TXJ7EuwoBalzc3EP59MkFzuB4w== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795106970; h=DMARC-Filter:DKIM-Signature:Received:Received:From:To:Cc:Subject: Date:X-Mailer:Message-ID:In-Reply-To:References:Content-Type: Content-Transfer-Encoding:X-MS-Reactions:X-ClientProxiedBy: MIME-Version:X-MS-PublicTrafficType:X-MS-TrafficTypeDiagnostic: X-MS-Office365-Filtering-Correlation-Id:X-MS-Exchange-SenderADCheck: X-MS-Exchange-AntiSpam-Relay:X-Microsoft-Antispam: X-Microsoft-Antispam-Message-Info:X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-OriginatorOrg: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-CrossTenant-Id:X-MS-Exchange-CrossTenant-MailboxType: X-MS-Exchange-CrossTenant-UserPrincipalName: X-MS-Exchange-Transport-CrossTenantHeadersStamped; bh=CuYFhjs7mCVDiJ2gP24B9f05HZH0srWTAYA9BObVOWI=; b=dHz+AhjUqwuBvukVoNuZATkm9Lb1e8Oa4TLGr7oKiXyLYCQxKnLDlU1V+oqHvDpPj665 2aTIKuUqpyxqsnNdLsJT5ROjqXY4HTy1kKbhBzJYzhvlIfuQtmAfbkG5Zz4MoKzkb4uKz dkga9UFoIcFvYgScFpMi36B8zb14/D0xymglrIqi4vBJYZIcDDjqva0Ta44NWflwixRO5 +h8D0zSWOYzCvGSTc4m9cjin1h+IrW2hMmeRIBrULX+ViHZozOq+rt2BS17ezuXaIK4eF BKPudWfCRYwkMSDsoA77T1KmWN9cPZkuPiBF+U/G7MJmcYOrcvoYRJKOaqJeHB0/81g== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=ZJYHgQoV; arc=pass header.oldest-pass=0 smtp.remote-ip=40.93.195.32 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012032.outbound.protection.outlook.com [40.93.195.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EFD3606A339; Thu, 19 Nov 2026 16:49:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0EFD3606A339 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=ZJYHgQoV ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yJBpUVQnq4j5fJ1VWLGxKEVk4TyG0012K4A6wDyHunBb0imwzCNWeLklPsJc+sseWn9/QLyzkgqP+OybZcZuaOeyASe/dPClo6NKX7u60yCy02SPNJDhATFWbaxTcnjykCMuIcPRBeQkGvw2DBRlEIjbGtvXnekU6hj/ScSDOtkUhfDHHDaIwvpegdJryy/Ou9oe8ejhXl8FxtZ8r2rXwCkTFdril8PoMPSA2hvHWvTaIQdnL8utnI/xwMvb142vWI6a+Frc0DBltfVb7taTxyy8p3dDKZAc0LIanysQKd/4Iu8tyNUbA8TKMggO30FUNFtTiWETdvevyrCvQq5K2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CuYFhjs7mCVDiJ2gP24B9f05HZH0srWTAYA9BObVOWI=; b=ajptfLlrhNvJoOcg2BE8nC69d/CBevMjAblbTOYse7gUgpDLoesn4IH/6uxchZPrL3qo2d3QFtFDWcYTWYOfSbts7uwCyJt8nd+Un6Ru9QTck27GljF41MMaCT5tygLtsoG1Ez2NGPVboSrWikJab+I5VQBKxkbH8wUWYGuPoL6jrKIe/YxEGKhuFUTdd+VgLq5WPqkSRacIJWbr+br52ht0i4IeHeMoIxg+SC1XDZK1ek9bi01wnVbLoCDmwRYO4MlQQ6Ygz8HCqJXdJEwuSJvmZKHiimPaNOBFPh0fjqSfO2DxU7JBpL3aKTqz5n8JqInza+tA/W/lk6ZfqeLz1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CuYFhjs7mCVDiJ2gP24B9f05HZH0srWTAYA9BObVOWI=; b=ZJYHgQoV8rhYQzgF90uYiKoZG+SuFgwp2k4txzZ8yXEZP0SecyIWdqs8w/YfOM7UCQ92anT54EGzEmpXd314xTaGD25TUS0taI9pVawFYYOFLVdU7Jj6M+a1ka5Qba8gbk9bQjtztCqRkCMISRjw6q1BQHHFOpBL+DEMEHwksSQKxoHWNr3yzba/qDaa6/yNqfwXv60YE5BYZNHqoQPeMEemZXRXls8bMSzNUFxCUyJh6kH0belpj476Mft/Gcz/WxS9G+F7pEVj375OF/rRMORiibFlQBx8Afu3eVJlvR7yf80AHZP+lXIJBXggifLXwjl4ol+W3YUtCMpZru5www== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) by SA0PR12MB4480.namprd12.prod.outlook.com (2603:10b6:806:99::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.14; Thu, 19 Nov 2026 16:47:25 +0000 Received: from IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16]) by IA0PR12MB8374.namprd12.prod.outlook.com ([fe80::d85f:4c87:ae84:3f16%6]) with mapi id 15.21.0615.009; Thu, 19 Nov 2026 16:47:25 +0000 From: Zi Yan To: "David Hildenbrand (Arm)" Cc: Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , "Borislav Petkov (AMD)" , =?utf-8?q?Cenk_Y=C4=B1lmaz?= , Zhang Peng , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Andrew Morton , Matthew Brost , Joshua Hahn , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , Mel Gorman , Sasha Levin , Rik van Riel , Ingo Molnar , Peter Xu , Hugh Dickins , Axel Rasmussen , Johannes Weiner , Michal Hocko , Qi Zheng , Shakeel Butt , Yuanchu Xie , Wei Xu , Baolin Wang , Andrea Arcangeli , Thomas Gleixner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/4] mm: flush stale TLB entries before installing a CoW'ed folio Date: Thu, 19 Nov 2026 11:47:21 -0500 X-Mailer: MailMate (3.0r7038) Message-ID: <22DF2F1E-2692-48AC-AEE5-79B61947D86D@nvidia.com> In-Reply-To: <20261118-file_folio_flush-v1-1-e9e739ed14e0@kernel.org> References: <20261118-file_folio_flush-v1-0-e9e739ed14e0@kernel.org> <20261118-file_folio_flush-v1-1-e9e739ed14e0@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-MS-Reactions: disallow X-ClientProxiedBy: BN0PR04CA0085.namprd04.prod.outlook.com (2603:10b6:408:ea::30) To IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR12MB8374:EE_|SA0PR12MB4480:EE_ X-MS-Office365-Filtering-Correlation-Id: 7011a649-115f-47d9-ab17-08df465cca4e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|7416014|376014|261102123227099003|261026140227099003|261026121527099003|261028144727099003|11063799006|261022115727099003|261021121427099003|261021123027099003|261022105027099003|4143699003|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: Hh+wY8QD9WjvvNlU3Bt7k1cCdv9BwmM1a2ZcD335H67IpiFxkWlTxSh1RL2XUW1iAlucrYQFFWxKeIdM4MJFTZq5th1IXSOE/WV4SMgR1yMfgnvAwPzxkwgf6yHp7msQcZzEg/tbUAhpiKYnqVrLuE58XPMwAkdlfchfuHMDygn8lGnOMDX7753Mm3I0UEwtJtY98U8B0F73zjXwhH/Xi4YHLZ25FDfZ6G8sRBN/oxNkQoUo0/IMMs6nPNGQpth4znLkSOHKqWN9udu61H3O0IMCZz8+VlmNb5UbSRwFKlUYXugoPNMSt5GBXpn/MeuRoEHYkDXLtwefQQsQUhm21BSQBHtUGwpsPFOT/IsRKgTHmOgnW9UY9oQ0caasmDh+gyzWjBTvfteMrklGBo6hT4lKCJGwDKVvm+SU+A0PBkWd6n78rrupVCY/kAGcrPmpLQm7orDgV2DAxPUQP6qUPikQfphkbGmSlbrWQThBVDHJQOku3EMcUeHlKPZJi2v8r8KgGfEAn6m/tV/+BxbmZ8dpu7EjQ/7o6i6NL4h2zZZh6z0rMLGHJfTdSMWljgERtpqYHU9hz0wrNQ8UwwFuImBl+3XYXxm6C13RqoQhIABLf0pi95WM6mzwByQlG1hbcD5gUiBcrfMzRXhJZrELmoOM9/Tq6nRtrhE1EQevaMs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR12MB8374.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(7416014)(376014)(261102123227099003)(261026140227099003)(261026121527099003)(261028144727099003)(11063799006)(261022115727099003)(261021121427099003)(261021123027099003)(261022105027099003)(4143699003)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjlQd0JuU0hxTmsybDcwbHlRNGR1d3NmVm5nR3Z2SFg2Y2UzOVNtYkhsMk82?= =?utf-8?B?ZGZTRi94aVhubjVVSXdsWkVjSU5XWW41c1Z2NE5JTHk5dXAycHNCQWJQdVZh?= =?utf-8?B?dm1iUTBTUFFKN0NVNEtWV2RRR2M4eGlMY0lLNnBtTzBSWjY3L2E5RHN0L0s3?= =?utf-8?B?dWpCc1VUdElraEVyTzhMdzc1UE9scnFZUEJiKzdvMGRBNEgvd1JTMG0rOEFW?= =?utf-8?B?bDE3M3JJaUJ4bXlNN3VHVUgyTUtwZ0UzMUpLcnRSUWRDcDgrUGY1OUFuazkr?= =?utf-8?B?KzZDZ3pxMXNST0NzVWN5N1duWGlQSGUwNTdTT3RWM2lPOVJFcmNEMGxoQ0xm?= =?utf-8?B?a1FacGsrR0R4MlIvWWtpMHk5WGZJQlVJUE54NEdqUnlTWkVCMkMya2txQm1V?= =?utf-8?B?Z1RLVXk1cVJtOFlwMEFCZnpvVjNhS1dDbS84QXJJLzF5cnFuak1HcjBsQUNB?= =?utf-8?B?dk1EMjlEbXlqMmhLcmgwWG52Y0hzOTVId0dsdlg4SisyZlkxQTJPZEppVW04?= =?utf-8?B?REk0TVB4ZVF1MUxrVGliYlF4d0k5VGREa3U5dUk5bjVLZmFYRlJWRnpXM1p3?= =?utf-8?B?emZtcHJ2by9iZVhoVStaTEo2NnFrSE1SNG5xOGtLb2hSOTNBdEc1Y1I3bW9E?= =?utf-8?B?dWhDRVVpcXg4YjdUbkZWYzhNYldqbDhMdVNtbTRkU0NuYjFTNVFiSTlCcGc0?= =?utf-8?B?bHIrK0hwaHlXdzlBSE1jQmlxbFZ2WTQ1MkpNZGs2eFVleFlQc3RsUFZ5UGwz?= =?utf-8?B?Ync3djJ2emZsR1RvU251MGZYeTV3S3RtQVhnSEU0VGRhTVBlQnlXak84amJH?= =?utf-8?B?U0NrQS9NYStRNVVuc016ZHFlVi9kMHF0Znk5cFBUVktDUldSNytYbmVKM2pS?= =?utf-8?B?N2ZBZ0ZNNDdORUFMUys3Wm1nR0lIczFNU0VHbkZFZGFlTWhlTVk0czN2WWFS?= =?utf-8?B?VE1CeHVKSEZhR2haVkxCVlhsM2lxQkUxeFJLZERod2VkRTdSNFVEOHNZK21X?= =?utf-8?B?aEczWkhIeTFsSVptZUZzYzN6bFF0MTIrZ25qTWRMZGNsUDk4aDlQZzFvWlA0?= =?utf-8?B?L3FJRGRua0p3TjZzS3U5M1BINEVMY0VoWmRuUyt4MkJuWUtUSkUrODlzQ1lm?= =?utf-8?B?ZTBpcnd0d1lTR3NZRG9uRk9iNzBTOVRzWDJsdVA0THFFUm5hdncxcU82QVRj?= =?utf-8?B?Y0M2QjdhU0M0WUo4Qzg2UTRET1FIZWFoNVFYWlV6aUxqWUMzdm5MRVUvUjRP?= =?utf-8?B?K2Z5clI4K0VoYk1OaTZmMHhQSGdzN2I1TDdQYXhmc2VOZEtlZFQ1OUswc1Ev?= =?utf-8?B?TnZyaGxJdTBmZ0QxemZMUUVIRWtOS3dLcmQ0ejltd1hGQW02em9QNHRiVzhx?= =?utf-8?B?MzUvVGxxTG5LamNMU3JNN21IQndqWW9NaldoOEYyalJLTnIrOUhDMnBIODht?= =?utf-8?B?VHc5SGhUdFovdkU5VWNNejNHQVJGWjArLzRuMkFFUzhmSVV5RFcyRjRCczN3?= =?utf-8?B?QUU4Tmlua1FuQkxKRXBmeEhzSGYwU2REbVJROGIrenUyMFk2NkFDMEc2ZmE3?= =?utf-8?B?WHR5M0hqbE5EMXpNd3dQakJjckVVcmo1aWxQbDBaSUlacHU5d1FTRm02Tkdq?= =?utf-8?B?WGlTV1Fsa2JvTUI4RnEzdkltSWl2M0pJSDlRZ1N4VTUxWnJBMGFTQlVndVU1?= =?utf-8?B?R2Q5U3BGYmR2NkFzTXI4NnQzblgzVlZad2c2RUd3ekU5UVFaSnd6TUxISms3?= =?utf-8?B?dTZNZEZqOXZVQk5ZQjNQYWpUSmtwV1VpSU1Vem95YUZ2b3BSMHJaTGhUMkI1?= =?utf-8?B?eTQ2cDh1VjFhR2FFOTk2N0RnTjIvVE5Gc1M0eFdRUkZYTnVMVnVJclY4cmQ5?= =?utf-8?B?d2tzMDJhWWpnS2E0NUJLNHhpcUF5Nnh1OXFrbXNkNWJmeUpIbHY1M2txVEV1?= =?utf-8?B?S3c3WFNMMmgyRWJTakRIM0pSbTdDdTJVWG5WUU9VUEdKYWhQeTJPenYxTXU5?= =?utf-8?B?dS80ajVaV29oOVdOaERFaG5MdlBLYTNVQmRlODFha0RlUEc4eGZTNnFnZFZS?= =?utf-8?B?MExpY2dXSjlCc2xFUTVzbHBONC8vRG5qMUVsWkhKbHNUTklSSHl2Nk00dmZ5?= =?utf-8?B?N3E3UVlTeEtWeXFkVUpIaDBrWXNjcGZTODlYZnVJU2tLM2hjZ1Z6bkxpeGlh?= =?utf-8?B?SGVsVUJNQVM5YUxWZjNMb0JZdGVNK28xV3BhSDlLQUtVVzF1Zi9jT0tFM3Zv?= =?utf-8?B?OU92b2s3d2JWaGtoZFJCaEFkc3Z4KzFZdjU4ZVJTSWl2RHhqMVNkSUtrNStY?= =?utf-8?Q?PKRK4LBPXu7u3Sj93X?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7011a649-115f-47d9-ab17-08df465cca4e X-MS-Exchange-CrossTenant-AuthSource: IA0PR12MB8374.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2026 16:47:25.6016 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LSi1R6rhhA+jFCxuBkLGokgCNEE1LsRtC3P5JIgZWVuBHIzN14yvoPgWt36v2Rnb X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4480 On 18 Nov 2026, at 4:20, David Hildenbrand (Arm) wrote: > Zapping PTEs in zap_pte_range() defers the TLB flush until after dropping > the PTL for clean page-cache folios. > > A concurrent write fault in a MAP_PRIVATE mapping can then CoW the > page-cache folio and install a new anon folio without a prior TLB > flush: > > CPU0 CPU1 > LOAD(ADDR) > -> #PF > installs R/O PTE -> A > fuse_open() > -> invalidate_inode_pages2() > -> zap_pte_range() > clears R/O PTE > // delayed flush > // Other CPUs (incl CPU0) still cache ADDR -> A > STORE(ADDR) > -> #PF > do_cow_fault() > copies A to B, installs R/W PTE -> B > // no TLB flush: PTE was none > > CPUs with stale TLB entries will still read from the old folio while writes > go to the new folio, until the TLB is flushed. > > We really must process pending TLB flushes if we are not faulting the > same folio back in. > > Fix it by flushing the TLB before installing an anon (CoW'ed) folio in > set_pte_range() if a TLB flush is pending. Zapping itself stays as fast > as before. > > Other faults are not affected: unmap_mapping_*() users only remove > folios from the page-cache after their own TLB flush, so until then, a > refault maps the same folio again. The exception is a concurrent > invalidation that removes the already-unmapped folio from the > page-cache before the zapper flushed the TLB; that is an unlikely corner > case that we'll not handle for now. > > Note that we don't care about MADV_DONTNEED followed by a new read > fault, as MADV_DONTNEED only guarantees its semantics once the operation > completed. CoW faults will flush the TLB either way. > > For example, imagine that MADV_DONTNEED zaps a page-cache folio and > doesn't flush the TLB (but still holds a reference). If the page-cache > replaces the folio, a new read fault might map the new folio without > flushing the TLB. That's okay, as MADV_DONTNEED did not complete yet. > Same applies to MADV_DONTNEED of CoW'ed folios when re-faulting the > page-cache folio. > > Memory reclaim, which removes folios from the page-cache before performing > its own batched TLB flush, will be handled separately. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") This is really old. > Reported-by: Cenk Yılmaz > Debugged-by: Cenk Yılmaz > Cc: stable@vger.kernel.org > Signed-off-by: David Hildenbrand (Arm) > --- > mm/memory.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mm/memory.c b/mm/memory.c > index d2f48d78b0d7b..e1d9759e6fde1 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -5888,6 +5888,12 @@ void set_pte_range(struct vm_fault *vmf, struct folio *folio, > /* copy-on-write page */ > if (write && !(vma->vm_flags & VM_SHARED)) { > VM_BUG_ON_FOLIO(nr != 1, folio); > + /* > + * Concurrent zapping might have dropped the PTL but not flushed > + * the TLB yet. Flush before installing a new folio. > + */ > + if (mm_tlb_flush_pending(vma->vm_mm)) > + flush_tlb_page(vma, addr); This looks like an adhoc fix, but it is minimal for backport. Hopefully we can find a cleaner refactoring later. > folio_add_new_anon_rmap(folio, vma, addr, RMAP_EXCLUSIVE); > folio_add_lru_vma(folio, vma); > } else { Reviewed-by: Zi Yan Best Regards, Yan, Zi