From: Dan Carpenter <dan.carpenter@linaro.org>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Erick Karanja <karanja99erick@gmail.com>,
gregkh@linuxfoundation.org, outreachy@lists.linux.dev,
philipp.g.hortmann@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: Improve code readability
Date: Wed, 9 Apr 2025 14:11:21 +0300 [thread overview]
Message-ID: <22a2c8a7-9669-40bd-b886-713833de5cc4@stanley.mountain> (raw)
In-Reply-To: <3dda7f97-4ed8-cf6d-9310-60ed6259a386@inria.fr>
On Wed, Apr 09, 2025 at 07:04:18AM -0400, Julia Lawall wrote:
> > @@ -729,10 +721,9 @@ static void hal_ReadEFuse_WiFi(
> > }
> >
> > if (offset < EFUSE_MAX_SECTION_8723B) {
> > - u16 addr;
> > + u16 addr = offset * PGPKT_DATA_SIZE;
> > /* Get word enable value from PG header */
> >
> > - addr = offset * PGPKT_DATA_SIZE;
>
> I'm not sure about this one, due to the comment.
>
> julia
>
I feel like it works. I wish there were a blank line after the
declaration but that's something for a different patch. Both of
these are okay with me. Try to be more creative with the subjects
next time. (Just put the file name in the subject because that's
the only difference).
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
next prev parent reply other threads:[~2025-04-09 11:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 10:04 [PATCH v2 0/2] Improve code readability in rtl8723bs module Erick Karanja
2025-04-09 10:04 ` [PATCH v2 1/2] staging: rtl8723bs: Improve code readability Erick Karanja
2025-04-09 11:04 ` Julia Lawall
2025-04-09 11:11 ` Dan Carpenter [this message]
2025-04-09 11:22 ` Erick Karanja
2025-04-09 11:32 ` Erick Karanja
2025-04-09 15:39 ` Julia Lawall
2025-04-09 10:04 ` [PATCH v2 2/2] staging: rtl8723bs: Initializing variables at declaration Erick Karanja
2025-04-09 15:41 ` Julia Lawall
2025-04-10 5:39 ` Erick Karanja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22a2c8a7-9669-40bd-b886-713833de5cc4@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=karanja99erick@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®