From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC375383320 for ; Thu, 21 May 2026 10:16:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779358616; cv=none; b=SMZVLUnzou/cBC6+Pf+pdSfsxJZVB5KrvhVdfGI0yOa8jfevrat+bN/+AVpHRt1dDKBCKl5Gaumy3lUAfvJsC+3cLRVq4tHWx3ULbOsTo5m560YHnan51NXtTyV/8/q1rb2W4StjF/mfBzklv3+MdxZdEFpZ16ZPlJf2XDrEp4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779358616; c=relaxed/simple; bh=Z3KAG24ikGctN8+3JXxzF/QjpEQrkx80Kwtm6MVN8Zc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M1FbZ4P67tfZNKWu6eaKJWcjIrbSDSz1m+q53a+lnqzYH4a/nzJew1KbSw6WsyK33mrvW11DmW310572FrJM/NB+wPnQAKFgur58PXgO1jC7nfeB1rlP1vETrpMJxDN/cIw+Jh0j57GZePjBsLvGJ73n9KZ+eHY760FVwIv8vb8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=n2KqCiRr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TwIjVE/y; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="n2KqCiRr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TwIjVE/y" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L9A3K52633671 for ; Thu, 21 May 2026 10:16:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= e35ASpDbu+JzlJXy6vzQPsFHJsqGdEATPmzNaYDOTrk=; b=n2KqCiRrOQrxLNGF XgBkFgRwHC2u1RPF5a/auykres/jpwRgCdtJtROt6BASxFvKYL+Qfhju5Dz6F6mF G+hfxCHv85g3xPYMaJxNlfXoH284Ofwj0oylvJc4GpMK42w4Ykbi3bMFumP3dGVn Of3qQ/AuuJXJ24iKJ65BPO3IerbeKQ8W6XZEqt0Y4INWvvdUnzOxXDCSS5NQP9yU YQ1/YFvSg+qAsf+bIwNfhsp+QmbuH/pux4UglorAuGH+3KDIOePVZTWhcKI3rWkU Bgd5ipAhxEfTGDhgXs+/b86rAa6+H9YyBoLagFfCMGxmomgpsus3+zWqvMYiQ/zc cpABdQ== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9ee8cfub-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 10:16:54 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82fa366fb79so8123940b3a.2 for ; Thu, 21 May 2026 03:16:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779358614; x=1779963414; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e35ASpDbu+JzlJXy6vzQPsFHJsqGdEATPmzNaYDOTrk=; b=TwIjVE/yZ9Fp+wDulH6B+hWohwEtI6luF53CsaofwIZMWhNc9Ff7bB0Wh1ts+xk5ug 11kcFURop8LgtLM62/KCkkP2+OR48NgC4/7EZ3mI0Hhji+p3mncfbBqHT0yJjPAfkaWP gE4fPD7jJq+uU8n0imS8n8pJZ5IX7YEQuM6Vz9Jl5XvW1NZupkFSXGwnBujMBsQ4bZSk cHWtsgbDpUjPa7KDHCGX/QsntwS0H+tFTeoWCJowafiifROitrJkqSDsUQ07JHEpm1rP LZOvX8W331tvhX3lTkOL8SKeFSewCcqeXSElWCEOtTgl+SwWzvmdF63UiXIJmTI4MltU sMRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779358614; x=1779963414; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e35ASpDbu+JzlJXy6vzQPsFHJsqGdEATPmzNaYDOTrk=; b=tINFMQEu4ad/JPAYJjdZP87EaBUNzhzWbdS0W01cVH4zIdTVllEoTqXW3845cqqEEv LduRQx5+J5i5S/2/kGBR2ACPZ3E61TEe0DYPqHvZ7Vm8+Ep9xG/cb3uKA+FJgBGQNIuO 6hgluSQNtAbIKrrO0CL+xfTLDYutE1XokdlnP6euhMF612jBrkxnUUrcpwzR3RL4uM/r EXv7N3vCHQOzfrB9YZtQiEIr9ohblvZRwWgwGu+skjRg9lToneQZ7MbhRes7aLpMlsiM lYAUlhNeYbueKc8gskiwg78zKQkxgDRC6ZaGekhNRo3QqGIWk2ciahsuXn6lVXYWgZ0O miCg== X-Forwarded-Encrypted: i=1; AFNElJ+64rrO/kukvhe0GlKbtjwtbTHHLvbe3NNdrdpjqVS6URXjoWUuk/asGBf3jnM41IKvNwO9WGCSfC30tiQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxLx5x8TzIF4bUeZWuSvFioEWRJsUHO5Mcst37fC3Na5DNIvGBZ m2IckZWWouvj1xNuUnxymXSsEZ0aiZy9Bbu2bMRNKI1jDDOu1i4jL6klNzlGTRjIRpHtqmXpCmG V3wUBExiRYK6GcF14O3RJpR4zgMmfuaVftUfyH/BZnqMkZEixRKfhiJs6R1bdkgJUdtY= X-Gm-Gg: Acq92OHVSoKaJLKDCKaPi71m2wXA70OzBfLKuXIEEs7R83k59LqTZIdYtafDB3XkTwU IRo1SoOb6g4urvKGlhR/Dwdc+mdE9jp499MSvBwibTPEIo2+jOq22klfQ++JP6Hs1iIasaOJwf6 WcTCPGEaUJv10v9Bv7wGcvdw7s9gL6BfTl1BebN1ZMXu4ZG/AutcaXN3aO5HlJQFfePhllhSlJq RdAUO2ZQZ2oejjyojlLGcks6w3jIdClV32J7TgOY20gHHiYSosECMgDUEoOJz97gbdPmkfFkZCI V2P4/FkWuLiXGspJMaEXKzbjWSmpmcHBqOwFf4IF4HIeddKa7Tc86OfsYCAdDXvdueJFjMnauvy hK8yOlL+GqQwKR3IivBAn+sMTNj91QPCuBdZvoAuXakM/WoT18jHgc7AP X-Received: by 2002:a05:6a00:330c:b0:82f:390a:69c7 with SMTP id d2e1a72fcca58-8414ae6e041mr2501851b3a.33.1779358614188; Thu, 21 May 2026 03:16:54 -0700 (PDT) X-Received: by 2002:a05:6a00:330c:b0:82f:390a:69c7 with SMTP id d2e1a72fcca58-8414ae6e041mr2501811b3a.33.1779358613617; Thu, 21 May 2026 03:16:53 -0700 (PDT) Received: from [10.217.219.207] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84154e3d6a7sm997070b3a.55.2026.05.21.03.16.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 03:16:53 -0700 (PDT) Message-ID: <22af0378-a3c9-4403-a0ee-da794847f41d@oss.qualcomm.com> Date: Thu, 21 May 2026 15:46:47 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] i2c: imx: mark I2C adapter when hardware is powered down To: "Carlos Song (OSS)" , Mukesh Savaliya , "o.rempel@pengutronix.de" , "kernel@pengutronix.de" , "andi.shyti@kernel.org" , Frank Li , "s.hauer@pengutronix.de" , "festevam@gmail.com" , Carlos Song , Bough Chen Cc: "linux-i2c@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" References: <20260520101504.2885873-1-carlos.song@oss.nxp.com> <4979e748-ce4e-4244-8906-e22a1e6472e7@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 9M7KLYnCDO-W9PWlNdIKGyE9zjTt2xGG X-Authority-Analysis: v=2.4 cv=e5k2j6p/ c=1 sm=1 tr=0 ts=6a0edb96 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=_EeEMxcBAAAA:8 a=EUspDBNiAAAA:8 a=8AirrxEcAAAA:8 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=JfrnYn6hAAAA:8 a=yJUUZN2m8lq9mbh6i7kA:9 a=QEXdDO2ut3YA:10 a=czjwGCTIUPoA:10 a=OpyuDcXvxspvyRM73sMx:22 a=ST-jHhOKWsTCqRlWije3:22 a=1CNFftbPRP8L7MoqJWF3:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDEwMiBTYWx0ZWRfX9VtW4Xo34kwv LEcjN3rAnm2fvI+7LvS9mZY9d0eOgoV7O5jRxcqjb5J4j5LUiV73rtGiRe0iGNJ2ETNrwHObBEO QBpa4ONn2izogm//MDwtAmjRDFWCZ6pyUgtO2Mm9X5nIeQDNUDBfngrrozszBzhmrZFtahSixst D54+vvYpJzSBNzKqCRaYeUG4xVKoTiDm5n3bi7YjO0/Tdx3vfUWCcdidVoXlZl9A69ZTdhNotJJ HPeXci+OjENrlEzHEXsi0K+VcfBhgUuiyOCRztQv++BB/dk4/Yek/UHYsnEGg9scvMJ2//u1nRY HTkbCbvplgE0vNSxulbO80wJZ35Goga/t65iLPVjMxpbCsWigkKauUmopE/kb2o4EsRoa2zz+N6 9zNXkGh4uuWZVpQUI0hs0LJk6o5RYxotf3qQqXGztbUv76nD0jYl+zVkt03lL8u5029KgdEcN5o PajjImqZGcB92Whwidg== X-Proofpoint-GUID: 9M7KLYnCDO-W9PWlNdIKGyE9zjTt2xGG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210102 Thanks Carlos ! On 5/21/2026 1:57 PM, Carlos Song (OSS) wrote: > > >> -----Original Message----- >> From: Mukesh Savaliya >> Sent: Thursday, May 21, 2026 3:40 PM >> To: Carlos Song (OSS) ; o.rempel@pengutronix.de; >> kernel@pengutronix.de; andi.shyti@kernel.org; Frank Li ; >> s.hauer@pengutronix.de; festevam@gmail.com; Carlos Song >> ; Bough Chen >> Cc: linux-i2c@vger.kernel.org; imx@lists.linux.dev; >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; >> stable@vger.kernel.org >> Subject: Re: [PATCH v3] i2c: imx: mark I2C adapter when hardware is powered >> down >> >> [You don't often get email from mukesh.savaliya@oss.qualcomm.com. Learn >> why this is important at https://aka.ms/LearnAboutSenderIdentification ] >> >> Hi Carlos, >> >> On 5/20/2026 3:45 PM, Carlos Song (OSS) wrote: >>> From: Carlos Song >>> >>> Mark the I2C adapter as suspended during system suspend to block >>> further transfers, and resume it on system resume. This prevents >>> potential hangs when the hardware is powered down but clients still attempt >> I2C transfers. >>> what was the reason of this hang ? I was thinking you don't have interrupts working when client requested transfer but adapter was suspended. Please correct me if wrong. And it would be good to mention the actual problem and why/how it occurred. >> Code changes looks fine to me but have comment on commit log. >> >> It seems, you are adding support of _noirq() callbacks to allow transfers during >> suspend/resume noirq phase of PM. >> >> Would it make sense if you can write "Replace system PM callbacks with noirq >> PM callbacks" OR "Allow transfers during _noirq phase of the PM ops" instead of >> "mark I2C adapter when hardware is powered down" ? >> > > Hi, > > Thank you for your comments! > > But this patch is added is not for support noirq PM callback or transfer in noirq phase. > Okay, may be actual problem description can help me. > In fact, this fix is to mark the I2C adapter as suspended during system noirq suspend to block further > transfers, and resume it on system noirq resume. This is to prohibit I2C device calling the I2C controller > after the system noirq suspend and before noirq resume, because at this time the I2C instance is powered > off or the clock is disabled ... So I want to keep current commit. How do you think? completely Makes sense. Please help add how this problem occurred and why ? So the change/fix will be good to understand against it. > > Carlos Song