From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C1AA5CDF1 for ; Thu, 20 Nov 2025 23:17:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763680658; cv=none; b=e2ToIKlnPQadANsnMooVQvuVz0Vze7QDntDigMghI9as3sXL7LFyoo7cWCJeYBo8+PBfRcwmgFjQiTK7+Ni214vZ98ih2SP+wLJllMJndj/pG7hkEDHyrdmPcrQfvGRioZ0UGvRsyzBwZ/3jeAj3Qrm49imayQL7egZvgmJ1lh4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763680658; c=relaxed/simple; bh=33btBazeCCx6oRL2zowEEBmDuoYz/oAedIhTvNF+Igc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G4ZwAQqKe04JJCTknLU3r9RNKjrLU8m8e08RSVdOjJBsSCqn9xfb2usAPDmeIaMZ4Qi7Y+qFHKPcFCG+3EUZbF3GUJR9wNnd5JsHi/PnFMid06NO0rTmeYEMLn7x65E9DE7yaWIDHGnjJg7Cnk+7ctt7KrEEGhT2/XV0eCQb8e4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kAb4ILH9; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kAb4ILH9" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4779ce2a624so12836495e9.2 for ; Thu, 20 Nov 2025 15:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763680655; x=1764285455; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NtqPla6uIDCHOIDysafj/hVFYpShG3R2Dkwsi1K1e5w=; b=kAb4ILH9WZIrA0HohIbRKpH1yLH0KuEkicqKVTj7Kv/FAEY9WFlkQcbMDxNLRQsDpJ G/CmOUKt+965UoocF7xCvzFXCp+l4aj8HIO7KKuP2bZHasXohjnkcM1kn6sTw7r2tw2J BZex+t+N/VZ04fjDZAXXLfL0INPxNFh+uSISbjEywIEO6J36OaSucLFOtchWkZiQsRJO g4FnGMGGftKzLDbzP8B2D3Z0gQnjMWgHn6vX97nwkqt+Acs0QYwZhE45x3PoPjV3cpux FnWT/Tk8wF6J/JEazOQ1Ys6FmdXilq+PXNzW9wTJfo/w7Eoanw379//Ra9T+5rkhjl0m WLww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763680655; x=1764285455; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NtqPla6uIDCHOIDysafj/hVFYpShG3R2Dkwsi1K1e5w=; b=DCppCWaAxuK4yLqFPPXjQQpkGEOZ06FyxrywyGx67R+9+yinKwiTa7wIhGyOv2w3Y4 8UhlHpqYPE7wXaIBpAlB3jkE4NmwE/omCjORp0ZBt9nPQKt3JGrELTCA3P2PKCYEn7D4 3Z21VpR1iyIIYYzZe0deLOAEemBvS+jo9eWMDwI3aqRJI+kPkHV9a7u/YyUFwe1Mo6di 1tK+lTUREjDJuqZYg6ZU6CPhHOqufSvg468lgWsUy3/Lkej9tKlP/2rNxYzPT3nNTFZu cr86lFjRKiou4XXbSdSU6r7nP4gr9/IlpKWoMBLQZwdiWdkCoZUc7mi6BdRk3F8rhZMk Y9YA== X-Forwarded-Encrypted: i=1; AJvYcCVP7+GfE0tM8DybYqid6bkwSIvrNKtFdFNS/zQb09f0lDMCzJjPkuq3g8vv1rvc1Hs1liw3VRGvXUMrReI=@vger.kernel.org X-Gm-Message-State: AOJu0YwNniaw2perXPMocZ0akyCh0zYzH+pP9v7Rgf/ekGdjdx4oOahc /byAiAjWByssyMqR/Pj/9Yxa/S6+NMbgZ7C1hCRqSEGTVFLo1BLo/U7v X-Gm-Gg: ASbGncvITE6qfItLuntaOKTJsV2mISBvFQXguvTrWo8ptbBz/22AUDqaDQconaySVyZ tomegg70kTbJQCdXMAS2BfH3zbY8keJJaUnFTtzFAXuBNq4eYPfkx9UpTZKmBT3WXXEHSBALbgV QBO2KhKsnojRmjm1UIp1gUleTjJMjQExNL8NGBJoonpraDyFCQyP18/zlJk3lPvf2LHJm9It6kt YFWAQHP8klngMrDFryQvPIKTzlRUSMRjV/5WzT7JDkny74iCxNzYhXSqXgm0cABEkBGyU1CljD5 pDSZUBhHTG9WK7x4rg7gnFy6hYnTODqgdVJqQyWJECAqg2VmACCDU9qoru65vpgRMfOi07tFWOI 0uEDsibnJbratjkamiCAZwP0e9+bme48maNMdIAfAW0PIIqewNT4bet30rRM7ktcBBsLVOAsx4l 5BHLduTt5WCvi5pipu3xsXEqyYTw7JDL61JPKe/f3U8ZxrLPgxLmihW972Vs+HLFwXGE1N2NaaM orvTZ7KuJ7gIlWziRPueHKxYmps27Bd0hJQbMJmplwpO7ZlgZw+DA== X-Google-Smtp-Source: AGHT+IEwJHHQj2UIIxWkRH2QWIfRMW5HiZmVPji97KG1U1u7KnRePSUjiJ/npH4Yk8b3fulxOxbuFA== X-Received: by 2002:a05:600c:4f4a:b0:475:e007:bae0 with SMTP id 5b1f17b1804b1-477c01be32cmr4594385e9.16.1763680655232; Thu, 20 Nov 2025 15:17:35 -0800 (PST) Received: from ?IPV6:2003:ea:8f3a:7100:6cbf:5f75:6c2d:3ca3? (p200300ea8f3a71006cbf5f756c2d3ca3.dip0.t-ipconnect.de. [2003:ea:8f3a:7100:6cbf:5f75:6c2d:3ca3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477a9e19875sm70906365e9.16.2025.11.20.15.17.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Nov 2025 15:17:34 -0800 (PST) Message-ID: <22b15123-b134-467c-835c-c9e0f1e19e29@gmail.com> Date: Fri, 21 Nov 2025 00:17:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] r8169: add support for RTL8127ATF To: Fabio Baltieri , Michael Zimmermann Cc: Andrew Lunn , nic_swsd@realtek.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251117191657.4106-1-fabio.baltieri@gmail.com> <89298d49-d85f-4dfd-954c-f8ca9b47f386@lunn.ch> Content-Language: en-US From: Heiner Kallweit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/19/2025 11:26 AM, Fabio Baltieri wrote: > On Wed, Nov 19, 2025 at 08:00:01AM +0100, Michael Zimmermann wrote: >> I've also done some testing with the out-of-tree driver: >> - (my normal setup) a DAC between the rt8127 and a 10G switch works just fine. >> - RJ45 10G modules on both sides works fine, but HwFiberModeVer stays >> at 1 even after reloading the driver. >> - RJ45 1G modules on both sides works after "ethtool -s enp1s0 speed >> 1000 duplex full autoneg on", but you have to do that while connected >> via 10G because that driver is buggy and returns EINVAL otherwise. >> HwFiberModeVer was 1 as well after reloading the driver. > > You are right, did some more extensive testing and it seems like > switching speed is somewhat unreliable. > > I've also bumped into > https://lore.kernel.org/netdev/cc1c8d30-fda0-4d3d-ad61-3ff932ef0222@gmail.com/ > and sure enough this is affected too, it also does not survive suspend > without the wol flag, but more importantly I've found that the serdes > has to be reconfigured on resume, so I need to send a v2 moving some > code around. > Could you please test whether the following fixes the chip hang on suspend / shutdown? diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index de304d1eb..97dbe8f89 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -1517,11 +1517,20 @@ static enum rtl_dash_type rtl_get_dash_type(struct rtl8169_private *tp) static void rtl_set_d3_pll_down(struct rtl8169_private *tp, bool enable) { - if (tp->mac_version >= RTL_GIGA_MAC_VER_25 && - tp->mac_version != RTL_GIGA_MAC_VER_28 && - tp->mac_version != RTL_GIGA_MAC_VER_31 && - tp->mac_version != RTL_GIGA_MAC_VER_38) - r8169_mod_reg8_cond(tp, PMCH, D3_NO_PLL_DOWN, !enable); + switch (tp->mac_version) { + case RTL_GIGA_MAC_VER_02 ... RTL_GIGA_MAC_VER_24: + case RTL_GIGA_MAC_VER_28: + case RTL_GIGA_MAC_VER_31: + case RTL_GIGA_MAC_VER_38: + break; + case RTL_GIGA_MAC_VER_80: + r8169_mod_reg8_cond(tp, PMCH, D3_NO_PLL_DOWN, true); + break; + default: + r8169_mod_reg8_cond(tp, PMCH, D3HOT_NO_PLL_DOWN, true); + r8169_mod_reg8_cond(tp, PMCH, D3COLD_NO_PLL_DOWN, !enable); + break; + } } static void rtl_reset_packet_filter(struct rtl8169_private *tp) -- 2.52.0