From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D622B3E4C86 for ; Wed, 18 Mar 2026 18:35:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773858954; cv=none; b=rffxAeAwqMxdtn5ZVjQdOLuBp8hRmplAsI3jWvwDgj92XeHYfEAYnV0OvgkvCiT7qnI0n6muv3O8/hLQ3c/L+UZ5FM3gX2ALnt8xLIV6loJ+xUOa/QWBbq/fC0TMN6O+3zgHLJXUwj0N97ugcHEoOI44iA9EPjsNo97JcmLhpqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773858954; c=relaxed/simple; bh=FHbqUJz1qg98S1kFnBdMI5LurL2tKtVKMf2OieQFW/U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CiBvNsS110v2dfjhP+9lsJE20ORHs9ipSGNfvPv8/66EtqmUdI9sDQNIMyzL7Th8LqeCKiKNOzFjDVCUvQxM+d2t+1b+dZE6sbhhuthL9m40AO0Ieh7OlKwUaDpaI1RXO9O7uzfc3Sv2i76Mo4DmIMJoHH9hapfVK7RzSLLc7e4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HYZGVDQe; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HYZGVDQe" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-12732165d1eso301779c88.1 for ; Wed, 18 Mar 2026 11:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773858951; x=1774463751; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MGYjogK2bqnTZSNWLTogcS+9CBE/p5Q+uf/wMeebhBo=; b=HYZGVDQeos8Xx79PoZOphhSOCAiRtveMov+4WjwIfA7pbwPPYn7ruS4me94SBEWLxd 5ftt9crYK6mY65yexUdIIFSZW1Kw1nbNqDpvPhcOyvQd8jEFlK96j+5eTmBdY5rN8Qyg 4rA7KGGE/Pg22J9VmMy6rCenqDgZkyRniVM5rX7uLAL0rr6bjYPvvajjcRk5QyR1waDy zNuS0ElHzP9PIVndyz4zTis0xmNEXy6rDIMJels0pSQ4IHe3sutSN50g66AjQyln+Mco uVEUY6N/2Xg44bwuYTdxcA/0N4HD7bPYf3+Q56wzYufwS4U+2j3BG+i2pnSawt5Sn7+h 1/tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773858951; x=1774463751; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MGYjogK2bqnTZSNWLTogcS+9CBE/p5Q+uf/wMeebhBo=; b=RW/ysPWmMHA9bcvKDbtMHkFR2VjnnE6i89A/UT18pxD2fumiHv1QdzW44BW4Nkx2vI 0WGSkt2kYN80OfTHDMkqGq619Cx5zGseTCN5JBaI1rH68/04BBjb5KwkhCAIwgkqq8+n FGy1kh6bCSxTxePhqr0gUnznHnw4o6bpTJ+6nPVyjgxrzernFKQKU2+Lim9XQhEZtc9t moKkANhqMmjiAxEi1ipqUekCRZUQX5olJoFD3VZH7jDoTk0ZCApJOqQizZRBUxhmQTsj VNFaHelR3SJQ8R3LerhhI59uislUAaBCgJVVShkjfyE3YFH4Z9YeEG5NsmayowjTfoIv 15Pg== X-Forwarded-Encrypted: i=1; AJvYcCVAiRVCYBpWEANHGsN9cR9zp4smxtY+liXGhoh/t3QpRdJTa0p/4zmMvLreK+pydjMbMb6tRQO+p5WDmEw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8gkEj1I4FbFGd3r4qm0ef33hupdoMhL/HjENBthc9gIvtWlLx EohbqLu23rx5jhOZB0XNR691h4OQpps+h0v394VFRIOMMmQbgfSp01i1A8lLNTYJhNo= X-Gm-Gg: ATEYQzwaaoTdpULIeA8HQ4Tah2ipOWWeMDMRu2UNw5Djx1BCCsq+Kb2Dwkj35yPLk5q FDzerr6w5iQUunpBNNs1eiGx2XiA9pGctd0Ve9HFuT6gp3MM81nO61JyecHpEmkU7M/bvAQZ1L1 ewHiyakyknL7h8gYHw/PnCfq8gqYoPg1Q/Q4/QbZandvDaLz2KVFSPY0j43wWlDKZz2rBrvQtPz 1glygK08roDxL8I0VJrIlXwunAQbQH5fMumw1OJ+w3bMhKoIYhoFRMbCaPP2jh87w1vWxvK8D6s pyZWllPxx7mCVNGVwGam6gnMVV1j9aRU724i4NU3SrTBvu0rhQ1pqiUQSwoOYJ+SWXOfiCFdcne FgjGLp5CHf8sMiCJULX4iMc2bg7V3zMh6QJicooqFVWFHKu70jUGkNn9uQTHP6OqKiCg7Hl8k4K s5IYqxdN3jRhN3fRqQkkNa07Tr1V7gH5JNeLbYwbZII8YEi7e+IezkE6sOQfgIzkWCmA8KD8iqn LvReA== X-Received: by 2002:a05:7022:239a:b0:127:9cad:1a65 with SMTP id a92af1059eb24-1299ba99df9mr2479792c88.14.1773858950492; Wed, 18 Mar 2026 11:35:50 -0700 (PDT) Received: from [192.168.68.65] (104-12-136-65.lightspeed.irvnca.sbcglobal.net. [104.12.136.65]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-129a7153051sm4145211c88.0.2026.03.18.11.35.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 11:35:50 -0700 (PDT) Message-ID: <22b1b8f1-b87d-4f34-9e04-0a39758bfe15@gmail.com> Date: Wed, 18 Mar 2026 11:35:48 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: leds: rt8515: Support single-GPIO flash ICs with unlock gate To: Krzysztof Kozlowski Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260306-expressatt_camera_flash-v1-0-b1996f7cdfdd@gmail.com> <20260306-expressatt_camera_flash-v1-1-b1996f7cdfdd@gmail.com> <20260307-fennec-of-nonstop-hurricane-de4f97@quoll> Content-Language: en-US From: Rudraksha Gupta In-Reply-To: <20260307-fennec-of-nonstop-hurricane-de4f97@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/7/26 07:46, Krzysztof Kozlowski wrote: > On Fri, Mar 06, 2026 at 04:58:02PM -0800, Rudraksha Gupta wrote: >> Some flash ICs use the same one-wire pulse-count protocol as the RT8515 >> but have only a single GPIO line for both flash and torch modes, plus an >> optional unlock gate (e.g. a PMIC MPP) that must be driven high before >> the chip responds to the enable GPIO. >> >> Make ent-gpios optional and add an unlock-gpios property to support >> these variants. Add a oneOf constraint requiring exactly one of >> ent-gpios or unlock-gpios. Add a binding example showing the >> single-GPIO configuration. >> >> Signed-off-by: Rudraksha Gupta >> --- >> .../devicetree/bindings/leds/richtek,rt8515.yaml | 36 +++++++++++++++++++++- >> 1 file changed, 35 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml >> index 0356371a6b01..820cf8c55090 100644 >> --- a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml >> +++ b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml >> @@ -15,6 +15,10 @@ description: | >> current for each mode is defined in hardware using two resistors >> RFS and RTS. >> >> + This driver also supports single-GPIO flash ICs that use the same > Drop reference to driver and explain the hardware here. > >> + one-wire pulse-count protocol on one line for both flash and torch. >> + For these, only enf-gpios is required. >> + >> properties: >> compatible: >> const: richtek,rt8515 >> @@ -26,6 +30,14 @@ properties: >> ent-gpios: >> maxItems: 1 >> description: A connection to the 'ENT' (enable torch) pin. >> + Optional for single-GPIO flash ICs where enf-gpios is used for >> + both flash and torch modes. > So what happens with ENT GPIO on such boards? How is it connected? Hello Krzysztof, Thanks for these comments. I have addressed these in v2 Rudraksha > > Best regards, > Krzysztof >