From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Nicolai Buchwitz <nb@tipi-net.de>,
Thomas Gleixner <tglx@kernel.org>, Radu Rendec <radu@rendec.net>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Stanimir Varbanov <svarbanov@suse.de>
Cc: "Krzysztof Wilczyński" <kwilczynski@kernel.org>,
linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] irqchip/bcm2712-mip: Fix multi-MSI allocation for non-power-of-two counts
Date: Thu, 12 Nov 2026 10:09:56 -0800 [thread overview]
Message-ID: <22b7948d-096c-4f76-863c-70819a4f989a@broadcom.com> (raw)
In-Reply-To: <20261112-bcm2712-mip-msi-align-v1-1-68090868c979@tipi-net.de>
On 11/12/26 03:58, Nicolai Buchwitz wrote:
> ilog2() rounds down, so a request for three vectors reserves only two
> slots and the third can overlap another allocation. The alignment is
> also applied to the bitmap index and ignores the msi_offset that is
> added to the message data.
>
> Reserve exactly the requested number of slots and align the start of
> the message data block to the vector count rounded up to a power of
> two.
>
> Fixes: 32c6c054661a ("irqchip: Add Broadcom BCM2712 MSI-X interrupt controller")
> Cc: stable@vger.kernel.org
> Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
prev parent reply other threads:[~2026-11-12 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 11:58 Nicolai Buchwitz
2026-11-12 18:09 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22b7948d-096c-4f76-863c-70819a4f989a@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nb@tipi-net.de \
--cc=radu@rendec.net \
--cc=svarbanov@suse.de \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®