From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D128C10F29 for ; Tue, 17 Mar 2020 14:43:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3768020735 for ; Tue, 17 Mar 2020 14:43:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="jX0aVra6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726530AbgCQOnQ (ORCPT ); Tue, 17 Mar 2020 10:43:16 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:17886 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726112AbgCQOnP (ORCPT ); Tue, 17 Mar 2020 10:43:15 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48hbWL0ktTz9txKB; Tue, 17 Mar 2020 15:43:10 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=jX0aVra6; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id RNzJeTCS2zXw; Tue, 17 Mar 2020 15:43:10 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48hbWK6nWSz9txK6; Tue, 17 Mar 2020 15:43:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1584456189; bh=aysZJ0oAlGihBmkcbuVURApboUV6znAXwjAIXT1Fqb8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=jX0aVra6NpHJierLO2o6lej5QYe1IaZKYnRs2FNd365bgNplX5De1a5dQnmFKTZB1 Mq4ydcqQ5laEyLsojIL0ZaS2RjK3iBP0+ymOI65V92f2XrPaoP8UtuwawB+5xqoesW WVjcds2rtOcejkeAvSdEX44eW4FrLMIv3bzHOPsk= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 59EF88B7BB; Tue, 17 Mar 2020 15:43:11 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id fqTBFZC1M03R; Tue, 17 Mar 2020 15:43:11 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 99B298B7B7; Tue, 17 Mar 2020 15:43:10 +0100 (CET) Subject: Re: [PATCH v1 39/46] powerpc/8xx: Add a function to early map kernel via huge pages To: kbuild test robot Cc: kbuild-all@lists.01.org, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <202003170938.Z0IuUore%lkp@intel.com> From: Christophe Leroy Message-ID: <22bc0bba-533f-548b-8eec-a3392acc8e3d@c-s.fr> Date: Tue, 17 Mar 2020 15:43:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <202003170938.Z0IuUore%lkp@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 17/03/2020 à 02:39, kbuild test robot a écrit : > Hi Christophe, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on next-20200316] > [cannot apply to powerpc/next v5.6-rc6 v5.6-rc5 v5.6-rc4 v5.6-rc6] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Christophe-Leroy/Use-hugepages-to-map-kernel-mem-on-8xx/20200317-065610 > base: 8548fd2f20ed19b0e8c0585b71fdfde1ae00ae3c > config: powerpc-tqm8xx_defconfig (attached as .config) > compiler: powerpc-linux-gcc (GCC) 9.2.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=9.2.0 make.cross ARCH=powerpc > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > > All errors (new ones prefixed by >>): > > In file included from arch/powerpc/mm/fault.c:33: > include/linux/hugetlb.h: In function 'hstate_inode': >>> include/linux/hugetlb.h:522:9: error: implicit declaration of function 'HUGETLBFS_SB'; did you mean 'HUGETLBFS_MAGIC'? [-Werror=implicit-function-declaration] > 522 | return HUGETLBFS_SB(i->i_sb)->hstate; > | ^~~~~~~~~~~~ > | HUGETLBFS_MAGIC >>> include/linux/hugetlb.h:522:30: error: invalid type argument of '->' (have 'int') > 522 | return HUGETLBFS_SB(i->i_sb)->hstate; > | ^~ > cc1: all warnings being treated as errors hstate_inode() shouldn't use HUGETLBFS_SB() which CONFIG_HUGETLBFS is not set. Proposed fix at https://patchwork.ozlabs.org/patch/1256108/ [...] >>> include/linux/hugetlb.h:522:30: error: invalid type argument of '->' (have 'int') > 522 | return HUGETLBFS_SB(i->i_sb)->hstate; > | ^~ > At top level: > arch/powerpc//mm/nohash/8xx.c:73:18: error: '__early_map_kernel_hugepage' defined but not used [-Werror=unused-function] > 73 | static int __ref __early_map_kernel_hugepage(unsigned long va, phys_addr_t pa, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors This patch is a preparation patch. The function is not used yet, that's normal. Ok, it breaks bisectability. Should it be squashed with the first user of the function ? Christophe