From: Paolo Bonzini <pbonzini@redhat.com>
To: Jarkko Sakkinen <jarkko@kernel.org>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: dave.hansen@linux.intel.com, seanjc@google.com, x86@kernel.org,
yang.zhong@intel.com
Subject: Re: [PATCH v2 2/2] x86: sgx_vepc: implement SGX_IOC_VEPC_REMOVE ioctl
Date: Tue, 12 Oct 2021 19:03:49 +0200 [thread overview]
Message-ID: <22c1c59f-9b7c-69fa-eff3-1670b94c77af@redhat.com> (raw)
In-Reply-To: <644db39e4c995e1966b6dbc42af16684e8420785.camel@kernel.org>
On 12/10/21 18:57, Jarkko Sakkinen wrote:
>> +
>> static const struct file_operations sgx_vepc_fops = {
>> .owner = THIS_MODULE,
>> .open = sgx_vepc_open,
>> + .unlocked_ioctl = sgx_vepc_ioctl,
>> + .compat_ioctl = sgx_vepc_ioctl,
>> .release = sgx_vepc_release,
>> .mmap = sgx_vepc_mmap,
>> };
> I went through this a few times, the code change is sound and
> reasoning makes sense in the commit message.
>
> The only thing that I think that is IMHO lacking is a simple
> kselftest. I think a trivial test for SGX_IOC_VEP_REMOVE_ALL
> would do.
Yeah, a trivial test wouldn't cover a lot; it would be much better to at
least set up a SECS, and check that the first call returns 1 and the
second returns 0. There is no existing test for /dev/sgx_vepc at all.
Right now I'm relying on Yang for testing this in QEMU, but I'll look
into adding a selftest that does the full setup and runs an enclave in a
guest.
Paolo
next prev parent reply other threads:[~2021-10-12 17:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 10:57 [PATCH v2 0/2] x86: sgx_vepc: implement ioctl to EREMOVE all pages Paolo Bonzini
2021-10-12 10:57 ` [PATCH v2 1/2] x86: sgx_vepc: extract sgx_vepc_remove_page Paolo Bonzini
2021-10-12 16:53 ` Jarkko Sakkinen
2021-10-13 12:56 ` [tip: x86/sgx] x86/sgx/virt: Extract sgx_vepc_remove_page() tip-bot2 for Paolo Bonzini
2021-10-14 22:10 ` [PATCH v2 1/2] x86: sgx_vepc: extract sgx_vepc_remove_page Dave Hansen
2021-10-12 10:57 ` [PATCH v2 2/2] x86: sgx_vepc: implement SGX_IOC_VEPC_REMOVE ioctl Paolo Bonzini
2021-10-12 16:57 ` Jarkko Sakkinen
2021-10-12 17:03 ` Paolo Bonzini [this message]
2021-10-12 17:43 ` Jarkko Sakkinen
2021-10-13 12:56 ` [tip: x86/sgx] x86/sgx/virt: Implement " tip-bot2 for Paolo Bonzini
2021-10-14 22:14 ` [PATCH v2 2/2] x86: sgx_vepc: implement " Dave Hansen
2021-10-15 22:29 ` Sean Christopherson
2021-10-16 7:14 ` Paolo Bonzini
2021-10-13 6:54 ` [PATCH v2 0/2] x86: sgx_vepc: implement ioctl to EREMOVE all pages Borislav Petkov
2021-10-13 7:15 ` Paolo Bonzini
2021-10-13 7:38 ` Borislav Petkov
2021-10-14 12:21 ` Yang Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22c1c59f-9b7c-69fa-eff3-1670b94c77af@redhat.com \
--to=pbonzini@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=x86@kernel.org \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®