From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BA9C36F411 for ; Mon, 3 Aug 2026 13:42:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785764575; cv=none; b=qoI+e4w50dRu+3Zwz8h8WG5fAPAdi6wezISKH/E71T26ZbBU3vo2z01VnQf+ZbBPDQHZNkWwSs5zWONd3rWUGwscQx/Q7wjYrjOYNYRNWcIZuveIStodM3EiOTBZA8przbewuL42/iv69FCKITyMtHPWD48iH4yv0fWpeg+VUZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785764575; c=relaxed/simple; bh=7hgNn5i2CXZAeHNCzJI18FtpzkKrFl/iGqxowaJ9TbU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hrx5rcMQmxy046IO50fkYeiGnEvJF+S6LQqEVWwyJOqsdQSq9BEFAVecf3eBI46d0SuroeryD0+0D7YnyPtitFYDPBL9Jd/0/asGE0qBzQColXf6J+frNifBHQBI0M5h/r/emCzJ3BZXpwa0EHbew/umvKmioubhBo8KgBKmtiw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MoHZa2Xh; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=IIunVgT/; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MoHZa2Xh"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="IIunVgT/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785764573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q9mewyqdJBERhE/mcQ+h6iaGDeJtrxCLQvnbpvnUU7Q=; b=MoHZa2XhIJOrmkxA5sRBLSVEOGtJkc/ZGmDg3kV+inBeYMO7mk7yvxdb6PaW/3caQ0aZm1 LeFji0QdY0JzmNlwrLl9PJbulr1XXw4BpCXTWS61ukxiYKY0zQfWnKQM45iW6XT0w79OqI NfA/flWR/J4WFyi5h7SCSl8fjH65m/8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-IVWYmgE8P_OY69HYajPgIg-1; Mon, 03 Aug 2026 09:42:52 -0400 X-MC-Unique: IVWYmgE8P_OY69HYajPgIg-1 X-Mimecast-MFC-AGG-ID: IVWYmgE8P_OY69HYajPgIg_1785764571 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4955d314945so11554305e9.0 for ; Mon, 03 Aug 2026 06:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785764571; x=1786369371; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=q9mewyqdJBERhE/mcQ+h6iaGDeJtrxCLQvnbpvnUU7Q=; b=IIunVgT/LscN1LAkrQibAx0+HTxRxXw/4ZYjgp/9H9uQ8XkXSJXqd2JZm0GcugHx6S nSCAwthYOA49OMX1p/J4G/S1w1wa0qasg/5NYXzi4wDk+nHCiIhMUBCvQvI4YhWLVZH/ f/Cysqi2KnxVy8qR3og7gvPOBXvrVt6O7hsKdNMnC3seEx6WeDTyhl/2P1pcB5aPmdXB eOBajbrx/RMuNnx+XkvpByAw9JU9PkjOr5DiHmV+xkblD5iJUDgqPyMT4QLzvtaWduT1 0NKFi5u5jij2DDarElt+DCzgO6e//xgQnMJAiPb2Y6/N0ClhrcpAFWXg0oNgxSAX82Ev lEgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785764571; x=1786369371; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=q9mewyqdJBERhE/mcQ+h6iaGDeJtrxCLQvnbpvnUU7Q=; b=jJXKmTQaYTssJoMKMutDG7oLsYACuSXTRxvTANCsxoTB2uXdW/kFvBCHMYgLk8oQAV 2fvz9PqNWmRlxxiIFLHMF775QaBjnQM1rL0lsPyjfcb+Azbq8eqK5zGcQxYrgf2TiHoK OzpgHSy88zyi0HQS8n/N/2SEn30W0I0o2nTEReWQf36QnYCJ7jp2OIJy0bQZqkqbQxq8 aOvqMaDWbKnPVN5Zpn8W5AOspZv6+xXljeHatuEEe7O5qQJgUMBNx1vNnQhiNVB14Ovi 6IAb0iaeLvdC57W17RPczYr0NtFQl5BU163CDPxkBIj4tKVuOV/QQQkmmea/wYlaTI1H ++GA== X-Forwarded-Encrypted: i=1; AHgh+RodKkIjQ+OpXbXiz1Ghri5U1C0hLYnKfTra3fgcXlOjboC6bkPvxb2nhUkR2ulpwExaLQfN8YLO7rT8cys=@vger.kernel.org X-Gm-Message-State: AOJu0YxeiePjFk75YKCpBv1KmwwrUv3lL3hIlojc8b8AmELN62SvmidO 453gs4ASEmpDzwibTfMjtmRQiKqwVqvKG/bPgkdRSyeOqgXoD8MVOqTOuqRXu41Y+Ayd02ECHXY pCy0V8x6epr8u2/8nGkIwaR2r86v5PmF1ZY8z/GB/6kliRtkreiXg1viawfWSJ6ZRqA== X-Gm-Gg: AR+sD10OLJIHDFwfnOi2ptO1iQRdLnmLiPimAWj/yWaAKvshONsy2eZVU6/DjBTbfEo 6Y/2SI4nYZ7k/VCbpnQoiO9ma5Awmi+i1knhQpTdF5U2TYoIslaLGlBRX3MRJbAzvoQJ+ynsCiy qLEg3bY9cFQk1sDNQcX3+rrWIGSmRuLBpWDiMceowZaSe6e5ComwbgUaPCl1z6sql0LDL0NRPZh dFKIpzLJhV8+wgfkwV635GIHYqU57PUMYGJqwvLz8zsLgQJgmV3Oxy9dqYwCkbGyxD4cAE9senm IadsIRxcD+/Qiw9yRdix8/uxg41lCEXcNZTn3l003HBbtsBGnW17ijk84V/HB0624hWFMuJN+4Z idZnLXKhMG4bUh4Ko9SY1mEB05k9mk4hni7d5/aq6yovqzsPORifHWLLMxIlLr9LHJcNRl+Eycu M= X-Received: by 2002:a05:600c:4fc5:b0:494:6baa:ccef with SMTP id 5b1f17b1804b1-4980f23257cmr218813045e9.11.1785764570720; Mon, 03 Aug 2026 06:42:50 -0700 (PDT) X-Received: by 2002:a05:600c:4fc5:b0:494:6baa:ccef with SMTP id 5b1f17b1804b1-4980f23257cmr218812405e9.11.1785764570346; Mon, 03 Aug 2026 06:42:50 -0700 (PDT) Received: from [192.168.188.217] (ip239-44-231-195.pool-bba.aruba.it. [195.231.44.239]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd458b73asm31017655f8f.29.2026.08.03.06.42.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 06:42:49 -0700 (PDT) Message-ID: <22c1fffc-68c5-44c4-a686-6642e4af4234@redhat.com> Date: Mon, 3 Aug 2026 15:42:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 5/5] mptcp: implemented OoO queue pruning To: "Matthieu Baerts (NGI0)" , Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, Gang Yan References: <20260731-net-next-mptcp-oooq-pruning-v2-0-24838164fa21@kernel.org> <20260731-net-next-mptcp-oooq-pruning-v2-5-24838164fa21@kernel.org> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260731-net-next-mptcp-oooq-pruning-v2-5-24838164fa21@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/31/26 4:24 PM, Matthieu Baerts (NGI0) wrote: > +/* "Inspired" from the TCP version; main difference: stop as soon as the MPTCP > + * socket is under memory limit. > + */ > +static bool mptcp_prune_ofo_queue(struct sock *sk, u64 seq) > +{ > + struct mptcp_sock *msk = mptcp_sk(sk); > + struct rb_node *node, *prev; > + bool pruned = false; > + u64 mem; > + > + if (RB_EMPTY_ROOT(&msk->out_of_order_queue)) > + goto out; > + > + node = &msk->ooo_last_skb->rbnode; > + > + do { > + struct sk_buff *skb = rb_to_skb(node); > + > + /* Stop pruning if the incoming skb would land in OoO tail. */ > + if (after64(seq, MPTCP_SKB_CB(skb)->map_seq)) > + break; Clashiko noted that duplicate/old skbs can reach here, leading to serious damage. It needs to be fixed. It looks like opus-5 catches a lot of things that previous models (and humans) were not able to see. It should be a :-) but it feels more like :( /P