From: Markus Elfring <Markus.Elfring@web.de>
To: "Luke Jones" <luke@ljones.dev>,
platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org,
"Benjamin Tissoires" <bentiss@kernel.org>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Jiri Kosina" <jikos@kernel.org>,
"Mario Limonciello" <superm1@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [v4 3/9] platform/x86: asus-armoury: move existing tunings to asus-armoury module
Date: Fri, 27 Sep 2024 08:09:41 +0200 [thread overview]
Message-ID: <22c231f2-c28e-4083-8e62-590a8c2d8844@web.de> (raw)
In-Reply-To: <f3b059cd-0045-435e-9bb9-467bb9cb0cc1@app.fastmail.com>
>> …
>>> +++ b/drivers/platform/x86/asus-armoury.h
>>> @@ -0,0 +1,146 @@
>> …
>>> +#ifndef _ASUS_BIOSCFG_H_
>>> +#define _ASUS_BIOSCFG_H_
>> …
>>
>> I suggest to omit leading underscores from such identifiers.
>> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
…
> the link is C standard, not kernel C right?
Advice is offered in such a direction.
> Pretty much everything I look at in the kernel seems to use the leading underscores.
How much would you like to care for standard compliance concerns
together with your software developments?
Regards,
Markus
next prev parent reply other threads:[~2024-09-27 6:10 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 9:29 [PATCH v4 0/9] platform/x86: introduce asus-armoury driver Luke D. Jones
2024-09-26 9:29 ` [PATCH v4 1/9] platform/x86: asus-wmi: export symbols used for read/write WMI Luke D. Jones
2024-09-26 15:26 ` Mario Limonciello
2024-09-26 9:29 ` [PATCH v4 2/9] hid-asus: Add MODULE_IMPORT_NS(ASUS_WMI) Luke D. Jones
2024-09-26 11:54 ` Jiri Kosina
2024-09-26 9:29 ` [PATCH v4 3/9] platform/x86: asus-armoury: move existing tunings to asus-armoury module Luke D. Jones
2024-09-26 15:48 ` Mario Limonciello
2024-09-26 23:20 ` Luke Jones
2024-09-27 14:45 ` Mario Limonciello
2024-09-28 9:52 ` Luke Jones
2024-09-26 19:10 ` Markus Elfring
2024-09-26 21:50 ` Luke Jones
2024-09-27 6:09 ` Markus Elfring [this message]
2024-09-27 7:05 ` [v4 " Luke Jones
2024-09-27 7:24 ` Markus Elfring
2024-09-27 7:43 ` Luke Jones
2024-09-27 7:48 ` Julia Lawall
2024-09-26 9:29 ` [PATCH v4 4/9] platform/x86: asus-armoury: add panel_hd_mode attribute Luke D. Jones
2024-09-26 15:17 ` Mario Limonciello
2024-09-26 22:12 ` Luke Jones
2024-09-26 9:29 ` [PATCH v4 5/9] platform/x86: asus-armoury: add the ppt_* and nv_* tuning knobs Luke D. Jones
2024-09-26 15:22 ` Mario Limonciello
2024-09-26 22:39 ` Luke Jones
2024-09-26 9:29 ` [PATCH v4 6/9] platform/x86: asus-armoury: add dgpu tgp control Luke D. Jones
2024-09-26 9:29 ` [PATCH v4 7/9] platform/x86: asus-armoury: add apu-mem control support Luke D. Jones
2024-09-26 15:25 ` Mario Limonciello
2024-09-26 22:14 ` Luke Jones
2024-09-26 9:29 ` [PATCH v4 8/9] platform/x86: asus-armoury: add core count control Luke D. Jones
2024-09-26 15:30 ` Mario Limonciello
2024-09-26 21:47 ` Luke Jones
2024-09-26 22:02 ` Mario Limonciello
2024-09-29 7:00 ` Luke Jones
2024-09-26 9:29 ` [PATCH v4 9/9] platform/x86: asus-wmi: deprecate bios features Luke D. Jones
2024-09-26 14:56 ` Mario Limonciello
2024-09-26 22:04 ` Luke Jones
2024-09-28 0:13 ` kernel test robot
2024-09-28 21:02 ` Luke Jones
2024-09-26 14:50 ` [PATCH v4 0/9] platform/x86: introduce asus-armoury driver Mario Limonciello
2024-09-26 21:44 ` Luke Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22c231f2-c28e-4083-8e62-590a8c2d8844@web.de \
--to=markus.elfring@web.de \
--cc=bentiss@kernel.org \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jikos@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®