From: Jiri Slaby <jslaby@suse.cz>
To: tangbin <tangbin@cmss.chinamobile.com>, gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] tty:serial:mvebu-uart:fix a wrong return
Date: Tue, 3 Mar 2020 08:57:28 +0100 [thread overview]
Message-ID: <22c8d64b-5360-6495-8f83-75b52e86ca08@suse.cz> (raw)
In-Reply-To: <20200303071309.17172-1-tangbin@cmss.chinamobile.com>
On 03. 03. 20, 8:13, tangbin wrote:
> in this place,the right return should be
> return PTR_ERR(),not return -PTR_ERR()
One because missing. Like ", because PTR_ERR already returns a negative
error and the probe function is expected to return a negative value in
case of error."
Acked-by: Jiri Slaby <jslaby@suse.cz>
> Signed-off-by: tangbin <tangbin@cmss.chinamobile.com>
> ---
> drivers/tty/serial/mvebu-uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c
> index c12a12556..4e9a59071 100644
> --- a/drivers/tty/serial/mvebu-uart.c
> +++ b/drivers/tty/serial/mvebu-uart.c
> @@ -851,7 +851,7 @@ static int mvebu_uart_probe(struct platform_device *pdev)
>
> port->membase = devm_ioremap_resource(&pdev->dev, reg);
> if (IS_ERR(port->membase))
> - return -PTR_ERR(port->membase);
> + return PTR_ERR(port->membase);
>
> mvuart = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_uart),
> GFP_KERNEL);
>
--
js
suse labs
next prev parent reply other threads:[~2020-03-03 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 7:13 tangbin
2020-03-03 7:57 ` Jiri Slaby [this message]
[not found] ` <202003041737399757401@cmss.chinamobile.com>
2020-03-04 10:07 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22c8d64b-5360-6495-8f83-75b52e86ca08@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®