From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755130AbcKYPzl (ORCPT ); Fri, 25 Nov 2016 10:55:41 -0500 Received: from mail.kernel.org ([198.145.29.136]:47872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502AbcKYPzc (ORCPT ); Fri, 25 Nov 2016 10:55:32 -0500 Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: allow dio read for LFS mode To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20161111210304.4736-1-jaegeuk@kernel.org> <20161111210304.4736-2-jaegeuk@kernel.org> From: Chao Yu Message-ID: <22d105b6-3393-eee0-f377-af1ab00141f2@kernel.org> Date: Fri, 25 Nov 2016 23:54:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161111210304.4736-2-jaegeuk@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/11/12 5:03, Jaegeuk Kim wrote: > We can allow dio reads for LFS mode, while doing buffered writes for dio writes. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index ca53da5..996b9ae 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -1732,7 +1732,7 @@ static ssize_t f2fs_direct_IO(struct kiocb *iocb, struct iov_iter *iter) > > if (f2fs_encrypted_inode(inode) && S_ISREG(inode->i_mode)) > return 0; > - if (test_opt(F2FS_I_SB(inode), LFS)) > + if (rw == WRITE && test_opt(F2FS_I_SB(inode), LFS)) For LFS mode, we must disallow any IPU in main area including direct write, instead of both direct read and write, so this patch relieves the restriction? IIUC, please add: Reviewed-by: Chao Yu Thanks, > return 0; > > trace_f2fs_direct_IO_enter(inode, offset, count, rw); >