From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=103.168.172.156 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792637212; b=VhTOFbt2Ga/15AGIpGUs3hDC78J0EaTWUetN8ci8faKs2uAtETevRjCoRiWrhzNQzN7d g3ZyQff6+KBLPxUcDj5NDvEJ2K060ty+rox3XP5nXVRlmiOiXqS7F0+7WXfGD4fBrMYis IiFpqrZ+wCwFY+C9KcFEl5cTbz6x/RPwpscNBJSl8m4AlBUoQ++DNSy/rEDn5xTq/1f1q xc393wA+eu3kpHyq09L2QLwbpK8/YGxJJZm/c6MCAW+qF/pEFeNER1TtdXEuBfy0XIpb6 scLXBGzzR5pqpp/LlKQOSOtSXl25aNoDfZG5BngaT2U1xvc7Cq7MI8wwUAsU1JLGomw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792637212; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Received:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID: Received:Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:Content-Transfer-Encoding:User-Agent:MIME-Version; bh=b8JrLeZmohBXZxoZ8hIHhxCw9MvjJJNFtjwd/KPNiN4=; b=QXHb5cw2lpdH9jE2u/3ZXiezA2bBo+lD+6nnLJJDBDiL5+RZw1vWu0fR3H1cbrNy07bH uk1AB4DMVtTU4lUOES0WYUCjW0MhX6sgwMhVikJUimBh4NhwPNNPVtgw4aKisLXg2POdr 4mU9ChqNgnIchDPhRciOJPW3dBeRVhtsZwH3LIWbiD5aV6ADziOsS9rybMfpkdb9jm3CE JmjWhbqDwbmQTCz+eEiIdu2BnVzGOANDDIjWIeBOhYnyg05NmOWByT9RrElLSAgeNUnbQ q9N9kSy4tbdV5ReEtacA2GqtllnX2lMxd2JHHqJuw6lJ8xC2EugW0WBdq5YDf+LlvZg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=themaw.net; spf=pass smtp.mailfrom=themaw.net; dkim=temperror header.d=themaw.net header.i=@themaw.net header.a=rsa-sha256 header.s=fm1 header.b=SlzWuXRT; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=vcwJoROo; arc=none smtp.remote-ip=103.168.172.156 Received: from fhigh-a5-smtp.messagingengine.com (fhigh-a5-smtp.messagingengine.com [103.168.172.156]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D87FD606A31B for ; Thu, 22 Oct 2026 02:46:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D87FD606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=themaw.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=themaw.net Authentication-Results: smtp.subspace.kernel.org; dkim=temperror header.d=themaw.net header.i=@themaw.net header.a=rsa-sha256 header.s=fm1 header.b=SlzWuXRT; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=vcwJoROo Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id D769A14001CD for ; Wed, 21 Oct 2026 22:46:40 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Wed, 21 Oct 2026 22:46:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=themaw.net; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1792637200; x=1792723600; bh=b8JrLeZmohBXZxoZ8hIHhxCw9MvjJJNFtjwd/KPNiN4=; b= SlzWuXRTtBF2qXe9jA6lVX3HJSnkinOlCatePQkTUUTQmyOpN6ZrpISLmgygl0Xe Cc81PlfuVQ5J6LAm5cZgQNj9+765p4wfd3ua4iqIaNYC9dhjs7ATJn27lFXZLC/l Vvy4qc6aoJKcQPUYoPgLJmhnZiYSx5Q/co/pEXf5/J/mFYrSk/D+T2A/K4ZyM8ev WuVpJdkFbpbZHHCI6imGoWGp4HBDlGgOHBTgsCBKACPSVO7go1iqlhs8JUfle+Bp 66ruuiDLVU3oBtj351ArawJOSrWG40DTygF2Qd1BXE16XRqWLWSiel2q8ZHfGrUF W+qIlmdg7QYnDBaCIO1Snw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1792637200; x= 1792723600; bh=b8JrLeZmohBXZxoZ8hIHhxCw9MvjJJNFtjwd/KPNiN4=; b=v cwJoROojIG7D8Yiyo6V0wr9zJ2pRVIh71PjrTRn4b+6YL5sSTwTY+7P7EB9lwh+/ DgH1RyTg6cKTNYtiCzaE0wI9A8W6AgLUJlSEbk/fTD7zU/ZhLFKcyrIUauUH1y2A QYZEiekK3gSDR90Ln0u6yMi+ZBrfsn7f0S9Tf2ywJHki9gbE14mIuX/gzivUAOdS Cma0bCSSOLlye+1WSmxdjF1tiiG4XwCFqwaspRg21z7djT/2sh/3+f4JTt5+M8Kk 7NLNa4Qd2Imv5mq7Hteo5kGIGgnEE3sT/Kfi1+q9zWSBPXL8j1/3mZNR194Dwsrj Gd2lcQjDOCSHGyYklAHJA== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-07; repo=github.com/dkim2wg/interop; date=2026-10-18; sw=lmtpprox; action=sign d=themaw.net a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1792637200; d=themaw.net; mf=PHJhdmVuQHRoZW1hdy5uZXQ+; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm1:rsa-sha256:eLmMq5d4g5iejq1Iyy1Wkxsq8uEsxL3iW7beqn4tfI1HYKF 1cQAD4w3xOonjL/wnNViKTIHV8AtvugqheTMy6zXT4pf4B5CcZZcdcpyfMxk+ZH7 H0uXMWRBiWcRmrMLMhZhO/oBB0JGnEq91vMuuTzMk84SrSsZWSIee0y6vdHgPc2k wFvYaQ/Gml2UW2N6b3goxOnta4mL3kCXUp1eZzUiQHXlzaebO5ESx5FwwGftzOHU bUNV/MVN+4XDMJiLC8QvYp2PTrF/X5sKPxKavaeyvdLBXiuK/25nIQ5W/BcssEWT Qx8uENJUb4VRjtWvTc5dbEljCfA7GTnlaEepRyw==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-07; repo=github.com/dkim2wg/interop; date=2026-10-18; sw=lmtpprox; action=mi-m=1; hc=13; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,in-reply-to,message-id,mime-version,references,subject,to, user-agent; Message-Instance: m=1; h=sha256:sdIH6ghOfrgTjW7puJZHRJZvIDPGFStH0tPZPwlN6IY=:b8JrLeZmohBXZxoZ8hIHhxCw9MvjJJNFtjwd/KPNiN4=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFJl80OlkxtKrmLpLry8SB+s8EoAdfs4E9kpHOA5dqijSHh+7H/6Ivwl3c5UQ6DPU 41bDxgYzHplpsNoe8kwgDj4e1PKdBedBJV72Q4qA5wkBs8ODrr/9rPxc2zUUd+tnYjIwoT ny8AmIaquX3FxGlVZ0wxUuvq9UzFvwMAZ6TafguFw1d36OZgJRVxv2eQRkdEHm1vVeHXFF enmny/KR7qloN3pF57Mt7BDSlLtYw5ioXv2HFdYDF3laRnOa69O9gEnqzvDWKnOWL+0mIp HHUGTUNCYNktwxR355RyWy/dARgku5E1Vam+5YCKNnxnJoQuSH4/+wb6ScnHEQ3FIY85MV AAKXP32OP+0nQTkUZkb3NJlSRBIDpgT3rTLeB7cgMiC4kZHDuhR4f2GzJiGfZSvkpaVFOP cdlLoxz0KKAOhQPEgAUXJIN8/Uf8MWooH7GFvNoWioufSIH7cfK76aZxRoHTb5pIC3fKB9 IrXPlTrMZ0z5RGiu/PDUyXn43KzDEn8Gye3Vf1cyrB0QyRIer9FCFe7jiOgcbOZGbFwpih OXLMN/2oBAih4161kXuTVBxcIypuUYKmasZEXorhy9h6zgyfGvDLpZ909if6Ry7f6MKQQx 9xmQ6YWBNfFkmT4h1lMILcX2FXpoU1mRB3zuEOk4y7LUlL26+NtemFD+R7/Q X-ME-Proxy: Feedback-ID: i31e841b0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Oct 2026 22:46:34 -0400 (EDT) Message-ID: <22d41f2a5546d3bc90a1b3ad24ed3656588a854f.camel@themaw.net> Subject: Re: [PATCH 0/2] kernfs, autofs: fix pipe lock cycles through sysfs stores From: Ian Kent To: Tejun Heo , Krystian Kaniewski Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Alexander Viro , Christian Brauner , Jan Kara , Ingo Molnar , Peter Zijlstra , Andrew Morton , Jens Axboe , driver-core@lists.linux.dev, autofs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, syzbot+002fb7b2d0bc53bf7e75@syzkaller.appspotmail.com Date: Thu, 22 Oct 2026 10:46:30 +0800 In-Reply-To: <649966b83b39fcdd25e892fc3c6732a1@kernel.org> References: <6aa23178.f81106d8.2ab401.0006.GAE@google.com> <649966b83b39fcdd25e892fc3c6732a1@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44app2) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 On Wed, 2026-10-21 at 11:48 -1000, Tejun Heo wrote: > Hello, Krystian. >=20 > On Wed, Oct 21, 2026 at 02:51:48PM +0200, Krystian Kaniewski wrote: > > syzbot reports a lockdep cycle &pipe->mutex --> &of->mutex --> > > &sbi->pipe_mutex. splice holds a pipe mutex while it calls the > > write or > > read handler of a kernfs file, kernfs takes of->mutex there, and a > > write > > to /sys/power/resume looks up a path that can make autofs write a > > request > > into its daemon pipe and wait for the daemon. >=20 > This is an extremely convoluted case that isn't going to happen in > any > realistic scenario, and it doesn't make sense to change the locking > scheme > for it. Can we just disallow splice on /sys/power/resume instead? I agree but it might not be as simple as disallowing that path. Not only is the description hard to follow the example is flawed because there should not be a mount callback on anything that's not an empty directory or an autofs trigger mount (and the above should be able to be either (systemd's /proc/sys/fs/binfmt_misc is an example of an autofs trigger mount). I mostly can't grok the reproducers for things like this so a complicated description makes it so much harder to come up with a sensible solution. The other possibility I was thinking about when I saw that report is to disallow file systems that don't make sense for automount. That would take some thought though and isn't entirely clear for kernfs since it's used by other file systems that may occasionally need to automount something at some point. OTOH, if the problem description could be cleaned up, and simplified, I wouldn't be entirely against the change but still wouldn't much like it. That's purely because I've always been in favor of defensing programming even for cases that are unlikely. Ian