From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DE8AC43334 for ; Wed, 20 Jul 2022 18:48:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230079AbiGTSsC (ORCPT ); Wed, 20 Jul 2022 14:48:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbiGTSsA (ORCPT ); Wed, 20 Jul 2022 14:48:00 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61E5073586; Wed, 20 Jul 2022 11:47:59 -0700 (PDT) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26KFliwG025488; Wed, 20 Jul 2022 18:47:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=ux7Y94ZPeXhn1lOHtaw4OLY6Po7ThFYplSIbLX/qGPg=; b=jlBQ9Odq20aZT3kHUSspnzIq8TwC07pbDG4oL4OoCRmNxpUw8uu7ZMyrvrJ3a0+tIX1m +s9ZoMXOx5enwnSBSv41cIdG4b4enxiic3KfcPWierMl066GVmPSZgtbscmCmSS7WRl4 S5OSqC1E4hjvrjFHfudQbwO81ivFn5SjbrRnJZsItqFej4wgrNh7WeOMhGb1u/Aw3JSV cRZDq+IRX3qUu1Y04nJyBcUwZgrX/xlNx8OGMQ4fHSjuYsh1XKe5iOy0rERStuM3cByC 4klw04ujq9TV4k04MQeJ/9js8kTuH+j4te6NvpVgm3UM7+EPrw3A/ZJ7oukVcsdjYi4R ig== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3he3uaarx0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Jul 2022 18:47:50 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.47.97.222]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 26KIln9w027568 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Jul 2022 18:47:49 GMT Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 20 Jul 2022 11:47:49 -0700 Received: from [10.38.240.17] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 20 Jul 2022 11:47:45 -0700 Message-ID: <22d4abbf-db93-82e1-ecf1-e7804e72c21b@quicinc.com> Date: Wed, 20 Jul 2022 11:47:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v4] drm/msm/dp: make eDP panel as the first connected connector Content-Language: en-US To: Kuogee Hsieh , , , , , , , , , , CC: , , , , , References: <1657135928-31195-1-git-send-email-quic_khsieh@quicinc.com> From: Abhinav Kumar In-Reply-To: <1657135928-31195-1-git-send-email-quic_khsieh@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Kowq4DW3Yb7m9JSTvP9X2Za-JRTmLQT4 X-Proofpoint-ORIG-GUID: Kowq4DW3Yb7m9JSTvP9X2Za-JRTmLQT4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-20_12,2022-07-20_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 mlxscore=0 bulkscore=0 malwarescore=0 spamscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 clxscore=1011 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207200076 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/6/2022 12:32 PM, Kuogee Hsieh wrote: > Some userspace presumes that the first connected connector is the main > display, where it's supposed to display e.g. the login screen. For > laptops, this should be the main panel. > > This patch call drm_helper_move_panel_connectors_to_head() after > drm_bridge_connector_init() to make sure eDP stay at head of > connected connector list. This fixes unexpected corruption happen > at eDP panel if eDP is not placed at head of connected connector > list. > > Changes in v2: > -- move drm_helper_move_panel_connectors_to_head() to > dpu_kms_drm_obj_init() > > Changes in v4: > -- move drm_helper_move_panel_connectors_to_head() to msm_drm_init() > > Signed-off-by: Kuogee Hsieh Fixes: c8afe684c95c ("drm/msm: basic KMS driver for snapdragon") > --- > drivers/gpu/drm/msm/msm_drv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index 4a3dda2..4d518c2 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -419,6 +419,8 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv) > } > } > > + drm_helper_move_panel_connectors_to_head(ddev); > + > ddev->mode_config.funcs = &mode_config_funcs; > ddev->mode_config.helper_private = &mode_config_helper_funcs; >