From: Krzysztof Kozlowski <krzk@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Josef Bacik <josef@toxicpanda.com>,
linux-kernel@vger.kernel.org, stable <stable@kernel.org>
Subject: Re: [PATCH 2/9] w1: remove the master's files before taking its locks
Date: Fri, 30 Oct 2026 13:56:46 +0100 [thread overview]
Message-ID: <22d6d605-cb50-4c73-97b9-8b1602f59fc1@kernel.org> (raw)
In-Reply-To: <20261027-llm-char-misc-w1-v1-2-d2e6bfafb6a4@linuxfoundation.org>
On 27/10/2026 17:04, Greg Kroah-Hartman wrote:
> From: Josef Bacik <josef@toxicpanda.com>
>
> __w1_remove_master_device() calls w1_destroy_master_attributes() with
> both the mutex of the master and list_mutex held. Removing the files
> waits for the callbacks which are running, and nearly all of them take
> one of these two locks:
>
> __w1_remove_master_device() read() of .../w1_master_slaves
> mutex_lock(&dev->mutex) kernfs active reference
> mutex_lock(&dev->list_mutex) w1_master_attribute_show_slaves()
> w1_destroy_master_attributes() mutex_lock(&md->list_mutex)
> sysfs_remove_group() waits
> waits for the reference
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-30 12:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 16:04 [PATCH 0/9] w1: a bunch of llm-found fixes Greg Kroah-Hartman
2026-10-27 16:04 ` [PATCH 1/9] w1: use the bus mutex for the "rw" file Greg Kroah-Hartman
2026-10-30 12:23 ` Krzysztof Kozlowski
2026-10-27 16:04 ` [PATCH 2/9] w1: remove the master's files before taking its locks Greg Kroah-Hartman
2026-10-30 12:56 ` Krzysztof Kozlowski [this message]
2026-10-27 16:04 ` [PATCH 3/9] w1: ds2482: set the strong pull-up with its byte Greg Kroah-Hartman
2026-10-30 13:09 ` Krzysztof Kozlowski
2026-10-27 16:04 ` [PATCH 4/9] w1: ds28e04: use the bus mutex to talk on the bus Greg Kroah-Hartman
2026-10-30 13:10 ` Krzysztof Kozlowski
2026-10-27 16:04 ` [PATCH 5/9] w1: ds2805: " Greg Kroah-Hartman
2026-10-30 13:11 ` Krzysztof Kozlowski
2026-10-30 13:17 ` Krzysztof Kozlowski
2026-10-27 16:04 ` [PATCH 6/9] w1: netlink: drop the slave after the bus is unlocked Greg Kroah-Hartman
2026-10-30 13:41 ` Krzysztof Kozlowski
2026-10-27 16:04 ` [PATCH 7/9] w1: don't hold list_mutex while a slave is torn down Greg Kroah-Hartman
2026-10-30 13:42 ` Krzysztof Kozlowski
2026-10-27 16:04 ` [PATCH 8/9] w1: w1_therm: lock the list of slaves for the bulk read Greg Kroah-Hartman
2026-10-30 13:44 ` Krzysztof Kozlowski
2026-10-27 16:04 ` [PATCH 9/9] w1: w1_therm: leave the slaves of other families alone Greg Kroah-Hartman
2026-10-30 13:45 ` Krzysztof Kozlowski
2026-10-30 8:14 ` [PATCH 0/9] w1: a bunch of llm-found fixes Krzysztof Kozlowski
2026-10-30 8:22 ` Greg Kroah-Hartman
2026-10-30 8:43 ` Krzysztof Kozlowski
2026-10-30 13:45 ` Krzysztof Kozlowski
2026-10-30 13:49 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22d6d605-cb50-4c73-97b9-8b1602f59fc1@kernel.org \
--to=krzk@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=josef@toxicpanda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®