From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: lm70: simplify with spi_get_device_match_data()
Date: Fri, 7 Jun 2024 08:53:45 +0200 [thread overview]
Message-ID: <22de160e-d925-4295-8208-f03a44f026bc@linaro.org> (raw)
In-Reply-To: <32a542a9-e338-4f8a-af24-a32c8426e619@roeck-us.net>
On 06/06/2024 17:56, Guenter Roeck wrote:
> On 6/6/24 07:25, Krzysztof Kozlowski wrote:
>> Use spi_get_device_match_data() helper to simplify a bit the driver.
>> Also kernel_ulong_t type is preferred for kernel code over uintptr_t
>> (needed for the cast).
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> drivers/hwmon/lm70.c | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c
>> index 481e4e1f8f4f..0d5a250cb672 100644
>> --- a/drivers/hwmon/lm70.c
>> +++ b/drivers/hwmon/lm70.c
>> @@ -169,11 +169,7 @@ static int lm70_probe(struct spi_device *spi)
>> struct lm70 *p_lm70;
>> int chip;
>>
>> - if (dev_fwnode(&spi->dev))
>> - chip = (int)(uintptr_t)device_get_match_data(&spi->dev);
>> - else
>> - chip = spi_get_device_id(spi)->driver_data;
>> -
>> + chip = (kernel_ulong_t)spi_get_device_match_data(spi);
>>
>> /* signaling is SPI_MODE_0 */
>> if ((spi->mode & SPI_MODE_X_MASK) != SPI_MODE_0)
>
> I'll apply this patch, but ...
>
> I take it that the earlier claims that driver_data must not be
> something like "(void *) LM70_CHIP_LM70", where LM70_CHIP_LM70 is 0,
> was wrong. I'll start reverting all patches which changed starting
> enum values from 0 to 1 based on that wrong claim.
Yeah, they should not be 0. I think Jonathan also brought it some time
ago for iio drivers:
https://lore.kernel.org/linux-iio/20240226192555.14aa178e@jic23-huawei/
but if all the ID tables are complete, the 0 will work fine:
https://lore.kernel.org/all/20240413154511.52576-1-krzysztof.kozlowski@linaro.org/
Best regards,
Krzysztof
prev parent reply other threads:[~2024-06-07 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 14:25 Krzysztof Kozlowski
2024-06-06 15:56 ` Guenter Roeck
2024-06-07 6:53 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22de160e-d925-4295-8208-f03a44f026bc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®