From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934651AbcIOMJX (ORCPT ); Thu, 15 Sep 2016 08:09:23 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:55139 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933908AbcIOMJT (ORCPT ); Thu, 15 Sep 2016 08:09:19 -0400 Subject: Re: [PATCH 14/26] drm/omap: dispc: Simplify _dispc_mgr_set_lcd_timings() parameters To: Peter Ujfalusi , , References: <20160901112320.15246-1-peter.ujfalusi@ti.com> <20160901112320.15246-15-peter.ujfalusi@ti.com> CC: , , From: Tomi Valkeinen Message-ID: <22dea2e6-a5bb-ac3b-c229-0472c4670d53@ti.com> Date: Thu, 15 Sep 2016 15:09:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160901112320.15246-15-peter.ujfalusi@ti.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Jegvsu3soGPqf0a3xouOqjJSsWulTH8Ku" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Jegvsu3soGPqf0a3xouOqjJSsWulTH8Ku Content-Type: multipart/mixed; boundary="Kx1hHhIg6krXgeWU8E8ocRLsomJqkMIaG"; protected-headers="v1" From: Tomi Valkeinen To: Peter Ujfalusi , thierry.reding@gmail.com, airlied@linux.ie Cc: daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-ID: <22dea2e6-a5bb-ac3b-c229-0472c4670d53@ti.com> Subject: Re: [PATCH 14/26] drm/omap: dispc: Simplify _dispc_mgr_set_lcd_timings() parameters References: <20160901112320.15246-1-peter.ujfalusi@ti.com> <20160901112320.15246-15-peter.ujfalusi@ti.com> In-Reply-To: <20160901112320.15246-15-peter.ujfalusi@ti.com> --Kx1hHhIg6krXgeWU8E8ocRLsomJqkMIaG Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/09/16 14:23, Peter Ujfalusi wrote: > Instead of passing the omap_video_timings structure's members individua= lly, > use the pointer to the struct. >=20 > Signed-off-by: Peter Ujfalusi > --- > drivers/gpu/drm/omapdrm/dss/dispc.c | 38 ++++++++++++++---------------= -------- > 1 file changed, 14 insertions(+), 24 deletions(-) >=20 > diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omap= drm/dss/dispc.c > index 858d87dd7fe8..915609be7a33 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dispc.c > +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c > @@ -3141,29 +3141,23 @@ bool dispc_mgr_timings_ok(enum omap_channel cha= nnel, > return true; > } > =20 > -static void _dispc_mgr_set_lcd_timings(enum omap_channel channel, int = hsync_len, > - int hfp, int hbp, int vsw, int vfp, int vbp, > - enum omap_dss_signal_level vsync_level, > - enum omap_dss_signal_level hsync_level, > - enum omap_dss_signal_edge data_pclk_edge, > - enum omap_dss_signal_level de_level, > - enum omap_dss_signal_edge sync_pclk_edge) > - > +static void _dispc_mgr_set_lcd_timings(enum omap_channel channel, > + struct omap_video_timings *ovt) const pointer? Tomi --Kx1hHhIg6krXgeWU8E8ocRLsomJqkMIaG-- --Jegvsu3soGPqf0a3xouOqjJSsWulTH8Ku Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX2o9nAAoJEPo9qoy8lh71DN4QAJvD2I1+51dob47ozWlpQqLZ YwmpLap2hxPY3ZYE96b7dZpnORTvNGapig5KMPaXVtDen4w4u4xRb+CTMXUu4q+h TjZbBrWclk5I75xdRfja03bvfREGc4DPfITDJcZtP/lBIhUSBTQksRK33cfmBD39 oUE/o4wq4+xQraKbL5NffSNvL93c/fbXlIS49U3Pzw5kkfplHhBqfgmaRPEOlSWe E3aZTiMYqk26vs057wqn+izh0rsnhv+Tly35liCtnacpJR606sNC1fJmw8XOZGGR kKKZVLap0quYWEXLyFhqQmX4KBeC4eWFSRUmqdxH8rLvOVKow/5vbZuvxGQ3LIoI 9RY+l8fgEKvtZ2GXqLq+dJ0r3VEF3GCScMkwVkIzKSn+Y27J/bIAEzPQyaemQoex 9rdoWppIjgTi2VsIvc+oM2h+ugkXvODlhtqcmep8C5xJSeO2b3zVZ7+V0FDRE+Py l5PV6j60WerjPjQZtPLKSZ32D2ymWf54/IfFKgj5kvAzBzf6I7VCwBStE4+Zbhj8 l91oPW/Ya62+nvie9oNvI0KUJ/gBDLGcXQ1gPl6yL2flBcpd26Ug/slM95pjYULt Om1mQXPJZrfpQc9LO+Gw3X0+MIHJAoIC8ZQwkbrGZMMUxSQXGigmmP6VNWQFH9mw bdLlYG9BtlsiSD7U/B+P =zF2a -----END PGP SIGNATURE----- --Jegvsu3soGPqf0a3xouOqjJSsWulTH8Ku--