From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"daniel.vetter@intel.com" <daniel.vetter@intel.com>,
"jgross@suse.com" <jgross@suse.com>,
"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
"noralf@tronnes.org" <noralf@tronnes.org>,
"hch@infradead.org" <hch@infradead.org>
Subject: Re: [PATCH v2] drm/xen-front: Make shmem backed display buffer coherent
Date: Wed, 16 Jan 2019 06:37:26 +0000 [thread overview]
Message-ID: <22e0945b-9339-bb71-0eea-0a72cfc1e47f@epam.com> (raw)
In-Reply-To: <20190116063002.jq3aas6ofhaogmyk@sirius.home.kraxel.org>
On 1/16/19 8:30 AM, Gerd Hoffmann wrote:
> Hi,
>
>> + if (!dma_map_sg(dev->dev, xen_obj->sgt->sgl, xen_obj->sgt->nents,
>> + DMA_BIDIRECTIONAL)) {
>> + ret = -EFAULT;
>> + goto fail_free_sgt;
>> + }
> Hmm, so it seems the arm guys could not come up with a suggestion how to
> solve that one in a better way. Ok, lets go with this then.
>
> But didn't we agree that this deserves a comment exmplaining the purpose
> of the dma_map_sg() call is to flush caches and that there is no actual
> DMA happening here?
My bad, will add the comment
> cheers,
> Gerd
>
Thank you,
Oleksandr
prev parent reply other threads:[~2019-01-16 6:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 14:04 Oleksandr Andrushchenko
2019-01-16 6:30 ` Gerd Hoffmann
2019-01-16 6:36 ` Christoph Hellwig
2019-01-16 6:43 ` Oleksandr Andrushchenko
2019-01-17 9:18 ` Christoph Hellwig
2019-01-18 9:40 ` Oleksandr Andrushchenko
2019-01-18 11:43 ` [Xen-devel] " Julien Grall
2019-01-21 12:43 ` Oleksandr Andrushchenko
2019-01-21 17:09 ` Julien Grall
2019-01-22 10:28 ` Oleksandr Andrushchenko
2019-01-22 11:44 ` Julien Grall
2019-01-24 14:34 ` Oleksandr Andrushchenko
2019-01-24 15:02 ` Julien Grall
2019-01-29 14:46 ` Oleksandr Andrushchenko
2019-01-30 8:39 ` Oleksandr Andrushchenko
2019-01-16 6:37 ` Oleksandr Andrushchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22e0945b-9339-bb71-0eea-0a72cfc1e47f@epam.com \
--to=oleksandr_andrushchenko@epam.com \
--cc=andr2000@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=jgross@suse.com \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®