From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3046F35AC24 for ; Tue, 23 Jun 2026 11:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782213097; cv=none; b=rdvxgfoZrNF2/C87yAQdJj5Ds13F/MhIuEh5dxvHq0MG6pS9DlJa070WrrtOoqF/CHEF2OY8r3UJbRvWDytYvvFFpZbLpono6nrXQrxh1DqwrdBdz/ljg/akWJQ3qTv2yzUH8AEX7gfOu/BoOMoACGK4suG+pvtLQCVwA8qiWVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782213097; c=relaxed/simple; bh=muGmIAE3ctBmNTCnYhUL+xgeooXP1KN6XjPvfxiE1yM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iKQp+Mg7XOuQ7zfuwD9Nj8Sq8Y7OGpq8U+THB8IKqoDFmMmGMGGi7gHxcLYuXfv9y4wbkEqpXqH+DaoWatuT3B2FxLQtPnaInZHVgzABIoEWft4hC3I4UbIUKogLGifJoiyLnftrNqYJ4wjpmATHzfmvmUlQ1TxEXREuwO3DPH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KfIlS2Fi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DgrgUsrG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KfIlS2Fi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DgrgUsrG" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NAsPpA3655676 for ; Tue, 23 Jun 2026 11:11:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LzqALdblDXBZVqRJZi+H4syjn1xGwSVWvWykJOUOihM=; b=KfIlS2FiSRKwXgD2 SQm4aPtXMMnxMnt/+PKgWncIAaygKsJulJ8+cwWMbp+dyEhAoqGF50l5k04SEBTB Pvi5su5MM4e55GTuM/MZC9ZrlEyrdIqlF4xK+zsxIHuETI8zsshyOTTfnVIEMzEk U527Hre3A7xhknGfXVEyF97XLYutT1xLnFnI9iiyzRGRO4g++ahwjWrkzCqsn+wl jGAWkNvT59N0s3U/6z2fXeKNggw/H7h3HXtjntHHlvnUop+V/Kvzzz8gORkmn4sk 3Mj1+NpKPBZtQk6NYNEemlfJLhzJitGBZm1XiLgPthTsH/DQO2KUJzt7otoTZoV0 ammrgw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eypx38mv9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 11:11:35 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5177b12d7bbso8786661cf.1 for ; Tue, 23 Jun 2026 04:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782213094; x=1782817894; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LzqALdblDXBZVqRJZi+H4syjn1xGwSVWvWykJOUOihM=; b=DgrgUsrGmddcfQM3KS/ybwBKPBoG/o3r/cC/9qfRBc5FbBbueZchDGWt0iET0Bw6yZ zd7G73jDlK856krFqME0HtfzH3pYsltfTpxuuJYXzow4lkorMHln7mgBaJp6e0+CEEKy cASxkhZlETFIIUu5W+TYZLRXvsYFBC9uWsWFNy/lEVdBYsimq8F9kTDKQxbIbriIrhaD K8/oL+gvgE8o0HPvuk4OF5LssS3qmCwtDSCIhLsvSMKbCH7seFdiJYASFwvkMm0dcSxQ JGwii/f4ILorJimBseONf16bpsaYr5gPQbkjKEntBN1mZKrfOeulnxLw0oDY5n8tDgxF u+vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782213094; x=1782817894; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LzqALdblDXBZVqRJZi+H4syjn1xGwSVWvWykJOUOihM=; b=e/D4zBGm7grCtE7xQPGRBROa96MmiKz/b2H8aC3mv8/2nCKwp/VIYNurAwvINmgsyG nl3XzeDr3fUN+B3zZ3QYE68yadZnK6O0HE5CQC1KF+SxjhSvV45R19XM5cLh95F+bCt6 DFCAjJm1twrvT5IFWcFGX2Zv6oEtMSas6NtsSXYOEeggh+GI5xQUGhoj86RwXwdTlZtf s6o45ZbaZoAycAEew62GEGAJdZWs7oKrP4BhycBOdVB6HbNSnadU59sQiT+rMNzGX/qf v7M7VX7iqQ/DeEm01A+5YOdmN322S/p5MXTxlD9bzvFB3GWnVMhs15TGmoF3Fwb71ZgM tXkQ== X-Forwarded-Encrypted: i=1; AFNElJ87BnEcWy78f+gtckYfUhkl5mEAaZJzIdwej/ItV3jCQgWkOLW2+ylNs7hiyxFc8gNDbpY25udAJT8kbF4=@vger.kernel.org X-Gm-Message-State: AOJu0YycSQeS0ifU/sxU2PCQVQ5H3YxUt9KqnGQ1tWOd8uqK+tcsStLo n3/vw7TND2B32YjTM5uHQjBRyXMI72U0lJiN2Ao98d2dGDRzaAiDrr5+H31+M/Jl4mWdTaSVNA4 eQO/VNzgMqB1GeHshTG+nISUuqei0+2/7SrJa9lwebt67eq2ThACuWJbh3MWtXCg6+RU= X-Gm-Gg: AfdE7cn6Omxt5t+h0ZY5S3mbCERNg/cULxEXCZDYC5s5gTlJgNlN4nY3bP9NIXhBfwI BAzmtr4mAPNafUSyhyuLisB+KM3BbP/B+FiLbPibfPZwdEduONo7eIjHTtCyIf5H0F1N2CSgx4R O1QHEaMtHt2fcMMJsXrtAmpktA8DIZJ4fS8vL1b8Cx4km7EgQmZYdH+GBDdWMeIy1S6x+sNAsJA 52BFSDCo0QvucCALM42FzotlhIpXjcL+cOEhrLoImh3GwvAV5i8LtafHzJQsZwIy8Z4gWW5Biwx m6exBlgTR+aE2MxVmUoI0+S7yvf9mvWIJ5ZUWN78FdzkWkTPmPc6Fw2lzhc3EPNLkQFfXcDxTNW FZT44/w3WvuVR550rFK1dVkxaSB1NAX81jBk= X-Received: by 2002:a05:622a:1388:b0:50e:5e6a:c7d5 with SMTP id d75a77b69052e-51a4f449a1fmr47517581cf.1.1782213094023; Tue, 23 Jun 2026 04:11:34 -0700 (PDT) X-Received: by 2002:a05:622a:1388:b0:50e:5e6a:c7d5 with SMTP id d75a77b69052e-51a4f449a1fmr47517191cf.1.1782213093453; Tue, 23 Jun 2026 04:11:33 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6977be64ddasm4436982a12.28.2026.06.23.04.11.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 04:11:31 -0700 (PDT) Message-ID: <22e0ab27-4b80-4a08-9d3f-919014e741bb@oss.qualcomm.com> Date: Tue, 23 Jun 2026 13:11:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] powercap: qcom: Add SPEL powercap driver To: Manaf Meethalavalappu Pallikunhi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Rafael J. Wysocki" , Bjorn Andersson , Konrad Dybcio , Daniel Lezcano Cc: Gaurav Kohli , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20260620-qcom_spel_driver_upstream-v2-0-a3ee6837c18f@oss.qualcomm.com> <20260620-qcom_spel_driver_upstream-v2-2-a3ee6837c18f@oss.qualcomm.com> <298cf2f5-64eb-4430-b264-0d046df14dbf@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <298cf2f5-64eb-4430-b264-0d046df14dbf@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=EsfiaycA c=1 sm=1 tr=0 ts=6a3a69e7 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=Y4jFsmSDHp3uCgbhOVEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: RTGIEOkzJpNRB5u1x6iUHaEWAbM07EhI X-Proofpoint-GUID: RTGIEOkzJpNRB5u1x6iUHaEWAbM07EhI X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA5MSBTYWx0ZWRfXyR8TTBT29G/k 6ZiVvl72l4QuNSkmKggifKCfgQwPgX5BeJRA1GKaPg8laWTwyWEXQzy58EWftotNzwqQQuunK6O lnOooPdMf1Z23sc9NLbRGGf/QdAXBf0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA5MSBTYWx0ZWRfXwvt76x47rdNd RrFL1b6syhTlgW5GR4FUPxLEmlRM6OrMP5ofnniBN+Ct1AGxQdPIPHF4VByY3i2dJ4NxiSLRpSR nr0XcmiqYlg6AvfJ7Kmsk/tmXeb9VVBLbawZArG7ijSgrVPrLKzRZRfwBFUyD6xq0eV6otsHQCE 6IzFbYoMEzPBx5KV4+cat3Sa1n691W+gaRIbWSStY8EPbDeJLNxwztkaDOiJwFoI3jaFxwnql3I GBkSBtUXmMBBvX5LJyX8gUm5lu3k9127UHxcwxKyQnsJiRxaKJ4x9N3atWD1aCzuzE/GspH3RKR GViTjnqeCtXHLy/0xFk3sE9feS/2b4bOqHYHxHl7V8+GWU6i4SZUNhGeA4Dp5lmvKVtXD7HPxHo LWbcMKFaRFSdwv/alF5WuvkNvotajTdUtND99eRDV8gMVgcYuSeVxLWKRmfserTH/MDZ7jFqkIp 7YIEUDkRHzd3XYDxVLQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230091 On 6/23/26 12:58 PM, Manaf Meethalavalappu Pallikunhi wrote: > Hi Konrad, > > > On 6/22/2026 4:31 PM, Konrad Dybcio wrote: >> On 6/19/26 10:39 PM, Manaf Meethalavalappu Pallikunhi wrote: >>> The Qualcomm SoC Power and Electrical Limits (SPEL) provides hardware >>> based power monitoring and limiting capabilities for various power >>> domains including System, SoC, CPU clusters, GPU, and various other >>> subsystems. >>> >>> The driver integrates with the Linux powercap framework, exposing SPEL >>> capabilities through powercap sysfs interfaces. >>> >>> Signed-off-by: Manaf Meethalavalappu Pallikunhi >>> --- [...] >>> +/* Domain configuration */ >>> +static const struct spel_domain_info domain_info[SPEL_DOMAIN_MAX] = { >>> +    [SPEL_DOMAIN_SYS]    = { "sys", 0x40 }, >>> +    [SPEL_DOMAIN_SOC]    = { "soc", 0x00 }, >>> +    [SPEL_DOMAIN_CL0]    = { "cl0", 0x5c }, >>> +    [SPEL_DOMAIN_CL1]    = { "cl1", 0x60 }, >>> +    [SPEL_DOMAIN_CL2]    = { "cl2", 0x64 }, >>> +    [SPEL_DOMAIN_IGPU]    = { "igpu", 0x08 }, >>> +    [SPEL_DOMAIN_DGPU]    = { "dgpu", 0x44 }, >>> +    [SPEL_DOMAIN_NSP]    = { "nsp", 0x0c }, >>> +    [SPEL_DOMAIN_MMCX]    = { "mmcx", 0x10 }, >>> +    [SPEL_DOMAIN_INFRA]    = { "infra", 0x18 }, >>> +    [SPEL_DOMAIN_DRAM]    = { "dram", 0x1c }, >>> +    [SPEL_DOMAIN_MDM]    = { "mdm", 0x48 }, >>> +    [SPEL_DOMAIN_WLAN]    = { "wlan", 0x4c }, >>> +    [SPEL_DOMAIN_USB1]    = { "usb1", 0x50 }, >>> +    [SPEL_DOMAIN_USB2]    = { "usb2", 0x54 }, >>> +    [SPEL_DOMAIN_USB3]    = { "usb3", 0x58 }, >>> +}; >> >> I would expect that the names are going to stay common, but the offsets > > Names also can be different here. For example, hawi, It has only subset of these domain and it doesn't have dgpu, it has only "gpu". cpu domain > names also different there. Presumably we can unify the names (i.e. use SPEL_DOMAIN_IGPU on both hawi and glymur) > >> will be different. This array should probably be called >> glymur_domain_info[]. We may have another LUT just for names of indices > > ACK for glymur_domain_info. >> (i.e. [SPEL_DOMAIN_xxx] = "xxx") This approach would still save us quite some bytes for the names that are the same i.e. foobar_names_lut[] = { [SPEL_DOMAIN_xxx] = "xxx", [SPEL_DOMAIN_yyy] = "yyy", [SPEL_DOMAIN_zzz] = "zzz" }; glymur_domain_offsets[] = { [SPEL_DOMAIN_xxx] = 0x20, [SPEL_DOMAIN_yyy] = 0x24, [SPEL_DOMAIN_zzz] = 0x28 }; Konrad