From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31A6D47CC97 for ; Thu, 6 Aug 2026 15:50:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786031415; cv=none; b=iYdirDXiEbq0/vLULzou8wyBdo/Y4LTCdd4VTKGoSRpnCU/6HAHF2/vIEKZzJn0ddtfo+bqXU+oGfJAPaubww+0tKbZPNBCb++FxrQV9JaF2q1ZYGn8bh89c1YyifavEsRCsszlreMpDhvwL/DmAAiyqtlQ2MXm10rWyVFa46Ds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786031415; c=relaxed/simple; bh=ZXflIJh6gXo/o6+vJH//R495vESydSLexbO1Blx5Dcg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RIA4H7JcTSDEpldiqLs35cByiTY2dkEjkv+utu1ltdrhbFn/m0vNzBNUVvcDqaj7FDlHn4Sk/eZwtgU6EEtlQvyCtl9dOoOFDCZbExa+WW5z4Ey8MpwPbsFG4B3IuxaXqlD2eMrjKhsuL1BaqzJXZbka76kqSwxRZzCvWosMqCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ac8vE4Nn; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ac8vE4Nn" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-69c5fda04a8so3805936a12.1 for ; Thu, 06 Aug 2026 08:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1786031409; x=1786636209; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=asCFiYJveau6ClMWqMUirF9GQ1J++sD+ZiiBvAODmD0=; b=ac8vE4NnA0/DIeo408i1/AoUGZtdCglYQ6GZ/O2hu7l5fGxoh63IxsBbKC2dxmp61q TTsh3f6VyerC4NK1KrUqL2sRvLir5mX6Vn/aO9X3aUmodLGraWztOVgVhUkTfwZKw940 V5qsrF2Zc+TKwvxN4apADpNZr9zn03nE8ow9Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786031409; x=1786636209; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=asCFiYJveau6ClMWqMUirF9GQ1J++sD+ZiiBvAODmD0=; b=eO/TgEN7X8FOPCJJzRaJSMdl38qwlT71o+1GVIdDB4XAanger2aLbhiFSTy2bQaisO g8ram9y2JztQ+1ykHAwAdDIkdjpQoNnT8r9PP7S4oKBqwHo+PdoYqgyDmu4P6nb/3Yzb mpujRbbCCDp3gJiyqwRH4mT27NagCwZ4REtIZ6jDlj5x3y02eT2gDPxUAA7qooSqmIne OLG5uD7wTGPYjOzSDXTwUUwIAPR1DpYy+7eCV8w3KIxHSBo74Ybokk/M7Uxfc8yA1Imt g7LhqUrzZZ00d4rF5sP/aeUXobkg1yt59WmB34ShztCRboHGWhlTTXoTZ0gu8lKoy2CQ a/qA== X-Forwarded-Encrypted: i=1; AHgh+Rq7O/oA+WwYLpp87puapOJ9iPW5y7u6wzA75E4JoLtvRIjBk1EU5s5WKzbjJQYuvJYYeI+CLMoSGMvzUQM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0vwsDQgTlyCsJItAhJatMU/MYDW51RjRU+XrxL+r5F+oSkYiN aknA0lrQGQvOoQJ43NzxlX5XZYz7h0M3imjz0kjZujczRaOe/Dwz+iRXsxe0lyisHvJU22EWxqt 6ilVVocI= X-Gm-Gg: AR+sD10HgcfJWSnBX0c9Za16m0xI0/L5zJePYPO6tFfXKSfL6hl6VPN1WmLXAd8h//k sBcUIQFuqSGokdXKUG3enPPwKzWbKGQH8fy5J14CGKQ96coJpiV21S4kc8IfMmMlsb1VYGCGeI0 HaVy1ZnuRRLMFd1dUj+PSM9B3bD9lkNo/qMchBAeiJLP0VOqIBVindnxZ8wt0LXjHQSP1lvZJKS hLnNOradgxabsLje858z/aZY/evPzqcSvacwVY98hF08op8qFJFAmxZI4BTARbGpxtZA+88KrEk S21VvEZF2H1Ju9OT03o75jG56GTnVcpme9Ct4/fsQgVYSNP0ATiR/+bfqXJbnJNJVC1fh5gMnB/ Um/IkNKQb1rDck8YxpkGFAFglVFu/9yRugpHMFI3xEFwmI1GBo2Doj3e1HYmryEU25A7432ohl3 3JWVqbxOClmHq0kVGbG+SP+cy0u3O4vV/vejQIPH8E3LalDzSQKbRMfYVGNSUMpdJWaj6vBA== X-Received: by 2002:a17:906:fe4b:b0:c16:6c84:4b8e with SMTP id a640c23a62f3a-c2039cc42bamr762859666b.14.1786031409153; Thu, 06 Aug 2026 08:50:09 -0700 (PDT) Received: from [192.168.1.128] ([38.15.57.99]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c203624e6c8sm270451566b.15.2026.08.06.08.50.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 08:50:08 -0700 (PDT) Message-ID: <22e2acc9-b822-4119-802a-74efc6df1509@linuxfoundation.org> Date: Thu, 6 Aug 2026 09:50:03 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] cpupower: fix topology array handling To: Ali Ahmet Memis , Shuah Khan , Thomas Renninger , "John B . Wyatt IV" , John Kacur Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20260803175215.117518-1-ali@iusegentoo.com> <20260805114305.97160-1-ali@iusegentoo.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260805114305.97160-1-ali@iusegentoo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/5/26 05:43, Ali Ahmet Memis wrote: > On Tue, 4 Aug 2026 14:45:48 -0600 Shuah Khan wrote: >> Did you think about a scenario when the following check will be tru - i.e >> core == -1 is trur? > > I went looking for one and could not find it, so that branch may well be > dead. What I checked: That is really the questions - the branch isn't dead, it is in the wrong place. Sounds like you don't have a real scenario to test this change. This why I am not eager to take either of these patches. However, did you consider simplifying the logic in these conditionals? if(sysfs_topology_read_file( cpu, "physical_package_id", &(cpu_top->core_info[cpu].pkg)) < 0) { cpu_top->core_info[cpu].pkg = -1; cpu_top->core_info[cpu].core = -1; continue; -- Is this continue necessary here? } if(sysfs_topology_read_file( cpu, "core_id", &(cpu_top->core_info[cpu].core)) < 0) { cpu_top->core_info[cpu].pkg = -1; cpu_top->core_info[cpu].core = -1; continue; -- Is this continue necessary here? } I think the following logic makes sense without the continue(s) if (cpu_top->core_info[cpu].core == -1) { strncpy(cpu_top->core_info[cpu].core_cpu_list, "-1", CPULIST_BUFFER); continue; } thanks, -- Shuah