From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32EC51DE3C3 for ; Tue, 7 Jan 2025 09:31:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736242292; cv=none; b=DbQs0YQTEocc+enx0Q0xO32XvRnMKAEsyYtAeqR/Q0Om6Pjx0rEHM8nOz4ut5iMN2M46mlzbRg0OrZLBd56ITH5KALJ/bi9ktIggmg6K/lqy0xXowc/Fexx2vtu5VODfNbDf1QznehBFrJx/KNHjWnX/Wb5d7OaZHkSKb1CUEVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736242292; c=relaxed/simple; bh=VpPz7zOChtwygspdaQG1hbiZ9qD4llstqLPr/YJtgd4=; h=Message-ID:Date:MIME-Version:To:From:Subject:Cc:Content-Type; b=Lh66jroca/VIvtt9HOkcRmbIf7+sDzZeme1Y2L4ZEVtVsawOqFEycFYQxSweygeCqhtsXuAaPSaX70GtC2tNHrTvo9l6KKCEvNOCSQK4RU5IM+AYMLvmN8vDX0O4bqZvNypay2rXk+ar8+7Z9FrMW1aABjg7O3/ff9ZznKkQsLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y43uZjAY; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y43uZjAY" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4361c705434so110299735e9.3 for ; Tue, 07 Jan 2025 01:31:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736242287; x=1736847087; darn=vger.kernel.org; h=content-transfer-encoding:cc:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=NYihjbxBvy2f8ejG3REqVaUmpNYaOeHIaj+WHecKSEo=; b=Y43uZjAY24bu2n5PBZYKwCeTQkX3NbwAW2zff7w6lb9VkdBfW+o5bFMFEDzvuyKWdu 9BxZLGpoah2IXwsx9jSQfDECaWYpnD3x5Ek3FhX35ZM0V9zGMLDorxe/1ydcl/GtmYRA BYYgPEjycp4pUr4ddGFLDXE/RmbtJQaF5kYP6HbVXMOhlF71bSQZx4bnM/sZ6FfACH8N WnwfiFxLYPfVDlpajU8+eBACr0V373gQEfJ2GMcxWlAzgHY9JqqgKj0H1zY0ZfV1QOa+ Z+YnXofkltjI/eDvgCV4zLuHQBCxp5J7SeIhtVIPGKpMKWYllx3cc499hZqod3MLYOct ha0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736242287; x=1736847087; h=content-transfer-encoding:cc:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NYihjbxBvy2f8ejG3REqVaUmpNYaOeHIaj+WHecKSEo=; b=B7pEjWBjlQhWw2WknTXZY4So7U0klQL+GB1dB3IOwXbBfejYEsiTsWbGz3RTlbk4Di Dc5S69yfCejAuKRgricX3kEb9HPA9/wmYE+ISuF2aFVPCjhf+wYzlHYp3cO0HiQZAQbl l5GiDuOfGa2JbECdps//eHvigRRW29TJs9jDz1EmKcws3BT8Lzom4CmY+OY7mgkyLfjc 9D0MVugKDNrLGz4pa5hY9V7V51p972fTIRbv3Y8GmSZ5+35hr444lGUgAtIe9xsTCD/L LQCrIGalRpP29tCbdM4nkbfKib+Drblo/fb5tydaEFmcipk6auUsZ6t7/rblpKw9uheB rHLw== X-Forwarded-Encrypted: i=1; AJvYcCX5HES+K0PE2yzoFVmzUOpXq9lHsL8OMxH1Z2f9FDbPdAjnnfG9oq8GRRf9j8Npylvis79IagU2pE9tXZw=@vger.kernel.org X-Gm-Message-State: AOJu0Yyhc5cm2lrjNvaaM/pQBEpmGuxRgVkZFeuOpSo3fC+q0Fag3mLC y+sl2kfAKOvZSLECsJ8nSHcZi4HeYMvGDe9qM8U3jNWBIpIGAjOIBKSJ6u4H4Ps= X-Gm-Gg: ASbGncuGdVc+QyovQIYwBXz0ku06s2CJDYFLML3puBXHb00IdO8l00MocsgH5qn26kd mJXu6M4aXdmSQDWQELcXcOo/K3o35XFWxrgO/4Jec/qqGxcBj3z/axgGF/NSTbSR3sdZ6B6EzXR gFymdNIUlASzSoAYw3p5YHIjNpvcjOIh26PHo4O1mNe04RQuDJfnIwRRiwB30xO8xSd+ukLIVNI XKE0AavQE5S3tS+n6gVfpY7EeiVEuj0IpQsXL9HyuwgP+PZHO88rKTsRw5YgT3kSQ== X-Google-Smtp-Source: AGHT+IF+QGx5FMZfOnBB2/EmNmjd0XzhhNOcaaIiTZvF2RS7zDfWnwMRJj5VJQWy7bKj1j1Kx61hxg== X-Received: by 2002:adf:b302:0:b0:38a:3732:444e with SMTP id ffacd0b85a97d-38a37324592mr36018223f8f.55.1736242287075; Tue, 07 Jan 2025 01:31:27 -0800 (PST) Received: from [192.168.1.240] ([194.120.133.72]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-38a1c8a6e19sm49691635f8f.100.2025.01.07.01.31.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 01:31:26 -0800 (PST) Message-ID: <22e6bda9-bb5b-43a2-b256-64ff789bbf69@gmail.com> Date: Tue, 7 Jan 2025 09:31:23 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Hermes Wu From: "Colin King (gmail)" Subject: re: drm/bridge: it6505: fix HDCP CTS compare V matching Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, static analysis on Linux-next has found a potential issue with the following commit: commit 0989c02c7a5c887c70deafen80c64d0291624e1a7 Author: Hermes Wu Date: Mon Dec 30 18:51:26 2024 +0800 drm/bridge: it6505: fix HDCP CTS compare V matching The issue is as follows: Source: drivers/gpu/drm/bridge/ite-it6505.c, function: it6505_hdcp_part2_ksvlist_check: for (i = 0; i < 5; i++) { if (bv[i][3] != av[i][0] || bv[i][2] != av[i][1] || av[i][1] != av[i][2] || bv[i][0] != av[i][3]) break; DRM_DEV_DEBUG_DRIVER(dev, "V' all match!! %d, %d", retry, i); return true; } in the above for-loop, only iteration with i = 0 is performed, either the if statement breaks out of the loop if the condition is true or we reach the return true statement. Both conditions means the loop is never iterated, yet the loop is expected to iterate for 5 times. This looks incorrect. Colin