From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEAD6425866 for ; Wed, 19 Aug 2026 11:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787138952; cv=none; b=VWIoVFNnJivubH9kDVHeYD1sVq1rK+HqGUunN/zgAuzInNYdzre/EipgG8ng2THWyR6qRyIi/LwCrQ9SiTJmSd4m8/e4yEV0stBLnglsPwJHuhu5PKTFNsZhOq4IZB5pd7cPWXhmuAaTo1UBdHCvdbxYV2wPJJ1vdGIxMXx+aCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787138952; c=relaxed/simple; bh=4+98w1XYwLAEVWZchr3OiJkX1RmIsratTg1eeXkABJM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J9FfI+GEp+NYij3dTKst5Sm3hU4ShnKzYmi8DuNPnWTvEuTVheftoOTHo5nLLFsCVIeVrOobkzTSD4W28rIERpQBi3L5mwoolMjExT2eQQMmnyMeDZtixWlMn2Z0PDbM6wdUeWnC2v00RUmBKWk7xmA+GxunGWm6UAg6OqB3ivs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=puGmMZnm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KJfWjMzn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="puGmMZnm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KJfWjMzn" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67JA7rh22947327 for ; Wed, 19 Aug 2026 11:29:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C6fn7nuOdKxU5RfwSXqG52Pz3UneVX57/0Oi5HAx+7Y=; b=puGmMZnm+BPk4Xns p/71esqqiXhixGLhDTZhcaOasJS1igw3GqjX16FHEKINJUw2Y31otXYJRO17Xups Qs+3yUOsd/zkeLgg+Lc2ukQdba6kqKUcZqfk3R4pNC8WvFXdAfsY5X51bE9QEcje kUAXM6ukq1HsvWeeGOHy6jAJb0T3cRMb56tdFeW3m5V2ltRigEm+e+PpJ2UrFjxP r4eysisTw4Myac1v4LVPgEZWoFfHVGNGDUCReuHxIyrzIURFBT++UUwWdrwZATfJ UVWTYiTTx0GhaOTmhTEJE9tFLJ7hB2QLKP5Kllyx79dJ3v7WzJ2mFG/4MGYtwtoA ZOD35A== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4yfkayrr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Aug 2026 11:29:04 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-52d57d17d6cso1968551cf.3 for ; Wed, 19 Aug 2026 04:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787138939; x=1787743739; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=C6fn7nuOdKxU5RfwSXqG52Pz3UneVX57/0Oi5HAx+7Y=; b=KJfWjMznOnNpEFLBUI4EmC+AQhzzW8YYP12P2vwZEMRAC5iHTv0J+d7OTH65pRNC12 SxtTOPqK60dPz3O8zn4fJ9tXk3G3qpN6F0ErJTcBJJqJ6sC9SzE5qQdSBuqBxKX7Neaw 5fw0fanE6oWnQkiMFCiXzq2GXtgNmQs6R/dtI7njO53Is3jurLm1ojwcmE8IhdswmIJ4 HHPcKc6SragCcWS41TAUnYbxvNVtMl4saPOvaUBBYDt1Y1veS+SQOdxScK7OgQD09C4E 1wQLxJSxZ7hzbaBIiiK5oXXSWo7QDEV6RWe/EuSoiltTgO8C578JbqMGkeEXXzfYp5Rj 0vFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787138939; x=1787743739; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C6fn7nuOdKxU5RfwSXqG52Pz3UneVX57/0Oi5HAx+7Y=; b=G5RV637KLkscjP4qcn2KuxKef3PWnrsyEj1IOhqsQLERH5BMvkszzvBYJGilYH20Gb aW3kJ4YZPFbfDCMGto4dVbDhP2uCz+CPO9xuyeHoG73qmskwwAV+8lVHK6uQz9z34WOh bg6QbqPDmoOtK8L+sS06EUNfQGuRSNHvdGzIeAYOdmQO2PgTV/CCMDbmG5ZrBQHCLmKV GKsQ/ll6z/xdVsowJvUe43hnxKGizfY6k43wu+/4KF7jehgNZL4OrbumnfT/dfTaF6I+ d4EC/e+g9ilLIUvhMiwYppOhNCObAqwu65P/z7Bf0uxJbcQSUYdrtF0/s1kTPwB4FWiW qTlA== X-Forwarded-Encrypted: i=1; AHgh+Rq+KlRD9FinePeYt/MG+bVtsjsoUmoTYt2T/d1PPg9c4ftJCa+4JxkMdiEDbaUglJWKFsNSo6yFOv07aaI=@vger.kernel.org X-Gm-Message-State: AOJu0Ywoe0Op9FcdOeESDEfmQLn1hVqYfsZ4BqaK7avxRE8ENDdCG5hO L9cQyhowpgxKOVtq6PppyK7G4/kn34igqvv4WNVMCD+qQtgoNMUgSWeJ126VfD6T5UIO9LAL3LW OWvW/HRQVL2Cq3OkId4zUp2VfHxWNgTe1RS/yz3KLMDQ56FDSoKBh767NgIrzC+T4/t0= X-Gm-Gg: AR+sD11cq96twNida/yvpArfeKO/IFcR+f77djH8NMlsXlH2y5wxjby+CWTyKWjKbmy qLObYB3riQRI1+k5jrl9ysJM/TXIpTH5aQJyAg6zcUDLGJf19UyA3Ye+qulm3vA5wHS5f1SeeRB PILbyZV8GuCm7BSwHYMbghwpxIZRnq5wNHfWem6y0AC4mxfnSqtKWEehLZ1ETrFhwQuYaf/3JzL cfkK+ELDAR1Y6SeGBVxBHfDSYCVhjWwB0QKKbsjb7GFDfAdrLHK/9g1YTtGe/aGPYjRikYBxrZ8 XHZz9Fe/gDeHJ37K0WyxZ7jlLVyY17EEen7pOi2c2hN9qk6BHWwTwPX5dqGpXeEvlogjf12wO70 auD+XkVQDsvsyGAC2yVIzEAGP X-Received: by 2002:ac8:7f0f:0:b0:517:6162:daf5 with SMTP id d75a77b69052e-52dd5c958aamr25687921cf.3.1787138938948; Wed, 19 Aug 2026 04:28:58 -0700 (PDT) X-Received: by 2002:ac8:7f0f:0:b0:517:6162:daf5 with SMTP id d75a77b69052e-52dd5c958aamr25687741cf.3.1787138938569; Wed, 19 Aug 2026 04:28:58 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c243c38af97sm59996166b.49.2026.08.19.04.28.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2026 04:28:57 -0700 (PDT) Message-ID: <22f01d3e-85ad-43ec-aa01-e5f3eced8703@oss.qualcomm.com> Date: Wed, 19 Aug 2026 13:28:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] media: qcom: iris: move OPP handling to VPU power transaction To: Hungyu Lin , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Stefan Schmidt , Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260729011001.16999-1-dennylin0707@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260729011001.16999-1-dennylin0707@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=PoGjqQM3 c=1 sm=1 tr=0 ts=6a859380 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=pGLkceISAAAA:8 a=EgvVS7bLYM35CM27wtQA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE5MDA4OCBTYWx0ZWRfXzZlNBQpHPmzn lvJlEOE2NKeZGAXL0MnNGzYjkjgIP/5DTWsF5kaNbLlOAwZmc2vXNhg5hN2CBMDxh/KxaF+kRmD qV2hNRH6yo7pe5Q8Eb65oliyHRq9v6/Ib33yKLW6giIHmkSsjlOhnGp0cRAlzFzQcayFT8XWo/t bfsCJhfcyd//AXFngJ+yPw0R7mT9BTeMIYhvUrkTuXFnBxHsjcvBwgSSDjdBdsnVQbS/so7uDVJ lqNSxBXOI7yf8wxYCdJhCg1wIqlsL6Da+9KEUMW8IE6sWHGgpwHWcwcAO149lJYaXT+FNrErzN+ KN/LFBwUu74XPJzokOywZPQqTmkJKuloNay9ltwYgzJIS6nVJyZzEl/4mnG0nr5BX7A3TvM1As4 RZh/dGPIIlwssflHV/LvO7M5yQZHv3UYIaEygTbQoo64xkG7ojzUVCNB3E2Lhf5LUS3AHkWY1Hi proNTHF+cIgZ1P4FLNA== X-Proofpoint-Spam-Info: AW1haW4tMjYwODE5MDA4OCBTYWx0ZWRfXw8SszLmhD3qD Te7czNyw0jRvMgqZe/kE730PQIC6Q9slJMoSDUV8hGwQyRiTDTZdQePCE5iBnYQa1jD1vU2R7zb px5aeeLZrkktx2AHCJQKdlcCDUnEzC8= X-Proofpoint-GUID: XHVrM8KTnEJIlMT2ZOsDWNOyKW4mNsvr X-Proofpoint-ORIG-GUID: XHVrM8KTnEJIlMT2ZOsDWNOyKW4mNsvr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_03,2026-08-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 bulkscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608190088 On 7/29/26 3:10 AM, Hungyu Lin wrote: > The power-domain helpers currently update the OPP for core->dev while > enabling or disabling one functional power domain. This makes a > transaction-wide performance state depend on a low-level helper and can > leave the maximum OPP selected when a later power-domain resume fails. > > Move the maximum OPP request to iris_vpu_power_on(), after the ICC vote > and before powering on the controller and hardware. Unwind the OPP vote > together with the ICC vote on failures. > > Keep the power-domain helpers limited to runtime PM and use > pm_runtime_resume_and_get() so a failed resume does not leave the usage > counter incremented. > > Fixes: bb8a95aa038e ("media: iris: implement power management") > Signed-off-by: Hungyu Lin > --- > --- a/drivers/media/platform/qcom/iris/iris_vpu_common.c > +++ b/drivers/media/platform/qcom/iris/iris_vpu_common.c > @@ -472,10 +472,14 @@ int iris_vpu_power_on(struct iris_core *core) > if (ret) > goto err; > > - ret = core->iris_platform_data->vpu_ops->power_on_controller(core); > + ret = iris_opp_set_rate(core->dev, ULONG_MAX); > if (ret) > goto err_unvote_icc; > > + ret = core->iris_platform_data->vpu_ops->power_on_controller(core); > + if (ret) > + goto err_opp; > + > ret = core->iris_platform_data->vpu_ops->power_on_hw(core); > if (ret) > goto err_power_off_ctrl; > @@ -495,6 +499,8 @@ int iris_vpu_power_on(struct iris_core *core) > > err_power_off_ctrl: > core->iris_platform_data->vpu_ops->power_off_controller(core); > +err_opp: > + iris_opp_set_rate(core->dev, 0); iris_opp_set_rate(0) will almost never do what you want - it will set the rate to something lower, but not disable the clocks or drop the power vote. Dropping the vote will happen as the device (runtime) suspends. This is an existing "issue" in the driver Konrad