From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8CD5348898 for ; Mon, 1 Jun 2026 08:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780303709; cv=none; b=Hqgm2mMvbpmRp5Tg2Qo0a8wa6UQrytCzVL3eNqZbF7ocXT6detFZEkVY6eXkRZaTgm6yKVXh13wxWT/uFLZUmhsvEkRip0kc/JuiIIN+HuJsP9oCNGJAw8/AMsYGbo31ap215HoXWKidnBQ7XwNXZOSI1NLry/K2+Q1Kbquz/eA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780303709; c=relaxed/simple; bh=fk629VZBGTRm9OfLwrzcQ1hhc5VKHeUR7OD/kkF1Kgw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LwlyaxdHDl2brF2Vy5DkNgQ1OV271AnwqZEfQSNZ69ms31YTWySkIeoHNtJzxaT0qIIRQfRjHjUm2ounglswpjEKySx7uw0w+q4PSr4M0rNnVqQ+PbtAcJqakQbbH87CY47VJunGdkWCwkUavS6bVwjzsjTiLpv4UqGHi75sOlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pR5oT5Ik; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pR5oT5Ik" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-45eecb8bf67so2843278f8f.2 for ; Mon, 01 Jun 2026 01:48:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780303706; x=1780908506; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e6R97isaU/cFcZ2I9WM2rO8XYaMDHSz/qiNm9k/zmx4=; b=pR5oT5IkeJQ4SZNBGG4/EXkm2HmFeONoBn2YSWyyVn3gTy/vfKU7B8bGUv7Wbpq6ts PYSFMY0EkGQK8UwXUOk7OWeSSgfP8aBLhFsBpZxDOQMappRG60cGDZE0aysqda65T6UR WPhlwTrDG5Qq4j6TmGH8o8xEJliTdM8YYSFOA5qLsOQ5iRJm9MWyWCIP3yM2RbaQ4i5J Rdv7kwUjEZEcYl58vN5v0pfP4Wbo4b4lRHZ//NzWdTZkQ25+La7zKWTUpWeafHGAPFPY uvbDFZG7601ba+VVAGx/U/l6bQb+/mP5IjACDF/Q2lt2i0GeYYRRH40Ksv1TBGTzIIn2 SBIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780303706; x=1780908506; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e6R97isaU/cFcZ2I9WM2rO8XYaMDHSz/qiNm9k/zmx4=; b=Jcxzibcmv3cuXHFMlt+BA99M0fadYbzMTuO1CxFU6fYlTwDdbSuDPmrIxPOhsVW1MY Kth+2ObNqwypYyZb5aQOqTR6+JlYfmMZ6m0WsIdbutbk1jOvN2jRjbPLW3gb0swOL9AK LGbVM2vXOj+4Bf5HBWcakwbl3xpa6zGUg+dl62auKUC/6QUAjTkIj7lJNvF83kL+vusX ypzk9lzQLC0ojC0M6izW/2LHQ7GfNCApPfrQYsV1YZAWmnHD1YvJnJlbuwm2O2G9fjw6 D9q9NbXsiJ6jlLZrd7n9HBdpHPnJD2OVFmUNpzCQFyNOq+CD7wwN8YigjzS4jy2tWomq 5WAg== X-Forwarded-Encrypted: i=1; AFNElJ9uNPzsYN5xAF4d71vXn2C4zSbBpzjwTjn0BZYCBTqSz+aITZaFCDA7s/AmL+Ktee3zIIipeN+S0dPz39w=@vger.kernel.org X-Gm-Message-State: AOJu0YwtDslK/rwMvUu/lbmloWQRfqwDBMerZDQr9Z6MmIFSWsqF0RNK sgQthuIYTm7RduIKQ/7Hb8uwLGrJ1fw7qnB2O5aAPgy0QyRQwQEPpRa4 X-Gm-Gg: Acq92OE1R1emEtyM/95d8FxmKs0VhmxT73GxA/mkiVB8OfgZN668krbxckhDEpxkC3y LzDd5R0rxs0I+foEKYwviMqxBILtUMscUsYkwwgqdASPKLejoEN9OKs9JuXLFQ30fA4TbdtkY9w cggjs/XvvnQoEivPzx20FauWgGF50lvMEOazssYgmUpHEhE97fj/PtEIe+hPuQPZTKi0ASsK8PW K4S61CbGkXdzcrLQ7YNMjwr5sztcVqFdkKG9FtYJEuE4dvgu6zqjAVfugpGPx5CCGdmKl+viE1E dRkhm1m5xPE6VpL0rmMe+XatLuKfQWkfpO1YfmTZF8J9s0Ug/B95vdjW1op025OVNJuT0thQi/U CZbZXC7QGvTbUfxRPl/kjHTG4yTtLBoNiIw+uifZbym9gAWLxVIIIpkflQTKx9+fBDJd/fpXUdU omD2VhEUMyPItCEl57N9ug84yMt+P2/nVLzaLtcSIwbRyHTlVgpACYgp41iige/EQJVAWaTaTbV +2GxsCkzA== X-Received: by 2002:a5d:49c2:0:b0:455:7d77:1d25 with SMTP id ffacd0b85a97d-45ef6b75cf8mr13497273f8f.27.1780303705968; Mon, 01 Jun 2026 01:48:25 -0700 (PDT) Received: from ?IPV6:2a00:f502:260:28a1:17cc:dada:92e7:2b6a? ([2a00:f502:260:28a1:17cc:dada:92e7:2b6a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef34a0374sm21522883f8f.2.2026.06.01.01.48.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2026 01:48:25 -0700 (PDT) Message-ID: <22f344ff-acc4-47f8-935b-d1c3be7073ee@gmail.com> Date: Mon, 1 Jun 2026 11:48:23 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled To: Taniya Das , Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Brian Masney Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260519-msm8939-venus-rfc-v8-0-542ec7557ebc@gmail.com> <20260519-msm8939-venus-rfc-v8-2-542ec7557ebc@gmail.com> <608dc53d-17a8-4230-9ebb-48a94bf03675@kernel.org> <6ae3a89c-f205-45c5-87c0-5550f78502d6@oss.qualcomm.com> <01f9a303-846a-4048-8115-c94b9b78078a@gmail.com> <4JzpVyRt008YHZIv34VGG-Z_etL_fh9cE8AL30d-uekLUAxGmZNV9os6xkESzPAyzDHFHA9XXyPgWxzBlEfnhQ==@protonmail.internalid> <82f7a200-ab07-4ff4-b84e-305351f78460@kernel.org> <4ab6aa28-6b0b-436f-95d3-23b54d73a992@oss.qualcomm.com> Content-Language: en-US From: Erikas Bitovtas In-Reply-To: <4ab6aa28-6b0b-436f-95d3-23b54d73a992@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/1/26 11:29 AM, Taniya Das wrote: > > > On 5/26/2026 4:20 AM, Bryan O'Donoghue wrote: >> On 25/05/2026 10:56, Erikas Bitovtas wrote: >>> +    for (; i < res->vcodec_pmdomains_num; i++) { >>> +        pd_dev = core->pmdomains->pd_devs[i]; >>> +        ret = pm_runtime_resume_and_get(pd_dev); >>> +        if (ret) >>> +            goto err; >>> + >>> +        ret = dev_pm_genpd_set_hwmode(pd_dev, true); >>> +        if (ret && ret != -EOPNOTSUPP) { >>> +            pm_runtime_put_sync(pd_dev); >>> +            goto err; >>> +        } >>> +    } >> >> In Iris we do >> >> - enable_power_domains >> - enable_clocks >> - set hwmode >> > > This sequence will always ensure clock can be polled as the GDSC is > still in SW mode. > > >> Instead of >> >> - enable_power_domains >> - set hwmode >> - enable clocks >> > > This sequence will require the clock to have SKIP or DELAY as the GDSC > is moved to HW mode and it is not guaranteed to match the SW expectation. > > Thank you for the explanation. I fixed the sequence in v9 - clocks are now enabled before switching to HW mode, not after.