From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751354AbdJXOke (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Oct 2017 10:40:34 -0400
Received: from mout.web.de ([217.72.192.78]:50175 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751277AbdJXOk3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Oct 2017 10:40:29 -0400
Subject: Re: drm/i915/gvt: Use common error handling code in
 shadow_workload_ring_buffer()
To: Dan Carpenter <dan.carpenter@oracle.com>,
        dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
        intel-gvt-dev@lists.freedesktop.org
Cc: Garry Hurley <garry.hurley.jr@gmail.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>, Zhi Wang <zhi.a.wang@intel.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <f563de94-afaa-ecde-2907-d6baaad65939@users.sourceforge.net>
 <87efpsiu7r.fsf@intel.com>
 <636f6272-9074-53dc-2c90-cbb4a7cd0901@users.sourceforge.net>
 <1A433E6A-DE06-4407-9E33-3CBBA4ADF01B@gmail.com>
 <20171024142615.t3y5atz6nulkq55h@mwanda>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <22f5cdc7-fb58-1d62-0d5e-a3465297bb00@users.sourceforge.net>
Date: Tue, 24 Oct 2017 16:40:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171024142615.t3y5atz6nulkq55h@mwanda>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:aWcjKjjSR01TLEZCr7A8bsyCdDmHVWxihyIELgwilMIl4KJinDa
 mJyQG2y3L+QYCNIZfotj7Nbi4pJCycCu8ZWcLoinzSFqAp2166kLrS4ZnZKoBmToKEVr6Hm
 fi6rQMUWYy+qRecrp+AQWxdsghketOE1bHuN3YdSMme6Rs7B770z12Sf+p+Q3i2yuuasPoT
 p/3oz/8UjkIJtby/z20UA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:nx+KVPySmZw=:Sc96F1hBdfXtIxzzrun6RC
 rOkx6o8wg7KXU026B8d594OeSTFfoGY4S6hx0iUTU8WS/ju8MFQCPgmJ0DfiLjbH+Px6Nmj1F
 0fyjAkIlInLaLKtISyT030aShSDl8ZEfELA7Tt2wAh/cRGdLo3z2Xhs8THrryCeRdGbzMcxK9
 OYNV0BWnw9BiYGGSR+3iFqsv+UFWlPqsqWTv10MU88dFsu2odD6/ppYfZAfkrVBFl4n+x6yAW
 1L4gOSCNzS+PJY7jGK+rbBRjeskB32aM6hu7VQs6w3Xy97Xang4KY8jIiMH37SVc2uaokYD2X
 LaXl205HVghxM5NXS4PnCbGVM4jN2odOOnTQ6d4gKV7iSBt9w5p0D/t/95ouKVP2GEJ7tZRKT
 9wN83725LuHK2Rcvn9XcZE7OFrReC+89WbyoO61tfC56hvSmG1V1BjhgSi3+/JuhSMD6gzrfO
 GDzdpbJ8JqXPTpxPHd+zIn/lW10CsuNBu1azvBk3blReDqU/DqoMgNkLMTbKgw1On+tpfTfKu
 CfbDjE9d/EOpSip6kfTnavMvU02fOIrpKkayrWFlWjj+fNYE4134ergQq4AnpTqJ+LvAHZm2p
 MmMAn97As0QLLa0Y9QVQshf5IdbhC4YPgiBWW98897Wasl+bbkUjVsfWnT+cA1Ri3cXmJkVST
 rkgsair8iUKWj3h75AXWnPe4+X5t+Kq4Y44fYGq0uop36TTrhHj5oLM1ScVVjCa7AvuyFY3VY
 B16d9x+Nv0Nj2Abo69AOwd2q2caiL1Y57L1mu3xF4a5loiIvpq04wrSgMzOCOXvVQP1uCkz0E
 jguSZ3xGTDM6m2EBQPozad7db0OaoJKv9dEUCWo8itc98G/LAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> This isn't the case here.

I find your view interesting for further clarification somehow.


> Instead of making the code more readable, we're making it more convoluted.

Can the shown software refactoring usually help here?


> It's just that two out of three error messages happened to be the same

This is true.


> and Markus wants to save a bit of memory by using the same string.

And also the same executable code (besides an identical error message).


> The memory savings is not so big that it's worth making the code less readable.

How does such a feedback fit to information for the deletion of questionable
messages at other source code places?

Regards,
Markus