From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753705AbcBJUgQ (ORCPT ); Wed, 10 Feb 2016 15:36:16 -0500 Received: from smtprelay03.ispgateway.de ([80.67.31.41]:39203 "EHLO smtprelay03.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752906AbcBJUgP (ORCPT ); Wed, 10 Feb 2016 15:36:15 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 10 Feb 2016 21:36:11 +0100 From: Bernhard Walle To: Philipp Zabel Cc: lgirdwood@gmail.com, broonie@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] regulator: ltc3589: Make IRQ optional In-Reply-To: <1455097459.3597.3.camel@pengutronix.de> References: <1455048884-1143-1-git-send-email-bernhard@bwalle.de> <1455097459.3597.3.camel@pengutronix.de> Message-ID: <22f73d21ce5cf6f2b41d068ec74aa684@bwalle.de> User-Agent: Roundcube Webmail X-Df-Sender: YmVybmhhcmRAYndhbGxlLmRl Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, thanks for the review! Am 10.02.2016 10:44, schrieb Philipp Zabel: > >> + IRQF_TRIGGER_LOW | IRQF_ONESHOT, >> + client->name, ltc3589); >> + if (ret) { >> + dev_err(dev, "Failed to request IRQ %d: %d\n", client->irq, ret); > > ... and this long line. This was actually a mistake because I added the IRQ number to debug my problem. Will send an updated version of the patch just now. Regards, Bernhard