mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Trevor Gamblin <tgamblin@baylibre.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] iio: adc: ad4695: fix buffered read, single sample timings
Date: Mon, 25 Nov 2024 15:32:53 -0500	[thread overview]
Message-ID: <23038c4b-9f9d-4a47-8c28-89893027322f@baylibre.com> (raw)
In-Reply-To: <20241124125206.1ffd6e6c@jic23-huawei>


On 2024-11-24 07:52, Jonathan Cameron wrote:
> On Wed, 13 Nov 2024 15:52:58 -0500
> Trevor Gamblin <tgamblin@baylibre.com> wrote:
>
>> Modify ad4695_buffer_preenable() by adding an extra SPI transfer after
>> each data read to help ensure that the timing requirement between the
>> last SCLK rising edge and the next CNV rising edge is met. This requires
>> a restructure of the buf_read_xfer array in ad4695_state. Also define
>> AD4695_T_SCK_CNV_DELAY_NS to use for each added transfer. Without this
>> change it is possible for the data to become corrupted on sequential
>> buffered reads due to the device not properly exiting conversion mode.
>>
>> Similarly, make adjustments to ad4695_read_one_sample() so that timings
>> are respected, and clean up the function slightly in the process.
>>
>> Fixes: 6cc7e4bf2e08 ("iio: adc: ad4695: implement triggered buffer")
>> Co-developed-by: David Lechner <dlechner@baylibre.com>
>> Signed-off-by: David Lechner <dlechner@baylibre.com>
>> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
>> ---
> Applied to the fixes-togreg branch of iio.git. I'll rebase that
> and send out a pull shortly after rc1.
>
> The other two will have to wait for that to cycle around to be
> in the upstream for my togreg branch later in the cycle.
>
> Thanks,
>
> Jonathan
Thank you!

  reply	other threads:[~2024-11-25 20:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-13 20:52 [PATCH v2 0/3] iio: adc: ad4695: add new regmap callbacks, timing improvements Trevor Gamblin
2024-11-13 20:52 ` [PATCH v2 1/3] iio: adc: ad4695: fix buffered read, single sample timings Trevor Gamblin
2024-11-24 12:52   ` Jonathan Cameron
2024-11-25 20:32     ` Trevor Gamblin [this message]
2024-11-13 20:52 ` [PATCH v2 2/3] iio: adc: ad4695: make ad4695_exit_conversion_mode() more robust Trevor Gamblin
2025-01-18 17:12   ` Jonathan Cameron
2025-01-20  2:46     ` Trevor Gamblin
2024-11-13 20:53 ` [PATCH v2 3/3] iio: adc: ad4695: add custom regmap bus callbacks Trevor Gamblin
2024-11-13 20:58 ` [PATCH v2 0/3] iio: adc: ad4695: add new regmap callbacks, timing improvements David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23038c4b-9f9d-4a47-8c28-89893027322f@baylibre.com \
    --to=tgamblin@baylibre.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®