From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035452AbcIWQIh (ORCPT ); Fri, 23 Sep 2016 12:08:37 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:59101 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030326AbcIWQIf (ORCPT ); Fri, 23 Sep 2016 12:08:35 -0400 From: Arnd Bergmann To: Greg KH Cc: Baoyou Xie , mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@linaro.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] usb: xhci: mark xhci_unmap_td_bounce_buffer() static Date: Fri, 23 Sep 2016 18:02:53 +0200 Message-ID: <23060999.u64D1bMcgB@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160923150837.GC13933@kroah.com> References: <1474638373-27342-1-git-send-email-baoyou.xie@linaro.org> <20160923150837.GC13933@kroah.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:faNWq5Ge1wPuCxBJKEs+hfBuVV2t4sn64far+Qbae4hlIVcsisr yK9mDoTx8rPHRP0VwEVc5xiAzabr2a7OCNHkM4B6Y8Ya21npm158LlqgBONFvcT4DIF4S96 jyc0m+YZ7dc5zBhVIgyKwwPYd5FJ7q3uNP8SmmErRSsAMKBlabQ5oajoceHIiA52YFUxidT RJSNiA2rJpGwTrBxMMzgA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Npfbvhz13Vg=:ISFxHTRdIT76cCBlW6A+4v tciOQqki+qElG7mu9s7zxR6ixZ5dgswsLr+nMYQwUvPpxTXZQk7obO34sEiG3FGusa+90hxRm fLuMBG5cCaEtcIte+0GXNJwyiiw/gCSmouvIaR1wSFRGlX9KbHzdsrg1ylY74u/0qKp3Gdrqb rs8kJCSFmEUOQWTBLyIvYml/QUBDII6QsL1JJeHw4MQczm1VE5RV6FXJOVK1CybQ0G9XiqcSG jlvxtTp8ywF8KeW+YUmnfeYuFCw60hf1S6WJUec9SPBAyi+S2lqPh6GCY9H9bFh6vrl3rg8cm 4eUGSghujKH8WIdE+S5rJAjBw0jtrHfrSuRwzkVn2McoClPypyyRfmbkzbGDT0dZ5O4BETF/Z 3H/CQTjiMP0/xCZU2UIzMAFOl61LwNprv6YuC8chtmz9w7TqP/m6Wndn3n7Rno4uztVFLVzLQ 5aQ4xHnaUxLJkcYeLv7T1+FuKZrZJnsiYnULM3hbTmhdy/7KCcI55EyI8tXX76mF6anhgLH7Y WlNKNq26YGX52bE2pYecGwCLwIL9h/2RSt6aOYJj6m5C7MQmv8wNCr5mxBxX6g4vQVwxMnUm+ lsCvUnmpAX0U5Yg+xUF7iBm4FW4YO0Gu34eZOKM2Sm9ccCaQ8DkYjqrb2Z/cEKTMgstUx7sly yEhauHvrUa3GBnq27Jf4RD9q9/wVnugcm+C7I1yn+5qZXnnQfVcz4RJlXf1to+7LDqqJofoRd YhNzi5h7klooovni Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, September 23, 2016 5:08:37 PM CEST Greg KH wrote: > On Fri, Sep 23, 2016 at 09:46:13PM +0800, Baoyou Xie wrote: > > We get 1 warning when building kernel with W=1: > > drivers/usb/host/xhci-ring.c:608:6: warning: no previous prototype for 'xhci_unmap_td_bounce_buffer' [-Wmissing-prototypes] > > > > In fact, this function is only used in the file in which it is > > declared and don't need a declaration, but can be made static. > > so this patch marks this function with 'static'. > > Any reason you aren't using sparse for all of these 'static' functions > you are finding? It should be easier than using 'W=1'. It was my idea, I suggest to Baoyou to enable the warning standalone and fix all instances he finds, so we can eventually enable it by default for everyone. Once that is in place, we won't even need to use sparse any more. I suspect it will take a while before all of his patches are merged upstream, but IIRC he has sent almost all the ones needed for an arm "allmodconfig" build now, and a lot have been accepted. Arnd