mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <kkabe@vega.pgw.jp>
To: rostedt@goodmis.org
Cc: regressions@lists.linux.dev, bagasdotme@gmail.com,
	alexander.deucher@amd.com, christian.koenig@amd.com,
	Xinhui.Pan@amd.com, tglx@linutronix.de, mingo@redhat.com,
	bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com
Cc: linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	kkabe@vega.pgw.jp
Subject: Re: radeon.ko/i586: BUG: kernel NULL pointerdereference,address:00000004
Date: Sat, 22 Jul 2023 10:57:14 +0900	[thread overview]
Message-ID: <230722105714.M0104460@vega.pgw.jp> (raw)
In-Reply-To: Your message of "Mon, 17 Jul 2023 11:21:38 -0400". <20230717112138.1fd48cca@gandalf.local.home>

rostedt@goodmis.org sed in <20230717112138.1fd48cca@gandalf.local.home>

>> On Sat, 15 Jul 2023 11:39:11 +0900
>> <kkabe@vega.pgw.jp> wrote:
>> 
>> 
>> > Yes, this is puzzling. That's why I need other people's opinion on this.
>> > Does it matter the DUT is a slow machine (Pentium 120MHz)?
>> > 
>> 
>> Hmm, I wonder because the workqueue is running __init functions, could it
>> possibly be that it didn't finish before the end of boot, where it frees
>> all the functions? It shouldn't do that because there's code to make sure
>> it's done before it continues further.
>> 
>> But just in case something isn't working as planned, you could try this
>> patch to see if the bug goes away.
>> 
>> -- Steve
>> 
>> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
>> index 05c0024815bf..af5a40ef3be4 100644
>> --- a/kernel/trace/ftrace.c
>> +++ b/kernel/trace/ftrace.c
>> @@ -3771,13 +3771,13 @@ static int test_for_valid_rec(struct dyn_ftrace *rec)
>>  	return 1;
>>  }
>>  
>> -static struct workqueue_struct *ftrace_check_wq __initdata;
>> -static struct work_struct ftrace_check_work __initdata;
>> +static struct workqueue_struct *ftrace_check_wq;
>> +static struct work_struct ftrace_check_work;
>>  
>>  /*
>>   * Scan all the mcount/fentry entries to make sure they are valid.
>>   */
>> -static __init void ftrace_check_work_func(struct work_struct *work)
>> +static void ftrace_check_work_func(struct work_struct *work)
>>  {
>>  	struct ftrace_page *pg;
>>  	struct dyn_ftrace *rec;
>> 

Just in case I tried this patch too;
no banana, it panics (vblank->worker == NULL check fires)

-- 
kabe


  reply	other threads:[~2023-07-22  1:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14  2:50 Fwd: radeon.ko/i586: BUG: kernel NULL pointer dereference, address: 00000004 Bagas Sanjaya
2023-07-14  3:12 ` Steven Rostedt
2023-07-14  3:44   ` Linux regression tracking (Thorsten Leemhuis)
2023-07-14  5:32     ` radeon.ko/i586: BUG: kernel NULL pointer dereference, address:00000004 kkabe
2023-07-14  5:34     ` kkabe
2023-07-14 14:00       ` Steven Rostedt
2023-07-15  2:39         ` radeon.ko/i586: BUG: kernel NULL pointer dereference,address:00000004 kkabe
2023-07-17 15:21           ` Steven Rostedt
2023-07-22  1:57             ` kkabe [this message]
2023-07-17 15:36       ` radeon.ko/i586: BUG: kernel NULL pointer dereference, address:00000004 Steven Rostedt
2023-07-20 23:39         ` radeon.ko/i586: BUG: kernel NULL pointer dereference,address:00000004 kkabe
2023-07-22  2:30           ` kabe
2023-07-23 11:55             ` kkabe
2023-07-23 14:32               ` Steven Rostedt
2023-08-29 12:08                 ` Linux regression tracking (Thorsten Leemhuis)
2023-07-23 14:27             ` Steven Rostedt
2023-10-02 10:03 ` Fwd: radeon.ko/i586: BUG: kernel NULL pointer dereference, address: 00000004 Linux regression tracking #update (Thorsten Leemhuis)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=230722105714.M0104460@vega.pgw.jp \
    --to=kkabe@vega.pgw.jp \
    --cc=Xinhui.Pan@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=bagasdotme@gmail.com \
    --cc=bp@alien8.de \
    --cc=christian.koenig@amd.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=mingo@redhat.com \
    --cc=regressions@lists.linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®