From: Chanwoo Choi <cw00.choi@samsung.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, cwchoi00@gmail.com
Cc: lukasz.luba@arm.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, steven.price@arm.com,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v6 1/4] PM / devfreq: Register devfreq as a cooling device on demand
Date: Tue, 9 Mar 2021 19:08:19 +0900 [thread overview]
Message-ID: <2307329b-7a69-17e9-e1b2-8416b2dddfa2@samsung.com> (raw)
In-Reply-To: <20210308133041.10516-1-daniel.lezcano@linaro.org>
Hi,
On 3/8/21 10:30 PM, Daniel Lezcano wrote:
> Currently the default behavior is to manually having the devfreq
> backend to register themselves as a devfreq cooling device.
>
> Instead of adding the code in the drivers for the thermal cooling
> device registering, let's provide a flag in the devfreq's profile to
> tell the common devfreq code to register the newly created devfreq as
> a cooling device.
>
> Suggested-by: Chanwoo Choi <cwchoi00@gmail.com>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Reviewed-by: Steven Price <steven.price@arm.com>
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> ---
> V6:
> - Did one line string instead of multiline
> - Removed thermal.h header inclusion as it is in devfreq_cooling.h
> - Added forward declaration for thermal_cooling_device pointer in devfreq.h
> V5:
> - Changed subject prefix by: PM / devfreq
> V4:
> - Replaced thermal_cooling_device_unregister() by
> devfreq_cooling_unregister()
> V3:
> - Rebased on linux-pm branch without units.h
> - Set the cdev to NULL in case of error
> - Added description for the cdev field in the devfreq structure
> V2:
> - Added is_cooling_device boolean in profile structure
> - Register cooling device when the is_cooling_device boolean is set
> - Remove devfreq cooling device registration in the backend drivers
> V1:
> - Register devfreq as a cooling device unconditionnally
> ---
> drivers/devfreq/devfreq.c | 9 +++++++++
> include/linux/devfreq.h | 9 +++++++++
> 2 files changed, 18 insertions(+)
(snip)
Applied it. Thanks.
I made the pull request with immutable branch
for preventing the conflict on other git repo as following:
--
Best Regards,
Chanwoo Choi
Samsung Electronics
The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8:
Linux 5.12-rc1 (2021-02-28 16:05:19 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git immutable-devfreq-v5.13-rc1
for you to fetch changes up to 1224451bb6f938023dd7fa4e7ba43bfb185bc9e3:
PM / devfreq: Register devfreq as a cooling device on demand (2021-03-09 15:40:16 +0900)
----------------------------------------------------------------
Daniel Lezcano (1):
PM / devfreq: Register devfreq as a cooling device on demand
drivers/devfreq/devfreq.c | 9 +++++++++
include/linux/devfreq.h | 9 +++++++++
2 files changed, 18 insertions(+)
prev parent reply other threads:[~2021-03-09 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210308133406epcas1p241befcbf4638c0ebd477c0836040bf63@epcas1p2.samsung.com>
2021-03-08 13:30 ` Daniel Lezcano
2021-03-08 13:30 ` [PATCH v6 2/4] PM / devfreq: msm: Use devfreq cooling device registration Daniel Lezcano
2021-03-08 13:30 ` [PATCH v6 3/4] PM / devfreq: panfrost: " Daniel Lezcano
2021-03-08 13:30 ` [PATCH v6 4/4] PM / devfreq: lima: " Daniel Lezcano
2021-03-09 10:08 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2307329b-7a69-17e9-e1b2-8416b2dddfa2@samsung.com \
--to=cw00.choi@samsung.com \
--cc=cwchoi00@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®