From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.marcansoft.com (marcansoft.com [212.63.210.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 763D6155A5D; Fri, 1 Nov 2024 12:41:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.63.210.85 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730464880; cv=none; b=u4AHZetiZ02uIKgx+INJv6T/z5BiqCL8JMzr7anTXDAQcByDZ74A/6fkV/ERC0GugXthl4AUVHqErs0Ipkv+LxRlnLox6ZJYwSQfAMOyjio2mO2xyqjyq6OdPHMgmqsFxxPys+XDEr3kZ8xOq3Uh+AwmBKYDLoxypmodVjZS2SQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730464880; c=relaxed/simple; bh=1tyJN7tpj71GsXPgw1vXVuu1pL6JI3AXiNqruHLtMhI=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=sIQG6ja5OQ9HXwuD35DMBvjuafC8ILGiWX59fPav2/f5GZXh/cfk8m4V+qubnq239RfFEmE240uHZi9OKFY5okHa1anmBrs/EFs6p7SQ9HlObn21kZyLPNVtEyR5XB1yrrbiOMyaf98+FStOfX0L/9gBPECCgEkapnet9AC4m8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=marcan.st; spf=pass smtp.mailfrom=marcan.st; dkim=pass (2048-bit key) header.d=marcan.st header.i=@marcan.st header.b=Kv6tcbiC; arc=none smtp.client-ip=212.63.210.85 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=marcan.st Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marcan.st Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marcan.st header.i=@marcan.st header.b="Kv6tcbiC" Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id D8ED843470; Fri, 1 Nov 2024 12:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=marcan.st; s=default; t=1730464874; bh=1tyJN7tpj71GsXPgw1vXVuu1pL6JI3AXiNqruHLtMhI=; h=Date:Subject:To:References:From:In-Reply-To; b=Kv6tcbiCwdREWMYqnVNGYwJkOnH3T7Y4RD5xN+XUWZu1/YP70sS7x6O+xFjNisQOg vH2QXCmbnrR5W/JPhK9fFYxPHM1gMVzfx3YhFaiyefi+ErqO8klh97X12MaF1EJBTk ADwUMjkkbk9wFVAhp4koK3Go71UkQnZx7ZPZk/w50LDUCROrcp6DK8zAtc1rBZzkTa s24sfplZWNRjGJepQGKamyZxHnV/qLo4NA753pdPB9seElIU2nZsBM1qdpTguM7mve o927WZoRBCx+r6VeEHobSEhNHfp4SfpDhoQv+t98gIE5pic/zuV2nm/4SXpRJrH1hp gy7Ip2ha3Dy2w== Message-ID: <23074410-ffe2-4f68-a983-67cec430f68f@marcan.st> Date: Fri, 1 Nov 2024 21:41:13 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH asahi-soc/dt 00/10] Add PMGR nodes for Apple A7-A11 SoCs To: Nick Chan , Sven Peter , Alyssa Rosenzweig , Rob Herring , Krzysztof Kozlowski , Conor Dooley , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241029010526.42052-1-towinchenmi@gmail.com> From: Hector Martin Content-Language: en-US In-Reply-To: <20241029010526.42052-1-towinchenmi@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2024/10/29 10:03, Nick Chan wrote: > This series adds the PMGR nodes and all known power state subnodes for > Apple A7-A11 SoCs, along with the associated dt-bindings. > > --- > Nick Chan (10): > dt-bindings: arm: apple: apple,pmgr: Add A7-A11 compatibles > dt-bindings: arm: apple: apple,pmgr-pwrstate: Add A7-A11 compatibles > arm64: dts: apple: s5l8960x: Add PMGR node > arm64: dts: apple: t7000: Add PMGR node > arm64: dts: apple: t7001: Add PMGR node > arm64: dts: apple: s8000: Add PMGR nodes > arm64: dts: apple: s8001: Add PMGR nodes > arm64: dts: apple: t8010: Add PMGR nodes > arm64: dts: apple: t8011: Add PMGR nodes > arm64: dts: apple: t8015: Add PMGR nodes > > .../bindings/arm/apple/apple,pmgr.yaml | 5 + > .../bindings/power/apple,pmgr-pwrstate.yaml | 5 + > arch/arm64/boot/dts/apple/s5l8960x-5s.dtsi | 4 + > arch/arm64/boot/dts/apple/s5l8960x-air1.dtsi | 4 + > .../arm64/boot/dts/apple/s5l8960x-common.dtsi | 1 + > arch/arm64/boot/dts/apple/s5l8960x-mini2.dtsi | 4 + > arch/arm64/boot/dts/apple/s5l8960x-pmgr.dtsi | 610 ++++++++++++ > arch/arm64/boot/dts/apple/s5l8960x.dtsi | 13 + > .../arm64/boot/dts/apple/s800-0-3-common.dtsi | 1 + > arch/arm64/boot/dts/apple/s8000-pmgr.dtsi | 757 ++++++++++++++ > arch/arm64/boot/dts/apple/s8000.dtsi | 22 + > arch/arm64/boot/dts/apple/s8001-common.dtsi | 1 + > .../arm64/boot/dts/apple/s8001-j98a-j99a.dtsi | 26 + > arch/arm64/boot/dts/apple/s8001-j98a.dts | 1 + > arch/arm64/boot/dts/apple/s8001-j99a.dts | 1 + > arch/arm64/boot/dts/apple/s8001-pmgr.dtsi | 823 ++++++++++++++++ > arch/arm64/boot/dts/apple/s8001.dtsi | 22 + > arch/arm64/boot/dts/apple/s800x-6s.dtsi | 4 + > arch/arm64/boot/dts/apple/s800x-ipad5.dtsi | 4 + > arch/arm64/boot/dts/apple/s800x-se.dtsi | 4 + > arch/arm64/boot/dts/apple/t7000-6.dtsi | 4 + > arch/arm64/boot/dts/apple/t7000-handheld.dtsi | 4 + > arch/arm64/boot/dts/apple/t7000-j42d.dts | 1 + > arch/arm64/boot/dts/apple/t7000-mini4.dtsi | 4 + > arch/arm64/boot/dts/apple/t7000-n102.dts | 4 + > arch/arm64/boot/dts/apple/t7000-pmgr.dtsi | 641 ++++++++++++ > arch/arm64/boot/dts/apple/t7000.dtsi | 14 + > arch/arm64/boot/dts/apple/t7001-air2.dtsi | 1 + > arch/arm64/boot/dts/apple/t7001-pmgr.dtsi | 650 ++++++++++++ > arch/arm64/boot/dts/apple/t7001.dtsi | 13 + > arch/arm64/boot/dts/apple/t8010-7.dtsi | 4 + > arch/arm64/boot/dts/apple/t8010-common.dtsi | 1 + > arch/arm64/boot/dts/apple/t8010-ipad6.dtsi | 4 + > arch/arm64/boot/dts/apple/t8010-n112.dts | 4 + > arch/arm64/boot/dts/apple/t8010-pmgr.dtsi | 772 +++++++++++++++ > arch/arm64/boot/dts/apple/t8010.dtsi | 22 + > arch/arm64/boot/dts/apple/t8011-common.dtsi | 1 + > arch/arm64/boot/dts/apple/t8011-pmgr.dtsi | 807 +++++++++++++++ > arch/arm64/boot/dts/apple/t8011-pro2.dtsi | 8 + > arch/arm64/boot/dts/apple/t8011.dtsi | 22 + > arch/arm64/boot/dts/apple/t8015-common.dtsi | 1 + > arch/arm64/boot/dts/apple/t8015-pmgr.dtsi | 931 ++++++++++++++++++ > arch/arm64/boot/dts/apple/t8015.dtsi | 21 + > 43 files changed, 6246 insertions(+) > create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-pmgr.dtsi > create mode 100644 arch/arm64/boot/dts/apple/s8000-pmgr.dtsi > create mode 100644 arch/arm64/boot/dts/apple/s8001-j98a-j99a.dtsi > create mode 100644 arch/arm64/boot/dts/apple/s8001-pmgr.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t7000-pmgr.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t7001-pmgr.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t8010-pmgr.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t8011-pmgr.dtsi > create mode 100644 arch/arm64/boot/dts/apple/t8015-pmgr.dtsi > > > base-commit: 5c9de6f45db36b8a74c12e448cf9db87c97bf1e5 I'm not going to review the actual pmgr spam (I assume you did the usual thing and autogenerated it with the m1n1 scripts and then fixed some things up by hand, as we do), since really the only useful way to validate this is testing and I don't have these devices (nor am I familiar with any peculiarities). Skimming the rest of the changes it looks reasonable, so: Acked-by: Hector Martin Would be nice to get at least a cursory review from the DT folks, I'll apply to the SoC tree after that (please poke me via direct/non-PATCH email if I miss it, those go in a different inbox). - Hector