From: Keith Owens <kaos@ocs.com.au>
To: Benjamin LaHaise <bcrl@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFT] final cur of tr based current for -ac8
Date: Sun, 11 Nov 2001 09:54:48 +1100 [thread overview]
Message-ID: <23114.1005432888@ocs3.intra.ocs.com.au> (raw)
In-Reply-To: Your message of "Sat, 10 Nov 2001 17:33:31 CDT." <20011110173331.F17437@redhat.com>
On Sat, 10 Nov 2001 17:33:31 -0500,
Benjamin LaHaise <bcrl@redhat.com> wrote:
>diff -ur kernels/2.4/v2.4.13-ac8/arch/i386/kernel/nmi.c v2.4.13-ac8+tr.4/arch/i386/kernel/nmi.c
>--- kernels/2.4/v2.4.13-ac8/arch/i386/kernel/nmi.c Tue Nov 6 20:43:22 2001
>+++ v2.4.13-ac8+tr.4/arch/i386/kernel/nmi.c Sat Nov 10 14:00:33 2001
>@@ -264,7 +264,7 @@
> /*
> * NMI can interrupt page faults, use hard_get_current.
> */
>- int sum, cpu = hard_get_current()->processor;
>+ int sum, cpu = hard_smp_processor_id();
>
> sum = apic_timer_irqs[cpu];
I am still unhappy with that NMI code. The NMI handler can use generic
code including printk, the generic code will use the standard
get_current. Why does nmi.c not do set_current(hard_get_current());
next prev parent reply other threads:[~2001-11-10 22:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-10 19:14 Benjamin LaHaise
2001-11-10 20:33 ` John Levon
2001-11-10 22:33 ` Benjamin LaHaise
2001-11-10 22:54 ` Keith Owens [this message]
2001-11-11 0:39 ` Benjamin LaHaise
2001-11-11 1:48 ` John Levon
2001-11-11 10:58 ` Mike Galbraith
2001-11-12 0:01 ` Benjamin LaHaise
2001-11-12 2:21 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23114.1005432888@ocs3.intra.ocs.com.au \
--to=kaos@ocs.com.au \
--cc=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®