From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 703F7C7EE23 for ; Fri, 26 May 2023 05:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235290AbjEZFvJ (ORCPT ); Fri, 26 May 2023 01:51:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbjEZFvE (ORCPT ); Fri, 26 May 2023 01:51:04 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6F7FE7 for ; Thu, 25 May 2023 22:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685080216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/O7DGmGJR82LWQJp/HEBcwGojM1nXH9A+INA+Yqn88c=; b=XzUEyGs2KMERiexIHc5SxjPHlAIJh+SY5m9CTdjEIyfzIVT5WuYjDyUgmgKGhapvnxS1Sx yj/D5Dfv6Lhjl+lsprVx9DqENvP2jKGS5+7zGHNYP8a+zKOuc5cEze3Oi5W/x3vKdNNe8x UQQdy64XC2qktQYo9pKlMY822QS+kkQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-465-6hOkj_HvOiqRrtk900f66Q-1; Fri, 26 May 2023 01:50:13 -0400 X-MC-Unique: 6hOkj_HvOiqRrtk900f66Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9227A85A5A8; Fri, 26 May 2023 05:50:12 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.39.192.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id DA6072166B2B; Fri, 26 May 2023 05:50:09 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230525223953.225496-1-dhowells@redhat.com> <20230525223953.225496-3-dhowells@redhat.com> To: Linus Torvalds Cc: dhowells@redhat.com, Christoph Hellwig , David Hildenbrand , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Subject: Re: [RFC PATCH v2 2/3] mm: Provide a function to get an additional pin on a page MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <231194.1685080209.1@warthog.procyon.org.uk> Date: Fri, 26 May 2023 06:50:09 +0100 Message-ID: <231195.1685080209@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > > + if (page == ZERO_PAGE(0)) > > + return; > > You added that nice "is_zero_folio()", and then you did the above anyway.. Bah. Missed it because it was in a different patch. David