From: Marek Vasut <marek.vasut@mailbox.org>
To: Eduard Bostina <egbostina@gmail.com>,
daniel.baluta@nxp.com, simona.toaca@nxp.com,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Christoph Niedermaier <cniedermaier@dh-electronics.com>,
Marek Vasut <marex@denx.de>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, kernel@dh-electronics.com,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25
Date: Fri, 13 Mar 2026 17:44:52 +0100 [thread overview]
Message-ID: <2313c717-1729-48a2-8fc7-63b68ce0a0e6@mailbox.org> (raw)
In-Reply-To: <20260309181524.39423-1-egbostina@gmail.com>
On 3/9/26 7:15 PM, Eduard Bostina wrote:
> Currently, in order to configure IOMUXC_SAI2_TXC__GPIO4_IO25 a magic
> raw value is written in this register. This makes the code not obvious
> to read and modify.
>
> Use the MX8MP_SION symbolic macro instead of the magic value to improve
> code readability.
>
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
> index ef012e8365b1f..6ad824a7e07e0 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
> @@ -345,7 +345,7 @@ &pinctrl_dhcom_l
>
> pinctrl_ptn5150: ptn5150grp {
> fsl,pins = <
> - MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25 0x40000000
> + MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25 MX8MP_SION
Isn't the SION bit at the same bit offset at least since iMX5x ? Maybe
the MX8MP_* prefix isn't necessary ?
next prev parent reply other threads:[~2026-03-13 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 18:15 Eduard Bostina
2026-03-11 8:00 ` Daniel Baluta
2026-03-13 16:26 ` Frank Li
2026-03-13 16:44 ` Marek Vasut [this message]
2026-03-17 7:36 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2313c717-1729-48a2-8fc7-63b68ce0a0e6@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=Frank.Li@nxp.com \
--cc=cniedermaier@dh-electronics.com \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=egbostina@gmail.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@dh-electronics.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=simona.toaca@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®