mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: dirk.brandewie@gmail.com
Cc: linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org,
	Dirk Brandewie <dirk.j.brandewie@intel.com>
Subject: Re: [PATCH] cpufreq/intel_pstate: Fix calculation of current frequency
Date: Sat, 23 Mar 2013 01:14:35 +0100	[thread overview]
Message-ID: <2316804.ObH9JhORys@vostro.rjw.lan> (raw)
In-Reply-To: <1363974665-22049-1-git-send-email-dirk.brandewie@gmail.com>

On Friday, March 22, 2013 10:51:05 AM dirk.brandewie@gmail.com wrote:
> From: Dirk Brandewie <dirk.brandewie@gmail.com>
> 
> Use the correct pstate value to calculate the effective frequency.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=923942
> Reported-by: Satish Balay <balay@fastmail.fm>
> 
> Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>

Well, another quick fix for v3.9 I suppose?

May I please be sent CCs of such things to at least one of my addresses?

Rafael


> ---
>  drivers/cpufreq/intel_pstate.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index e84af66..ad72922 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -454,7 +454,7 @@ static inline void intel_pstate_calc_busy(struct cpudata *cpu,
>  					sample->idletime_us * 100,
>  					sample->duration_us);
>  	core_pct = div64_u64(sample->aperf * 100, sample->mperf);
> -	sample->freq = cpu->pstate.turbo_pstate * core_pct * 1000;
> +	sample->freq = cpu->pstate.max_pstate * core_pct * 1000;
>  
>  	sample->core_pct_busy = div_s64((sample->pstate_pct_busy * core_pct),
>  					100);
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

      reply	other threads:[~2013-03-23  0:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22 17:51 dirk.brandewie
2013-03-23  0:14 ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2316804.ObH9JhORys@vostro.rjw.lan \
    --to=rjw@sisk.pl \
    --cc=cpufreq@vger.kernel.org \
    --cc=dirk.brandewie@gmail.com \
    --cc=dirk.j.brandewie@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®