From: Keith Owens <kaos@ocs.com.au>
To: barryn@pobox.com (Barry K. Nathan)
Cc: linux-kernel@vger.kernel.org, Alan.Cox@linux.org
Subject: Re: [PATCH] 2.2.21-pre[34] pl2303.c non-modular compile fix
Date: Sun, 10 Mar 2002 12:31:49 +1100 [thread overview]
Message-ID: <23198.1015723909@ocs3.intra.ocs.com.au> (raw)
In-Reply-To: Your message of "Sat, 09 Mar 2002 05:19:10 -0800." <20020309131910.50C6D8959A@cx518206-b.irvn1.occa.home.com>
On Sat, 9 Mar 2002 05:19:10 -0800 (PST),
barryn@pobox.com (Barry K. Nathan) wrote:
>The pl2303 driver won't compile for me in Linux 2.2.21-pre3 or -pre4 if
>modules are disabled. This might not be the right fix, but it allows the
>driver to compile and work for me.
>
>-Barry K. Nathan <barryn@pobox.com>
>
>diff -ruN linux-2.2.21-pre3/drivers/usb/serial/pl2303.c linux-2.2.21-pre3-bknA-1/drivers/usb/serial/pl2303.c
>--- linux-2.2.21-pre3/drivers/usb/serial/pl2303.c Sun Mar 3 23:20:11 2002
>+++ linux-2.2.21-pre3-bknA-1/drivers/usb/serial/pl2303.c Sat Mar 9 04:45:08 2002
>@@ -818,7 +818,9 @@
> module_exit(pl2303_exit);
>
> MODULE_DESCRIPTION(DRIVER_DESC);
>+#ifdef CONFIG_MODULES
> MODULE_LICENSE("GPL");
>+#endif
>
> MODULE_PARM(debug, "i");
> MODULE_PARM_DESC(debug, "Debug enabled or not");
The correct patch is to module.h. MODULE_LICENSE was added to
2.2.21-pre* as a compatibility patch but was incomplete.
Index: 21-pre4.1/include/linux/module.h
--- 21-pre4.1/include/linux/module.h Thu, 03 Jan 2002 20:12:00 +1100 kaos (linux-2.2/F/51_module.h 1.1.7.2.3.2 644)
+++ 21-pre4.1(w)/include/linux/module.h Sun, 10 Mar 2002 12:29:09 +1100 kaos (linux-2.2/F/51_module.h 1.1.7.2.3.2 644)
@@ -181,6 +181,7 @@ const char __module_device[] __attribute
s string
*/
+/* Dummy macro for 2.2/2.4 compatibility */
#define MODULE_LICENSE(var)
#define MODULE_PARM(var,type) \
@@ -221,6 +222,7 @@ const char __module_using_checksums[] __
#define MODULE_AUTHOR(name)
#define MODULE_DESCRIPTION(desc)
#define MODULE_SUPPORTED_DEVICE(name)
+#define MODULE_LICENSE(var)
#define MODULE_PARM(var,type)
#define MODULE_PARM_DESC(var,desc)
#define THIS_MODULE NULL
prev parent reply other threads:[~2002-03-10 1:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-09 13:19 Barry K. Nathan
2002-03-10 1:31 ` Keith Owens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23198.1015723909@ocs3.intra.ocs.com.au \
--to=kaos@ocs.com.au \
--cc=Alan.Cox@linux.org \
--cc=barryn@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®