From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 397672E5D17 for ; Mon, 2 Feb 2026 10:02:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770026559; cv=none; b=hmHu/GPV5ccB4KryVEQ8kHeC0puAkI1Bg9JGxDWH6KE8hIE9CR8CYPw3oadvG/Zk9MHt6stUwIVMTgfe40kyx1sFpAMiBpRXfNb1KS+p3yp8C7xd7ZYzxQbdR6R+Y8fZjv9LjaJeFrZ6FcY3Fm9XrU9McmbgxMH37ZRjdqauzPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770026559; c=relaxed/simple; bh=JDSeexC0+JEFNCPV/nFoAtVuXSlVMpI6OdGFK/M9k6o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cJRgDt/k/tFKzw9h/dyEhHc9XscHymCSFn8VhDVfN0IscX4XCi9GRdN2g0PB2JbSezDYzjANJdH6vl+mZhi5moSOaKp8dUw5gEfXVEcg9W9MwVcIvaTfZCI1QzvGEH7oLRI+uHNf5dZHJgUs1EXTfBdRVDTdIRtfwc8xNs46SMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=G93WKS+A; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RelfcC7/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="G93WKS+A"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RelfcC7/" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61282XA6373372 for ; Mon, 2 Feb 2026 10:02:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jCAadpfJgT9dXEEIgywaUL4bC6A8NzSXrVe0HfftFtA=; b=G93WKS+AhHzdPX1h z3wSHCpza4u4nh5QC9t9MYGDXmNpzeM5weAn/OFUK4H3V5tY+YemhR/u+yxEJB+3 AE5hc8QSiJLHu1T8Augtvt6kAnkBkN1F3WafhhJ0W1JSpNCshs2ifiIqROdeci+w ut8N75TQ0zvBDOB5q3PPZjuklNMW7hamV8FwNslmuDEfyNuC/llZn7GzE2j4ng15 1HOit32Mf7BW8eSE+CnN0DXFCCAru4qeZJsVjABhvciolM9sGVZWeww1CVNOM5hy QL03uzyZC02tDlaehPzUkNEyZau+vAk0ypLGgno1aIMvrIagwPgA8zmfLWGXUl9Z mQb2YQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c1arecx1w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 10:02:36 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c6b48c08deso69185785a.1 for ; Mon, 02 Feb 2026 02:02:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770026555; x=1770631355; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jCAadpfJgT9dXEEIgywaUL4bC6A8NzSXrVe0HfftFtA=; b=RelfcC7/uNfcNbB0mQGG/KoTcKCOpdbUfFtSlkMlqDIBV4VHqt5R4lmpttq8PNz9P1 T3WIPDeRhLnUvuZ22W4qa6GqbZ0rUbDJMXs1cwDQ/sBiP1b+BcSJ3J7+8stwR55F9FD5 y8Ekt1UNyDx36CglR5TOyClUJu5XJ6CYry0FMzk5RamkBvrLYtW0FkDHQeP8ugX0/hJB 8T8UtRBkj2C25Bkv+V4/ICxBpeT76JC+YPB+C4BMH0hwKir7S/+izgnH9cLp4uAf4TVY mokOAjLpr7J7Aepln3wl76zrCLlEeXk9qjLicuqH86ZeJ1m9RZEa8PqhjFV8XpXNAUNr f1Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770026555; x=1770631355; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jCAadpfJgT9dXEEIgywaUL4bC6A8NzSXrVe0HfftFtA=; b=giTqDK10MeaJC8L/qQQQSsj5erCAvWuSwuokBYaaYSMcfuayHM/PBv+qkCqM2oAaxO AXcoip1sw4AxqDExJz2NUMvE3LaO16aJLs7mY79UlwSP+CAvcpQBbCaSObaUcHvbWxOE ict0k90IJ93VLGQz7HAUbjpkjWnyavpZbhSCLrzRPKxG47N6g6GGH4jENBjdtnTGgove 0OScXkCcWrooNbeysXjnuZIRWqKpRNMEBIPiQKUH8gLhYR0DwpKZmztTRBQfD0sXwY9B WAsZlEYxcBm2YK4L3nIKxSTjeVw4U4xF+jpi9xRXGTTPCPZCgVfC86aTEqhWS24oq7Ad yiBQ== X-Forwarded-Encrypted: i=1; AJvYcCU7WEk3iXKSrwiX6qhqldQlSMLJMSptw7HRtlkdv4RSpaRb6YPuP8j83Wj6Qm5vGBmDz0MNSCYxxNi7pA0=@vger.kernel.org X-Gm-Message-State: AOJu0YyzX5p56hMT6880eywWfCUW+COhj0qNXd62bcmRPF4hR4s9B+NN ayi6SAZ2xCJn8PMWkPqVezK4eZ89Jm9ezzEf8TXJbNFxq+rDydr0KDn6OqVE0lbU/S9sJQ8m2wS m1+PgSBG+TWil7yWvxi/w1rix1RlSLN8VgWWCkmnw9uTvsJOvtD87TlB3UC99QMDogb4= X-Gm-Gg: AZuq6aKCibYv4aYRhhQJZm4nOrySxNOq9eeHeUPT1X2hwAPz1pNqhxHAcK9qJtVne9j z9LYiUGBHQDfHTK6F6wgE1UUVCq1gCJkA+hove987n0eegowBCLzNk/krlwfn84cIQsvS6PN2YN Zp4mlpyO7+l9vt1p4S91R6QPwXY+fS/Sn90IyIdYLxWVbDTfYeabXFbg0xysZWnP9le4zHJcC3+ sPu/tq4RWNAe0NxCCkWC8ZKymN+I+1IEk3W8PNtwMufHXWzcCWPiqf7mIxVGrZK+DAfFHhay+x5 0rYrYFOKxWvYZXjekZclh8jBEkKSHzE4X5KRmLYE5aJIOwl5xjxqtzKW9DretQSc3D/5JRJvToV ep3eBBC2dT0UtI2KY5wN9/mIj/iNds10G3DXqtLGe4BVzH4u4Ugp8fHoT9M20FjBq7Lo= X-Received: by 2002:a05:620a:4009:b0:8c7:9e6:3a4e with SMTP id af79cd13be357-8c9eb10f0a2mr1033782985a.0.1770026555495; Mon, 02 Feb 2026 02:02:35 -0800 (PST) X-Received: by 2002:a05:620a:4009:b0:8c7:9e6:3a4e with SMTP id af79cd13be357-8c9eb10f0a2mr1033779985a.0.1770026555002; Mon, 02 Feb 2026 02:02:35 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf1c500bsm837501866b.54.2026.02.02.02.02.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Feb 2026 02:02:34 -0800 (PST) Message-ID: <231ae9c2-bb3b-430c-990c-deab6a8a0d0b@oss.qualcomm.com> Date: Mon, 2 Feb 2026 11:02:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/8] media: venus: scale MMCX power domain on SM8250 To: Dmitry Baryshkov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , Jonathan Marek , Ulf Hansson , "Rafael J. Wysocki" , Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Stanimir Varbanov , Abhinav Kumar , Hans Verkuil , Stefan Schmidt , Konrad Dybcio , Bryan O'Donoghue , Dikshita Agarwal Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab References: <20260201-iris-venus-fix-sm8250-v2-0-6f40d2605c89@oss.qualcomm.com> <20260201-iris-venus-fix-sm8250-v2-5-6f40d2605c89@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260201-iris-venus-fix-sm8250-v2-5-6f40d2605c89@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=NNfYOk6g c=1 sm=1 tr=0 ts=6980763c cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=v07b0KzaqYqj_yNn1HoA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: F2NsPJuGO9qnyYALBqUQdQcNpjjz7Qey X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDA4NSBTYWx0ZWRfX7m4Lxo+orEFW yXO502Dli6kcTgJf7AELblw+qMdl/VBWNp70Oogg7ckSwDavqAjTyLDDVkCRkREXiB5ZGjbQ+ZA 1yLWgkgEob8NE7e9i0U4DUKx3TAtopNFoFK3g5StvaNZImNBy9qww9PQnz8lMYMfvbrFO79ykZJ RJISZMz2Ro7GI6r/1EHy5+3F5WeAih0BGBb5izjdGttRhuZ7poAmE8tVt9OH7sCneNu6tdBYeX5 yUziDZtlfJXCgreXecjwCBeAaaW6TiVRrp+O4XhutylZzj9Na+DtYrBg5u88RvJgpPRwHJgeGhQ Uhw+fwzcBzDW7WLQv9ccM0sn7ocF01+3IatU0pkr9kb+UU6+1fqjZ2mKRcm4B9ufwRfNes5IJgZ PF/lFQ5f1gk7Cwprq8cpGsOJRy/n5YeKfMHXduMQ5UM8ZxFrVXGtrm+n2vcMYcB3GyawMKEpePV jY+dp4kpA2JxncLHy5A== X-Proofpoint-ORIG-GUID: F2NsPJuGO9qnyYALBqUQdQcNpjjz7Qey X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_03,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020085 On 2/1/26 11:49 AM, Dmitry Baryshkov wrote: > On SM8250 most of the video clocks are powered by the MMCX domain, while > the PLL it powered on by the MX domain. Extend the driver to support > scaling both power domains, while keeping compatibitility with the > existing DTs, which define only the MX domain. > > Fixes: 0aeabfa29a9c ("media: venus: core: add sm8250 DT compatible and resource data") > Signed-off-by: Dmitry Baryshkov > --- [...] > @@ -904,6 +904,12 @@ static int vcodec_domains_get(struct venus_core *core) > > /* Attach the power domain for setting performance state */ > ret = devm_pm_domain_attach_list(dev, &opp_pd_data, &core->opp_pmdomain); > + /* backwards compatibility for incomplete ABI SM8250 */ "eeeh", I'd rather error out since it can't guarantee to have its power fully on Konrad > + if (ret == -ENODEV && > + of_device_is_compatible(dev->of_node, "qcom,sm8250-venus")) { > + opp_pd_data.num_pd_names--; > + ret = devm_pm_domain_attach_list(dev, &opp_pd_data, &core->opp_pmdomain); > + } > if (ret < 0) > return ret; > >