From: Damien Le Moal <dlemoal@kernel.org>
To: hanyu001@208suo.com
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: pata_serverworks: "foo * bar" should be "foo *bar"
Date: Wed, 19 Jul 2023 18:43:41 +0900 [thread overview]
Message-ID: <231b4e0c-bc58-1f4f-ac26-30fc0036887f@kernel.org> (raw)
In-Reply-To: <fee05ac48ee8c60b0843a7d63260ba1d@208suo.com>
On 7/19/23 10:54, hanyu001@208suo.com wrote:
> This patch fixes the checkpatch.pl error:
>
> ./drivers/ata/pata_serverworks.c:305: ERROR: "foo * bar" should be "foo
> *bar"
>
> Signed-off-by: Yu Han <hanyu001@208suo.com>
Please stop sending patches like this. I will not apply such patch
unless you actually fix a bug or a compilation warning.
> ---
> drivers/ata/pata_serverworks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_serverworks.c
> b/drivers/ata/pata_serverworks.c
> index b348784..549ff24 100644
> --- a/drivers/ata/pata_serverworks.c
> +++ b/drivers/ata/pata_serverworks.c
> @@ -302,7 +302,7 @@ static int serverworks_fixup_csb(struct pci_dev *pdev)
>
> /* Third Channel Test */
> if (!(PCI_FUNC(pdev->devfn) & 1)) {
> - struct pci_dev *findev = NULL;
> + struct pci_dev * findev = NULL;
> u32 reg4c = 0;
> findev = pci_get_device(PCI_VENDOR_ID_SERVERWORKS,
> PCI_DEVICE_ID_SERVERWORKS_CSB5, NULL);
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2023-07-19 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_FAA8D636BA8369FE01896CB144F12E543905@qq.com>
2023-07-19 1:54 ` hanyu001
2023-07-19 9:43 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=231b4e0c-bc58-1f4f-ac26-30fc0036887f@kernel.org \
--to=dlemoal@kernel.org \
--cc=hanyu001@208suo.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome