From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07EE8C77B6C for ; Thu, 6 Apr 2023 11:03:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237438AbjDFLDy (ORCPT ); Thu, 6 Apr 2023 07:03:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237171AbjDFLDq (ORCPT ); Thu, 6 Apr 2023 07:03:46 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B41CB7AA5 for ; Thu, 6 Apr 2023 04:03:44 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-4fa3c48480fso1171357a12.2 for ; Thu, 06 Apr 2023 04:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680779023; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/NO3FWQS8N1l2fxmDI15auHW33rD9sbIu3IDLBnVfTw=; b=VDG+eQQFrtGBwGEtdzXnh5TBUo5s1Ndg0HB1t+2jaq83MbZRDXFMe5sk/XPNlxPFjF xZQlTvsGTWPEgmIK9NGfuTxh1eRtsIQnNWjZNHfdTu2cqNe26EpsKP7toxU4+sGZuW2a tH4g5/G5N1iYICnrp0BfDND23J0WaBPUud8OCttRjAlheZNHrV92xthbkzTR0lgycFxB +wlh77I4gOQGuNTiMgCVbGv4pPmt06+WPZ3oWSSxvwATxuofxB3NZ+m/9CeDz+o5NCxu 7u85Jn2WW6lbwOtOX1ychBtoqm7EqsuT/yHBl7Zo7MYyRmBeqayiZdZgWGAO7Pf2xoFD jtmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680779023; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/NO3FWQS8N1l2fxmDI15auHW33rD9sbIu3IDLBnVfTw=; b=ohF5Pfuoorq272GOvnpN79a+D69AAoa9JKzxNJRPNjthFATgtWUVxG5ejzm8EcfDDB 0+tWkC2G36M3/joK1dFgSmvW8V1VHOFDwOQBbGe8Gunc2LvbaiUQRmaDxN7XvC6VdhAh c+ADt9u2hUw+mzAf9pYxCwok9yXt+HJv3n1IWKUzSGj/lHTwb60+PTczyJrTU1WYxiTf veLGRH2NjxNb3pTqj7wXAUJyOBVnXXZZhuCg0J7nhQOxZbmnSyG90awFBjPRXlMtmYSh v+R2U+cpTavsDuz7wtQ/Yy50aRSAqICXfFiApzX98WnsbbZctP443bVpLlPMhtoFrEz3 bV0A== X-Gm-Message-State: AAQBX9eKO0+nPTQn/RPrl09WkjqhArVopk9FoD2pPgF3cJcp6kNV9+eU xKLe449rXR2uew9UttNcxtqV3A== X-Google-Smtp-Source: AKy350YN1i4WHE0/bYTXwdvBY2jGHFdUyTaKTtJyQDzKYEPj8ydS7ZBgrfFxJsRzARhuzBMRsGt30A== X-Received: by 2002:aa7:d292:0:b0:501:d4f9:3141 with SMTP id w18-20020aa7d292000000b00501d4f93141mr3959367edq.32.1680779023149; Thu, 06 Apr 2023 04:03:43 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:49e6:bb8c:a05b:c4ed? ([2a02:810d:15c0:828:49e6:bb8c:a05b:c4ed]) by smtp.gmail.com with ESMTPSA id e14-20020a50d4ce000000b00502b0b0d75csm606988edj.46.2023.04.06.04.03.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 04:03:42 -0700 (PDT) Message-ID: <231b72cd-352c-10a9-8695-a04f61e36568@linaro.org> Date: Thu, 6 Apr 2023 13:03:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 8/8] regulator: fan53555: Add support for RK860X Content-Language: en-US To: Cristian Ciocaltea , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Bjorn Andersson , Joseph Chen , Ezequiel Garcia Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@collabora.com References: <20230405194721.821536-1-cristian.ciocaltea@collabora.com> <20230405194721.821536-9-cristian.ciocaltea@collabora.com> <4115e47e-b64b-391a-493c-701c8de0565b@linaro.org> <53c803ce-2607-6fd1-485e-e19eb961fd08@collabora.com> From: Krzysztof Kozlowski In-Reply-To: <53c803ce-2607-6fd1-485e-e19eb961fd08@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/04/2023 12:08, Cristian Ciocaltea wrote: >>> + }, { >>> + .name = "rk8602", >>> + .driver_data = RK8602_VENDOR_ROCKCHIP >>> + }, { >>> + .name = "rk8603", >>> + .driver_data = RK8602_VENDOR_ROCKCHIP >> >> Why do you need this entry match data if it is the same as rk8602? > > This is consistent with the handling of syr827 and syr828: > > .name = "syr827", > .driver_data = FAN53555_VENDOR_SILERGY > }, { > .name = "syr828", > .driver_data = FAN53555_VENDOR_SILERGY Yeah, I understand, but it's not necessarily the pattern we want to continue. Unless these devices are not really compatible? Best regards, Krzysztof