From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E6CF322B76 for ; Mon, 29 Dec 2025 14:28:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767018524; cv=none; b=UJJv71Rv8krQCHta1FOtSMQKA4FiKoVAc4HdhhmBG0qQDjlAQGCg953bxioe+SlxmIuKrYrfGlKGnXtAq+pJk+ns/072uWwQMBm7c39YF1PlJPA69MQ3PKS2r0mRGhVICpljKClrmr0fhv86suzNwgzYFKZ+OVOMRBrqjtcU9Ho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767018524; c=relaxed/simple; bh=Iw66hMWpewyvaQ3um+UPEhcSBUCJIIRc9csLt31y/HI=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=RHxqJPxYmcOY4eiPqzNU2GfWqw+CyNyf6jiWi4WaMsXUrQFiP4CKCwnSTY9P6x9bD7ozOGA3+hsvZ9OonrCkBiwvIQ6Ax6cBqNr/XET0Qu7QB41u74qC6bEpYV6LqVJqV+g7lkdknev6wWlUPtX/Yr2HKnCwQSJfkjGir0w2fQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=YsoTUmbN; arc=none smtp.client-ip=212.227.15.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="YsoTUmbN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1767018510; x=1767623310; i=markus.elfring@web.de; bh=VSHKgqobROpoF/3iLsp6Y7ek9yEeFOEONKlgI9POyCo=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=YsoTUmbNQ6LeQePyVhqAoGPTYe/xWfbaeqrcTd0FpYxbWJTAyL/VKfeDWkp8sZKx VJDucNmJesY2QTCqF00ERl/NZDNeovzgoXPRXCB4/oI8iuFzgdJ0ic9WGpDR1WqFu hgwjUHJJFW9ZmjNIqPuVtU8x5/ZJqmMVKd1BXZU6mSxZoYMggh6MetUwp7ESJU/fJ csXMbxIuoDaQmTO1CqRFW5ytuZ9TmftglXTxSf2Et56y3xwGT6PR6Ta4Z6pIpvdWR T1SXTW4xmlngHGs818xYixKqTFoJhLjRmBKSUrKCbYPJ5Rp7t7U9sw+VJAGleAbSK M562n+nwMUPH8QopMA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.29] ([94.31.69.231]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M6091-1vXkSj3MOB-008Qml; Mon, 29 Dec 2025 15:28:30 +0100 Message-ID: <231f6f66-6a3d-4166-9e1a-ae0d5bd7583d@web.de> Date: Mon, 29 Dec 2025 15:28:27 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Haoxiang Li , Su Hui , linuxppc-dev@lists.ozlabs.org, Christophe Leroy , Dan Carpenter , Ioana Ciornei Cc: LKML References: <20251224104433.1585576-1-lihaoxiang@isrc.iscas.ac.cn> Subject: Re: [PATCH v2] bus: fsl-mc: fix an error handling in fsl_mc_device_add() Content-Language: en-GB, de-DE From: Markus Elfring In-Reply-To: <20251224104433.1585576-1-lihaoxiang@isrc.iscas.ac.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ZPCZNywyUWYoGUyLH+tdxaseQOGqT8/KnfouOXI6m3nMmA/gtV3 qs0W0mUT1WOPuzKwd9ktep87yagWFkLuDCL8/Tco8dj9pH/tBULR4EM4MWxEbnseIYSzPdg YXOudrGjyUd9hkmWCgRaMtLgL4TLn/H6EVsPkiOqCxMAbnsvqlVosUta8kY9sYnCjwPWUBK v8EWxIf9GHhCRwIPWKvdw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Dkg6Y8gGaTc=;w9TIIpPmqvKk+Rq6pVG6BPD8Alq KX3MAUo2WEnzEr/XDWR7dZPS0umUp+ZodpcAoTH0Z3tYx6+v9YJqUkl0122zlgobZIQQqnplK ksZ3kEr6T99XlNFNnW7Cb99blvp4E/lh4rBpNvaXLDwx/Wujn9PuPSFevDllLGayG0+OHoqzE LYfDBRXsBLxN5V3X/6WaufByCmzhhRh/upZDxp6HTJhUEx97CjDcNivGoxIvhZIAh1in3F97k ICbtvvEySXa2BMS6ISnqqkWYF5w775LpbFHq8cjdbuxCcud7c3/wpMfXeWGXWk0nM3FDc4gZV 59jViUbhWDR0U3+zFZsvTeGD1kW8wJTAuY+MVStF9klgrmkuLRV/1CxqzejOnhs0hOfUIQ4po Igs98IV1UoiGhviA3W+ToNfKHWPQ/smVh+Dr5Gh+5xCuCMezOmL3ALi237tsvKgNSQTXsdzfc CMf8clRaYSregahiJ61LWkUlxLtyV3LqATz27FflO6kG6oUy9NsTBlpKzzXsuPkgWjYp6wL18 c2F9tNK467wrZDKYMZPD4Y/7NioECGJLLueoGbCzf7SSZx0x+5Ng/zjTgTCsNAsMHCSrr76e+ BHkrMaf0HV7d/TO8c72VwekrxVFLxaTMPfzgklt9r//uscj5KSXLxQ6udj/zRDFRUqRwSQ4MP WC2BsYbqGcjAR2ai0/E0b9dcx8Jkc4pSnnTFymdCvnqv48MpEk0znwSbAQW5sbWRTBxe7S4rd JJRx6t/J24lCXQKQaHY7eZ6nGk8vZEl0X9Q4pZwvr/cGXU7FgFh0ULFUVQm4otmm08oDfwJmd 8oFukwuU86dcbT4KPTQzqMLZzl8A/9gvvXADSS5AhNFb3+pccBFosjS6ujG4YDAa+J4m7Af+u AJWJvkHmBK+vNONiQZSzHWjKN8irWf1Mp+V49b/KFD/8YE3rhWVT4KRyaHyFGwF1lKtvv6daQ xFRdh6uNqYdLuXJcpB6qh7eOywWiM5jasBMU70Sp8KlK9j8pQU6zeYaGCtnyoG+ymFUJn4A+P 3D97W/RcE27EO+t09g0VUvqHJtvVrr51Spz9bO6LTMgMl0scfCHXueqljyExbnAJ8iz59Z826 R5Dlpcal3DNvHbXxPrHWmfjS0m0ichJgo0M/Co/GVTHLD7s211nC4Kj7zYcyPdBAKrp88Gttf W0sxmBQ5+kEYMFCehEQGM/ZdK2+RWbIKpOWNgYrsQQNDZ44n0Lkp11FWCT8gW9XXcT53xkj0N a7TYYGgay6Q0j4Bt1PouISj3yJqFnWd2tWBFhgEXjpfJna99lTIHOy552dcSTxotFcchlNNer niG4bmwjmGq0qAvjfTghbzBHzfzyECdkp/wYy98jqJldE19WMmRbz8rY2SclMX59eOyNvdGta FGKRzknqYwg52JrzMEWjWGpDJ4rHWL7SO1387kt6tYffwK9RV07jUOMrzF6XqZtF+1uf3f/ue hAdz+dzN+B3E9v4PmhFz4ynowg7DOwWwhlexNQXPZ+pFNEcIMiHXeMoJpsYwH8Bo3UYmNRY5M FE71F1D1oMjABwK0W41bC5e28VYEJ3o657bjvn6AWtcIaq8RTAJw6A0jRTNs0QQdNHLb/X8+D kv8wWiEvzqHm88tNm4LIeLyLBF20baoGsWwoFPLy63dzLOn+Sr1r0pcYpHRSthsBDIXRMHIbN 4LF3SkjwGNXhglMi2sBirNNCsBfnof40wc4Y0rw8TTRxbLhkQUYNcr/yYdjW56UxaDISGT6rg GHdoTG7oNdySvzKkHQVPTglss9ToOp+wWzK+y4bBvz5K4Q4owBAAtPjpiJYkgQ03YgoKZtSql nf7EBlnTibP3uqsLAQglUlSA9wij/l7fAUNVTwC8JZezeeSHfghFUbhkhDK/mSlwmlUOJqHUp jyU7ujzxsBixdk2Jw3X/sCkCCwoH75S7ladrwvVt+A4VJHsRRbKkt8nDy6ikD1R0CBrYAtmKm Debk3Srt+f+wIHvqeqrUbO9Qtz5X3g8uAyQFhaCbi5bmFlMD3OKOn/XZW1RAP55Obm4LzSqbc gQQ71UiUHe3ow7pJ1I276nUGrNOfz6mXnEbnKnbi4TPOhzhXQMy46lljJXCzIzF6kELrqbi74 YOPxMI3MpDtQxcQZjVBi5VyPYd8WHv2UTvWzuRuPNACJfalXMLl3Qp1j8Rzsti4fLanduci03 koiu+OuqsaxCwO2uFe8UryvFZid7aSzrOm5RTB0SkR1u7NKGY3vFsUl4LQzkZUdLd4F/BuLhu EhlV6cy6d+Kz9ZUbnGBfP/nQ8RU5OOlHfq6VGYK712SG2ZeFhpxfhBVtgiu4oTO/FvvdL8bOf 8+3br1YUARQ7s3hjBeXgBPyJvuK26BA1VH+JcrJeXmPwcP+fN9pXe5GO7ET0SBsCHyF2rRfaS UmpAfJ2tyY5mkxz2UhMDY6TDcAz+aT36HKF0NiUdhsh96HefV9BZSs9DerljPAr4Spd2MvP45 tW4ZN/3I9fUwGVrdrVV44K7hndF6dLTmvN+tgJAHFCYtBHErjKioLk9ZDEVbfiwKYN5SBRegg 8pNLQ+14AkWBBUVdFTgiBVvHy7qsd5yoLhyEZJEu8uYtZYaY1kP/vBMyMWgJMuFF6AqRkjO+i tkYZn3+njJ6Ys8+ieDY3XftSuG3dSKWK6hHSE2FCgTo6uMllFGA/6Fso6jWDGg7JpjsfLcTaS IbATE1i4V2kXaI0qgu2HUBBpLRbgnrXPYfRLTY3RD6wWj083zGJxiK+uPTt/RR234xrd7Na1H 2JBd3L6wZQ/Wp0XFhnPGe+DaLJ2WWzgAiQPINlCw76JJFY6ZXztmma937b2FikPN4cFMictBY aiLvXUpJUxiIdL60pmEss8qo2RraTid8u8Dl8yFvsOHmq/pQCkUzZbg6iYvdazFzP5w4IzTnY 5x53exLlyOFX6mqLFdx30HK1BNZjqYm7COAMUajD5b4bT5ViSEP7hR4FFdtx3iru8xXu64ZhG ie3S2mKFcFR0kpBaBkrcQvYH6wV1kI//DRL40v4gq/XAWnoyFYvVCoWAxSbm1Q9yo+MN9YoxY V3Et2JCHr7ApSlcaGg3AUsk8qLLKjcODJimID73jMiQx0ItJc/6Ctf8bAtTkhxiD8F/AW78p0 IQ5L26+Nxb+HJAcqbkeA8L6Oz8WEXLFTOUVPx8fP4RLOLRP3a7fAh6tZi0FZKm1nS1LN2v7tr pgUHOs6GkMtSIsvqZ/ADMaKXGrPzGAHcplvUhPYP72j1vkU29TDHqVIr5q8/mvj6h2Qs9ajhE W0Ar201g8HMaDubNVdd7qBxiBSiLno11IrZQHrpqCiIuqYAbPklnXZ/FGhNsW/oYmCNEJ0+eq +Z4JWeCwcQeOk0TEM7dipUSw3NUn1Jwx7B0oS/QdTGVX3WJYU3PsYjMkID3b2QiImar1Dpnw7 hP23tEe2ZVU5fBujEWKZSse8eFk+TdQKyGD3xUEI+lYw4JflTbLcjnR8L+d5R3MYin5/iT2JL TqCES4MAgFRbidroYPEVmGj4kDzimVlX7AaGLz/87259D1Yg88jfgKHyJ2UYEGrw8gFf/uf/+ TBa2770Y83C4aLsffcaTQWINsRoFLfrPJUGbD1CER3Q+geDkW5YbyOx7cVTcZNKI6SC4gRklp cLjR7VQ/uhQd9hBSZYmtur0s34g9zvvimnXkUeeaJXHSLR8kH92RRYSJ4zdiuUBuwpwH0AKzO +j3b/v2IfwfnDWE2ahbmlGeJajN3FqfvFeMIRHQcyANLRQM7MMXjPtCGwEICaixVHgn2GYjxF fzKO9fDNRS28w+mLZn1wuAs+QTMK03qrMLjEDpFqC/jLsVZ2wRmFwsF6AyBFl4f+jbZxfbvwL TZ0f6qNbCfRt75mx1BXKLrZtryZFfBQvTkE+mZCvFrw1T8m2abglLaeLgawpDLShdUz3sGDD8 WbmgZwjtSCbHnLpNuCmtjVPBPSo7b4XcC/RkPWGIRIKcQ45vEXdpZn6PKb/Ug2SdwUnWYfca7 5V038i1k6uLsSUNbW42jTA+aNtPJhj+WV8/qKyoLhszwTobe8F0NGYyS3X86VNY1z8sKBdY5K LD9z0+vRWjEGxPl+lWggghi77tKb4/jc2LsD2ZnzN4DTmKD4iT9m+1wz5iGajBN65V9YqTog2 g7mQM1iMVxsXJv8kDcwcoaLyxvL7eLgG2ryE0iaWdNl4uHPqWbzpdOXAEnQQQCOMWIBcgkY7E Y15Dohjg3KsUmO7sC8d/GH5x69Z7GmbeVOjTX12y8Oexbry+XDYsw1wyG74zHvUDxFo+vYxwV pmO3GYcMVxd4FGLWDAmJZ8ALImwi/Q/vxwISt+b9ExaZQPJb9hugncDNvQ097X7dxhOa6t3ZU PYZOyqeUQpZpq/GV/HiYCKy1Xp4L65yE/DCHso9IGRWQvMatuU2nCxo5biJ4jTNMXGWXhyUt1 OmHZyHegEZH0fC5D+/FrvF0X3ry/07b0GPXtIi2Um5Z4KpPTt3j93GVP8koW7m/XvwYzFSI/K fqhLXy0egglJO9BTf3eLy6I/2SWRNFHllR+GcXhrdo7SZzUeu+Wor1NpGNejgwTU7LpCFsVBa A3LUH4aEdYTt/2YiO5MuGIk5YC1SGHQfEJKQIY9eTwrGtaMXIkpWg2oOvR4Js5WjIjX9V/wWS DPFyJlTVxmPW4/QLa8c9gO2VcahgekWRkR1aIP78K3TtP4rGq6uSxGNRdHboulnh6ZkUKdiHI O6gyOprANUrXD+ftig+skK3HRhog1C14Viza0yWjQYxQehNnoXAZdrSaz3Gl9kFPufobbkfLc 2tngAXsHYMahOH8LP+ucpsgUwB041YOBQO/1P8iq2PvQdhzPtFsIHJ5BPaD7QlA/+gpjIUEYO avIrZ7+Yw6FRm5vpdiuobe0JZuWIjai8vu6rhk1F5FgshTYyzVkBS0mzOAV869J57dle2j+qI KJAh1AWYkFpq4aRDlDWAKDvIXfdtWJpWgSZd6LwJZeu8k2DGpGi2Y1lKHEU3Tl3Qc4jir+JXW X2N7u7FyOoICy9AgDC06IEvw3vmA/zkPvXazv5MHqZaDncaKiHPAk6+DD3tBzoDqHyiAZNHg+ 4WGCzVg9ngiRH8fOfnlTKueyf+mSuTYGhm8I+/wl+R8DHxsaQMOwLtd84n5ynmwNtwVu4Bq32 SggZNw80B7MkOrsGli7ZfVmziqXi4nNtCKPOgq > If device_add() fails, call put_device() to drop the device > reference. Can the word wrapping become nicer? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/process/submitting-patches.rst?h=3Dv6.19-rc3#n659 > And put_device() triggers fsl_mc_device_release() > which does the free. Thus just return after call put_device(). How do you think about to add any tags (like =E2=80=9CFixes=E2=80=9D and = =E2=80=9CCc=E2=80=9D) accordingly? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/process/submitting-patches.rst?h=3Dv6.19-rc3#n145 Regards, Markus