From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C77A01A239A for ; Sat, 13 Jun 2026 07:24:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781335493; cv=none; b=JmzInXVbzQF1nFOOZboPBf1Nrh6jrky2uMDDF03dTMjrR7M60qaSKvXEHoP64bjOmOGSKkJmnEQEOWfw2iJrDa/fUb8eeavt6z+B+OnDfT83fDQVQkcD2Q8AsAcIOqtKgtrwyPG7PHhxjP48fi3bzHfONzEgxgLkb5nZjlff0OI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781335493; c=relaxed/simple; bh=QWp2dUhBuaMQ3R+EWT4864ChcX9S8coMOypBNk9GlkI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=shXAeBDroshJXt5Cy/REhFvQ+KU2SktFarKAM6PMHYTaIBj2mweT2gHmPiFht8jIwr3TFNmbbBAAVykRIC0DoG/kvh1prChtSX6rENRxXnkpeFAvw5ajqrcRK5vuDnGIgH33T6yOo/OSC7GO+gdKodOjMvQ0t6gSoITstyJhsIo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CJYje5qq; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=cFw3Cafn; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CJYje5qq"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="cFw3Cafn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781335489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8bYQFKiJorSd2L8GlFyWe7Glm246Aic2GK4MBG3QZzg=; b=CJYje5qqB7xy9QzR3QAIcbTSCGEaw0aHxWhUvuPskrBFoX4MmLza9G6GKCG90E6/cPS42a vGPy8lsYaWb2vBazbncioBUeS4NR/r7d/CECaghMWlwjNqQRGAY7d3XVd4CiL96Jm6JHc8 yYewOxGwDmSKkkqRoEfUsXv2KH0UKZw= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-8R4T423iPW6BjK2y4EC1Rg-1; Sat, 13 Jun 2026 03:24:48 -0400 X-MC-Unique: 8R4T423iPW6BjK2y4EC1Rg-1 X-Mimecast-MFC-AGG-ID: 8R4T423iPW6BjK2y4EC1Rg_1781335488 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8cce1cc8cb2so35728846d6.1 for ; Sat, 13 Jun 2026 00:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781335488; x=1781940288; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8bYQFKiJorSd2L8GlFyWe7Glm246Aic2GK4MBG3QZzg=; b=cFw3CafnG6dsxBkUNGgVb/PHhIyITHyADeu+v/P2A9lkLBKko3VTePIPUGFckGjsmF GcSQ023xA8V9Tw2acwNDarb+rKoRGrOFKMX31i2mCOq/ZuPZUhIJZILv2zuQKOKgviex UBqYmHXUCVL5fz2rGX2dfxf8xmguMzSHJFbnfsDkF6qb7Lp1hGAqpVrnb8fhfKYGeZMn kceZVBNMD+MuPZA/dR4Pe9KUR+Mc+URaem8UsZwkXGTFNMbtlxNktSTSkevyc4H6A+2m ykJ0A2GiYuesaAqCoJG6Vm5RHzUJCYm5/sDxc+LGiK+3KfEJ7gWWAD7grPQT+9GLcgpr Qt7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781335488; x=1781940288; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8bYQFKiJorSd2L8GlFyWe7Glm246Aic2GK4MBG3QZzg=; b=rJ5u++56qt8NaQDWF5NFOCsXTXx9mhHutP4+4pK4cmH2zzzGMhT86ugOS1+cOM7BPj o3zn/zjjaGKz4GcqQsTl1752z26cfJoYIcctdx4Jj2pFM7xlaYTex/z3/rL9ZLploZLa SKQcT1nIRBWI9VvO+Ng/wcu78rFhGXSJLcvf9/Aps+S5ICLYxz6i9N06Fgd8meh7wu6G 4MHstVKGlXLp9kPsAiZwcn+tRoJOuagcm8HauZRf6bY5iJMLeMIU1foWBrCELAS06UiY oSDPB90vz8eE+hpfDcLMwqaksCAlreQ4zxfeH6BabwfND1JdtgEG5A4AES3pZvKI7Zqj 58Gg== X-Forwarded-Encrypted: i=1; AFNElJ96Fp61copxjYN+R4rlUpO1xdKM8qe6DqJEfl2enDp3yx+KQTlGMxVunXD6/+AmW5F+3bPeUzk7YC1XIZA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw37iloTPnZZcQ1FiQ6UVK2P9jUm9v+1ViIGPlv1GZNZu4fgLRn 4VDBnLmikzZCNVX08cZfnYs5mmqkvtSxDdR1l6Kirtpy5l1/5bDrRxHIRtztppaYkmV+mxUpUcn BMiGtuIrr4iJ9GaZLzuy/hX6uVV/HfDI5xb/I8xKQI0Lp5wzulqXEVXTVVrqnbRP6p1sGTUz+gg == X-Gm-Gg: Acq92OFbFIwCrcfAiIuYC04kh5pqfbwy3kQdBR8EwLiU5+9cJAuIz8tIp2hZscMwx1a LifUYWF7rwkFfkeaC/OqCsMgKJk0vyCzyK/CXO5BJcbpoZVVLiS07m/nhs7GGPVvsUE5a51vg9m JUaIeIjU/pC385Lq5Iyvt7VIe+AA0yLx0box/tUu/MDA9/9zDGR0wFXj8WuiCkGp9z12HkoMLf9 UcER0irZrHGuSHBrxZSH6TaRCNfFWp6hhKfh9Riqvptv8a+xfZuFLO61jB/55smD/dp4CEp9yTu FjLPUfqGyuDtOxRJVK4I1BnVkd1FkEVnbWRi8ty56DXQXYU+uKIUHA8AG22PDc6g7E98AltCr0Z ffsiSqJrfFeyRXd6Oe5HxL172MBD8xTgfktry0va5Z6JDeKHBBp6CRP8= X-Received: by 2002:a05:6214:2a87:b0:8ca:165c:1a3c with SMTP id 6a1803df08f44-8d32c4ec56fmr96850756d6.10.1781335487787; Sat, 13 Jun 2026 00:24:47 -0700 (PDT) X-Received: by 2002:a05:6214:2a87:b0:8ca:165c:1a3c with SMTP id 6a1803df08f44-8d32c4ec56fmr96850496d6.10.1781335487287; Sat, 13 Jun 2026 00:24:47 -0700 (PDT) Received: from [192.168.88.32] ([150.228.25.72]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d304577d69sm44134626d6.29.2026.06.13.00.24.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Jun 2026 00:24:46 -0700 (PDT) Message-ID: <232383a4-d035-4a36-8edd-f78206ae191b@redhat.com> Date: Sat, 13 Jun 2026 09:24:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 2/2] net: lan743x: add support for RMII interface To: Simon Horman , thangaraj.s@microchip.com Cc: netdev@vger.kernel.org, bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, linux-kernel@vger.kernel.org References: <20260608100435.11214-3-thangaraj.s@microchip.com> <20260610162603.470355-2-horms@kernel.org> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260610162603.470355-2-horms@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/10/26 6:26 PM, Simon Horman wrote: > From: 'Simon Horman' > > This is an AI-generated review of your patch. The human sending this > email has considered the AI review valid, or at least plausible. > Full review at: https://sashiko.dev > --- > net: lan743x: add support for RMII interface > > This commit adds RMII interface support to the lan743x driver, wiring > up phy_interface selection, phylink supported_interfaces and MAC > capabilities, and enabling the RMII front-end via a new RMII_CTL > register write in lan743x_hardware_init(). > >> diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c >> index 0798f3f1f435..ad3f833c8d86 100644 >> --- a/drivers/net/ethernet/microchip/lan743x_main.c >> +++ b/drivers/net/ethernet/microchip/lan743x_main.c > > [ ... ] > >> @@ -3562,6 +3574,11 @@ static int lan743x_hardware_init(struct lan743x_adapter *adapter, >> sgmii_ctl |= SGMII_CTL_SGMII_POWER_DN_; >> } >> lan743x_csr_write(adapter, SGMII_CTL, sgmii_ctl); >> + if (adapter->is_rmii_en) { >> + rmii_ctl = lan743x_csr_read(adapter, RMII_CTL); >> + rmii_ctl |= RMII_CTL_RMII_ENABLE_; >> + lan743x_csr_write(adapter, RMII_CTL, rmii_ctl); >> + } > > [Medium] > Should the RMII_CTL programming mirror the symmetric pattern used for > SGMII_CTL just above it? > > The SGMII block sets or clears the enable/power-down bits in both > directions: > > sgmii_ctl = lan743x_csr_read(adapter, SGMII_CTL); > if (adapter->is_sgmii_en) { > sgmii_ctl |= SGMII_CTL_SGMII_ENABLE_; > sgmii_ctl &= ~SGMII_CTL_SGMII_POWER_DN_; > } else { > sgmii_ctl &= ~SGMII_CTL_SGMII_ENABLE_; > sgmii_ctl |= SGMII_CTL_SGMII_POWER_DN_; > } > lan743x_csr_write(adapter, SGMII_CTL, sgmii_ctl); > > The new RMII block only sets RMII_CTL_RMII_ENABLE_ when is_rmii_en is > true and never clears it on the other paths. > > If RMII_CTL_RMII_ENABLE_ is left set by a previous agent (for example, > a prior driver instance with a different strap, board firmware, or > state preserved across a warm reset where the driver itself sets > HW_CFG_RST_PROTECT_ during PM suspend, and pci11x1x_strap_get_status() > already accounts for cfg_load/HW_CFG_RST_PROTECT_), can the RMII > front-end remain enabled while the driver is configured for RGMII or > SGMII? > > Would adding an explicit clear in the !is_rmii_en path, mirroring the > SGMII handling, give the register a known state on every probe? I think this one is worth addressing, as it's reported by both sashikos and could break functionality in hard-to-debug scenarios. /P