From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1E0C3E49CF for ; Tue, 21 Jul 2026 16:23:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784651037; cv=none; b=lusrl9B/2WOTXKtssighSvh5CmK4ZJ16jrAMXuGZdA8BApzhq157NyxZSoSDyS6srzV4icXmOuebQZB87Ej2ZQIhFmdR8Tl98c6O0psZm7aeWfYf8RzeIDTl7LIiOHR5LLGNswP8OkEz4IaO3IiE1zHmsRTNnNruBOPhjil27Iw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784651037; c=relaxed/simple; bh=O4wVnhMMQ+uaPI8Kv6KE57gAovQRnopHFObePh6Lvsc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ffcN7+hQe3gkUNNvAtO9AmWjvPWEaHisd+c8dIKq0NSQ3Y/4u0bMtuL0+VLaQ9tdJQFDRYHitmSe8Hln5RfIFwRELP7kv7N6450lbfRyG/shmZFQ9wLd58lcxDSWpxdp7gcdJVWWbmWQrNScD1JzhUe5JuLo+Ij7KQ2vnUCTXGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XAz59KR6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GO8FkbJq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XAz59KR6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GO8FkbJq" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LDfs0B2071506 for ; Tue, 21 Jul 2026 16:23:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= y5oelxBd3zAgbhAM2GaaqJvi+znKFiv1xjAU+wGxpDo=; b=XAz59KR6aO4QANKv q0to/Q5mIShemq5pKb4ArAImK3AP6ctMJYGMICTTUp8Z0gcCdV4nVvBCnntjITkc 1Mmv9cbqx7igAHe5s1U5hP1WWB+KlSlWQE7Xg9SThyZEQf98KAzaiOfqi+bTJi9r OAEFAO26F2lQNyr8fFueoXqRi2VOq/BqdPPgtyiksmK0bf43wTGwmjp+amc1oLpx LqvCQHRnrvcQ7Gp6hqsfq/FjbuG8FC+CvuI7o5ACZ9vwb9l58QOy8P3YpCZE1dvR f1Ds9rYRXWaD4vpv3iRKaZltCLsQB6QAHYfggolT1uf1+AUQiBi+TypW+GIxRAIe rV285Q== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj6r3ht1m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 16:23:55 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c89704da8c7so16662199a12.0 for ; Tue, 21 Jul 2026 09:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784651034; x=1785255834; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=y5oelxBd3zAgbhAM2GaaqJvi+znKFiv1xjAU+wGxpDo=; b=GO8FkbJqaImuFq3dxmIIrO7vPv0Izh5s9LH/n8HlZNFAYHWrXWLEfXbEkEy3MkltaN F5PfaAwcjONN0zkd3DLRqk7oKqnNlMqRbTrFCvYhCQ6pwicCTWw9NrUKUNk3yNapW2Tw 8zcuhnaWvjUsgv+1j4QpeYqXztSRBPtCj8Hc5dC569Azb21Yovdei4Xrxo1rA15ul6PK bgSIhZqQqRMZ/rDc6Ui9ymDkX8NUldIobMq5GpKkeuUahgpOueOpHXZyUnmTZPEyl3Xr URTMsGXB5Y1MFBj6PAXHGr5UvEioU4c75M+35OEx1r5jOo16STePMD9c6QhEQkT/UTtC 1K1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784651034; x=1785255834; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=y5oelxBd3zAgbhAM2GaaqJvi+znKFiv1xjAU+wGxpDo=; b=brHBCk7LkqaN2MQrnj6ecFgg1eurIyhSqXoVdhXMN0t3w8nGmnmKjB9lBDA3QI5zdT 739KhrD4Wi4YupEpXrDpuSJrOuSW6QeoFdVVZpNr8s/uUe+ec3B34NyPRIc3VU6sG64Y OHRErSy9TFXteK3k/dymxOIMKOWzBPby3zLVcXpofQcy94Qs98ND2SiUPl8qvcNYCxrw SO/vQqd4Hot6ApCwkwj3/urmk3A7VZwEpo6NUfX+6IitqiegRjsiS2qAXPgLv7QMFClK 4UEsd6PKIs+dUrIZJ440XBbUs/I5TjoAi4EYRRmZKyThJYRBHrFqfaK2JEkEFp2Jt25c dyyA== X-Forwarded-Encrypted: i=1; AHgh+RrWTC7oXHkZ/fmnaICu9yLwlxlhpP4+O7i6F7rlAvj4lV3Lo3X4b+I2rV1CUHHtdPFh4Z4GRvbY+gD5YhU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1UpKtJv2tKkl1CuBO0ZUwY0MiyIEvPoY8x7ztKrS3Xcq9LSib LOoC/+DJjYouZR/ck9CUqD92TaurLkaJVDxwvlQSDhbyPziUGI2ei8/U9u5D0X3wlkHTDs4KXPH T68xCWlqs9L4Q/aJaOj6H6BIskOJANL6BCxE26tArPG6ex6Pp6C+swCdwBNbKI7CooRc= X-Gm-Gg: AfdE7clqpdbODMRgrcpXq+w7RF8Tm+uosn4xB/G0JJGjH7LwdQlr7F+lmK/Od4RAmeW n9pVeBb8ggxp61NV+5LKVNfX3J3g7VOEjOtqPJffvb+z8NFb7nAce9Gc/RRJUD2EqTkKyX3etDh 8CIA5taKaONBZdEEIiY5bLcfEL2oXcnoieC/dpAfAALxc/PkT7cRc+RM78eWKBxkHhd34F2TZKv 23BqGkkudbtGcNYpUuTOm3PoCdw4rbcubUY4A4SXOEOci/VvYqlD85zjTB4K3qX26qICH+gQP4K 0qyZ5FgSXWGZgCHnTQ7sYWP6zcRbf6zTY/IKToB06nvojp6iqa7qu7qKyMlg5U9TLtDrDo/hzA+ 35WWUcbdZ0SN5dY/ahUMCUH7Jw2Jg7kTO X-Received: by 2002:a05:6a21:2c11:b0:3c0:9c19:6592 with SMTP id adf61e73a8af0-3c3ada36c4fmr21416075637.76.1784651034386; Tue, 21 Jul 2026 09:23:54 -0700 (PDT) X-Received: by 2002:a05:6a21:2c11:b0:3c0:9c19:6592 with SMTP id adf61e73a8af0-3c3ada36c4fmr21416036637.76.1784651033819; Tue, 21 Jul 2026 09:23:53 -0700 (PDT) Received: from [10.206.103.83] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147e088d3fsm347633eec.25.2026.07.21.09.23.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 09:23:53 -0700 (PDT) Message-ID: <2323abe7-ecd3-4504-8790-ef1a2dacec8f@oss.qualcomm.com> Date: Tue, 21 Jul 2026 21:53:46 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 04/18] media: iris: Filter UBWC raw formats based on hardware capabilities To: Dmitry Baryshkov Cc: Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vishnu Reddy , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal References: <20260709-iris-ar50lt-v7-0-76af9dd4d1f6@oss.qualcomm.com> <20260709-iris-ar50lt-v7-4-76af9dd4d1f6@oss.qualcomm.com> <5d213d08-8e00-4e7e-93ae-ba05f22f09e7@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDE3MyBTYWx0ZWRfX4qi0E/7WeIFq rS9SIPwkCAPm2/OB8gFRiZnMoq5vpjmdOGqDz7MLrSlfASgxItBjLYDd3EE8U6V9zeTtti2vkDw 7QcTrknsX8TtA0ybUGL8H1qmDTF3lUYSXZDopLBZR0G45YomfyrmCMku9v+g4P4meCbluju9hlH 6dFhoY+Wv6wtbYEiVAsaIf4kfv3a9VlI7LfI6D0GkzPVlwgYds+ZzJ1MBA0hQWfFHJZGxTv+RU8 /Y6g4uoSu9XTZRzbJqEkeTS8X1gwBG6+gRuM8nIlneK2/Mvo+dJjiKIETHolFa5B7XnobUdTaAR S+jnTrn+z8g5n685r8lk8yM2qWTaWdlOXxcGrZLE4tM7JXCGgdRi1zH701Qq9zO/0KwofybYIi/ RpvOAOW/3zzzIvUDSoVWId+TnODGQvjXZtDVz+3eo010o4Cs58aW2R8cmFV+nT8wQKZzR71Jn5p 8T65paqsz+xZFf9x2rA== X-Proofpoint-ORIG-GUID: unCUmpLknuCB_G4jo9iR-Om9er_YZ-hP X-Proofpoint-GUID: unCUmpLknuCB_G4jo9iR-Om9er_YZ-hP X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDE3MyBTYWx0ZWRfX+/8j9NAykWUR mgbmLXmPkuGPOafizcm0TT44UMcQI6/F4kr8hvUu6ya1W2ImqgxA2DxULf2wmFwML1njzk9Z0u7 PsjK/fv0j1bzj642zNxLEAtI5azssio= X-Authority-Analysis: v=2.4 cv=SIRykuvH c=1 sm=1 tr=0 ts=6a5f9d1b cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=fu1g7sk19LlnXAIAUm0A:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_03,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015 suspectscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210173 On 7/21/2026 8:34 PM, Dmitry Baryshkov wrote: > On Tue, 21 Jul 2026 at 17:08, Vikash Garodia > wrote: >> >> >> On 7/9/2026 7:11 PM, Dmitry Baryshkov wrote: >>> From: Dikshita Agarwal >>> >>> The raw formats supported by Iris were previously advertised >>> unconditionally, assuming UBWC support on all platforms. However, some >>> platforms do not support UBWC which results in incorrect format >>> capability exposure. >>> >>> Use the UBWC configuration provided by the platform to dynamically >>> filter raw formats at runtime. If UBWC is not supported, UBWC-based >>> formats are omitted from the advertised capability list, while linear >>> formats remain available. >>> >>> Signed-off-by: Dikshita Agarwal >>> Signed-off-by: Dmitry Baryshkov >>> --- >>> drivers/media/platform/qcom/iris/iris_vdec.c | 26 ++++++++++++++++++++++---- >>> drivers/media/platform/qcom/iris/iris_venc.c | 25 +++++++++++++++++++++---- >>> 2 files changed, 43 insertions(+), 8 deletions(-) >>> >>> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/media/platform/qcom/iris/iris_vdec.c >>> index 4c8bc7aac135..9fee5f28097d 100644 >>> --- a/drivers/media/platform/qcom/iris/iris_vdec.c >>> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c >>> @@ -3,6 +3,7 @@ >>> * Copyright (c) 2022-2024 Qualcomm Innovation Center, Inc. All rights reserved. >>> */ >>> >>> +#include >>> #include >>> #include >>> >>> @@ -69,8 +70,14 @@ static const u32 iris_vdec_formats_cap[] = { >>> V4L2_PIX_FMT_QC10C, >>> }; >>> >>> +static const u32 iris_vdec_formats_noubwc_cap[] = { >>> + V4L2_PIX_FMT_NV12, >>> + V4L2_PIX_FMT_P010, >>> +}; >>> + >>> static bool check_format(struct iris_inst *inst, u32 pixfmt, u32 type) >>> { >>> + const struct qcom_ubwc_cfg_data *ubwc = inst->core->ubwc_cfg; >>> unsigned int size, i; >>> const u32 *fmt; >>> >>> @@ -80,8 +87,13 @@ static bool check_format(struct iris_inst *inst, u32 pixfmt, u32 type) >>> size = inst->core->iris_platform_data->inst_iris_fmts_size; >>> break; >>> case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE: >>> - fmt = iris_vdec_formats_cap; >>> - size = ARRAY_SIZE(iris_vdec_formats_cap); >>> + if (ubwc->ubwc_enc_version) { >> >> Do you see a possibility that ubwc is enabled for a SOC while VPU >> hardware does not support UBWC. IP document for qcom,qcm2290 lists some >> UBWC configuration, while VPU does not support UBWC. Not sure at this >> point if other blocks indeed support UBWC for qcom,qcm2290. > > No, QCM2290 doesn't really support UBWC between the IP cores (as such > it has ubwc_enc_version = 0). > Currently the database defines a least common denominator for all IP > cores. If we ever get to a point where we want to define UBWC params > per the core, we will need to restructure the database. > Ack.