From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 040B23DCDB9 for ; Wed, 13 May 2026 08:32:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778661163; cv=none; b=JsFYEMiz9m26EV6v+iY2WY9ju+KeC2ZzkF/WHUW4IwpqWk6PFkpmXN/drZPoRlqaAV/8XkL5pbJpcCrcOkluZpvlfhcsKvnBt+W3NRdArgQCe0T+0homktpNCiw65Df8V5zmX1uvabgGeHH9LYxsRY96A9FjNQ7SJCugSVYX1Wo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778661163; c=relaxed/simple; bh=J/Dv0UWc5fFWPIOe7gZzQ5uITifiJBtRxJc1gZyIhEM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=G3HYDUQB1ZgvogjwMClYAyhoxu2iYatUi0C21YoKTOnr7OGPQwVv6SWYe4cN1AgOEEhvl2pWoJsVlcX8Tqjk90bc4yNaNlE+93rIg+qpkgLzU30a3N9lv8W3Jc4qVHPUs4nmSLfxQtcUgUa9UMBxZMtjURKqhG6eunstniv6QyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=S2wroal3; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Lu2x/6lo; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S2wroal3"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Lu2x/6lo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778661148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=I/V6QNGxjpN2tsT3RkBCdiMepHJdTDp41wVfYJmBFyU=; b=S2wroal3Z5LfRbKXaa4vVkUW9YlZDLX7oTwXOs4QYENrXYdNPyVfprUn7ZDs7baxMv+l5g xdryptwmmFGPV82+ZBrTUd6j9OFw2msdXrKcJBSWxa3bJP6doYr6XxYuacss5aRHKae6+y Fla9NSY2UoWrtN4/Z4FulnNULt6ryMg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-NGhKjN7AP96ibhiDVAdxPQ-1; Wed, 13 May 2026 04:32:26 -0400 X-MC-Unique: NGhKjN7AP96ibhiDVAdxPQ-1 X-Mimecast-MFC-AGG-ID: NGhKjN7AP96ibhiDVAdxPQ_1778661145 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48fd3449e6dso96675e9.3 for ; Wed, 13 May 2026 01:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778661145; x=1779265945; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=I/V6QNGxjpN2tsT3RkBCdiMepHJdTDp41wVfYJmBFyU=; b=Lu2x/6lotTntfn6a7WRm0m1VYm1nONSR6aCkF31Ta20A5eaiVRTEIMMAviv3eD7KBF 7ZwSggakx3YtdjogWyLVIxqq//GdIpHN15UMJOmfKPvM3nKW6GXyzsMymhCdcNoFIARn bpR6+q7MU0+cN6t/jYogpVjxhA780eT9/76Q9kqEAJhyp9SvOLHy9Fo5VxfC4y7Yumv6 8quAOQDYU21/4RS+dm3LmIkvC56u3kzlC60XdYGJ0H01447uLjJ9ZWz3goFGapY9cf+b lIZuOurPyHSTwO4g0rWbsZyoXkZiaFKxEXDWZdykI0c7cYs20P2efJMBaFPGrEk0F68s gggw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778661145; x=1779265945; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I/V6QNGxjpN2tsT3RkBCdiMepHJdTDp41wVfYJmBFyU=; b=VRW6tog2YLEBS+uXlTU+2Y1DxrlRJLCGmzgqbH3+ntLQwvdv9RV4CMBFXocL0tNsUJ Ea0r+UPJ7pIwMFXH44BD4qU9V17S9mHRjrQlApwmsyHYV6tjjPDl47snpTDtGFxH9uF0 upaiO/H25HjuZ8VNVV46lNDl/ncOWjRb4WESXP+APLcLZQ/FAY98lGueYwRnU2GlsxJV OCJm0WPNlRFzMpUMrRkKA2O9RsdguI7dlBxd6kvHdjDehQ4RX8sJyXPxuA4nVu7A+kHv nf4y6Vxee5mgYWcEzBDEv+9GJBHTBgupq3BY9hfdK2q4Y4XA/hFEmkdconqDzYToOZXC hfLQ== X-Forwarded-Encrypted: i=1; AFNElJ+kOawfP3/5Ci1HT88uoU51PXWIr3pt24euXd9vCggzHYqZohxwk0tSQyPtpRoTKff/n3CjDi44KFiplKM=@vger.kernel.org X-Gm-Message-State: AOJu0YyV7DOBxUVOZISP8DcwFatYt1BCwKXsre4RcE2Ey4zQUjolrhAf ROLz2/Rd0c9gWFhx11GJxjcyyTE2Qb3TBVQEB357K4Gqu9cA939leLEKcvrLc21B81xGmSyRjrZ 497xE5RphD5/YLyNkj+xoHHNJ7V5ibN13XhvIoCrLk8Q3kBM/6HFppctJQIpkX5KdYTxbKqSpSI MJ X-Gm-Gg: Acq92OFLuz7+Yqt8Z+BtZ5LyD+iGLUPQFLwZ7jQC4ZZK4gAeLhnEPXk45VrsrOO21nH dgyyA1iSnydwqT18t1UQnZxgjkvGZ0VHXE163s514AZg4WAXGMjzMq1wqqj7wFpMFaNRguxv2iE nFbooP+VwCIEL+xD47i4Y8fo/jFt4yOfIkeLLgUXA4W9wkDpnx2dLB2z2mRIWBNZQ0Puv/O+wjs CLowUy9iotRTB9vVfh9yd7bG2Cyz/KoUAuiIIblmE8eu+Xj50bF4QPAGzRwMP6N2HKKpGVN2v6G Lr6P2guvG7htzKMXFxkOBWSzZinfUxwi3BzCmJ/YvXaX9e0rF3mLwAN5I4e4OhZa7ISF6z8HEk4 4b3yrH0dqbSVkoZhLEY8Dx3TtdsYAGTuL8j1V5LbOVZpNrRrWGicYU/MSX1DWWO+vNpD4Al+5TE ts3kQg+12tZpxwTcI= X-Received: by 2002:a05:600c:4e02:b0:48a:5363:8cac with SMTP id 5b1f17b1804b1-48fcea064e2mr22693995e9.22.1778661145401; Wed, 13 May 2026 01:32:25 -0700 (PDT) X-Received: by 2002:a05:600c:4e02:b0:48a:5363:8cac with SMTP id 5b1f17b1804b1-48fcea064e2mr22693375e9.22.1778661144870; Wed, 13 May 2026 01:32:24 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45491bae13csm37531142f8f.29.2026.05.13.01.32.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 01:32:24 -0700 (PDT) Message-ID: <232713a9967e6ad20352f47e7220f6f6c334a97b.camel@redhat.com> Subject: Re: [RFC PATCH v2 03/10] selftests/verification: fix verificationtest-ktap for out-of-tree execution From: Gabriele Monaco To: wen.yang@linux.dev Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Steven Rostedt Date: Wed, 13 May 2026 10:32:22 +0200 In-Reply-To: <7368ee25b1b45c92beb14c05be366b71da585ca4.1778522945.git.wen.yang@linux.dev> References: <7368ee25b1b45c92beb14c05be366b71da585ca4.1778522945.git.wen.yang@linux.dev> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.1 (3.60.1-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-05-12 at 02:24 +0800, wen.yang@linux.dev wrote: > From: Wen Yang >=20 > verificationtest-ktap used a CWD-relative path (../ftrace/ftracetest) > and a relative argument (../verification) for --rv.=C2=A0 This works when > the shell changes into the verification directory first, but breaks > when the script is invoked directly - e.g. by the kselftest runner or > vng - because the working directory is the kernel source root, not the > script's own directory. >=20 > Fix this by computing the script's directory from $0 with cd/dirname/pwd > and using absolute paths for both the ftracetest invocation and the --rv > argument.=C2=A0 Also export the directory to PATH so that check_requires = in > the ftracetest framework can locate helper binaries. >=20 > Signed-off-by: Wen Yang Just out of curiosity, how do you run the selftests? Are you calling the script directly just to run /some/ of them? The officially supported way is through make [1]: make -C tools/testing/selftests TARGETS=3Dverification run_tests (though I find it faster to omit TARGETS and just do make -C tools/testing/selftests/verification). Calling with make should set up all paths as needed. > --- > =C2=A0tools/testing/selftests/verification/verificationtest-ktap | 4 +++- > =C2=A01 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/tools/testing/selftests/verification/verificationtest-ktap > b/tools/testing/selftests/verification/verificationtest-ktap > index 18f7fe324e2f..456b8578a307 100755 > --- a/tools/testing/selftests/verification/verificationtest-ktap > +++ b/tools/testing/selftests/verification/verificationtest-ktap > @@ -5,4 +5,6 @@ > =C2=A0# > =C2=A0# Copyright (C) Arm Ltd., 2023 > =C2=A0 > -../ftrace/ftracetest -K -v --rv ../verification > +dir=3D$(cd "$(dirname "$0")" && pwd) > +export PATH=3D"$dir:$PATH" Then if you really really need to call it directly, do you need to override PATH? And isn't it clearer to do: dir=3D$(realpath "$(dirname "$0")") Thanks, Gabriele [1] - https://www.kernel.org/doc/html/latest/dev-tools/kselftest.html > +"$dir/../ftrace/ftracetest" -K -v --rv "$dir"