From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4677E3BE652 for ; Wed, 8 Jul 2026 16:24:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783527862; cv=none; b=o9XmlHf9lx60rQ3yzNctm+jFIofisDMbF5Vx6AUGPFlRhLk6PZkkvyNFuVVnKHykvNgF1EYUYEdEwxhIu06SY7Ou70KQgbFmfW/lD8z72LhSs8BbxSt+98vQLs46jwFXB/irlJJCzoDUAu1/tHMoPmcQXB6KN3D7ZoD+oEi/hEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783527862; c=relaxed/simple; bh=F057RQ5aU71gMPjItc9XsyvIIqOxx6TbKks5RjUAYN4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FfNPCNwOtZQkf9EARCwggyUgNuOJeRtgGBO8hGnpcPtlTM2HXlP69Dq7V83iuA5eFFyNRIW/fwEzQMWuGH/AviyE3U/BKbPBIQjY0xeyV+i7D+nw7J9WNFlgVDthoUPKXO4FO3T7oQ1tACq/MFF7U5SetTng+1+P/cCpWwa/kkk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=CpLHeo1z; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="CpLHeo1z" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-493ba701891so6283085e9.3 for ; Wed, 08 Jul 2026 09:24:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1783527860; x=1784132660; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gT1mEc3Dr8A1jUKsh6HVw6wMy3cuHVm/hAqGsXnWygs=; b=CpLHeo1zxOsKOy832uIOR1Fbf3ua+7MU1QBvoaJ8e/S1+/2BJePyCFvmv+3YrUgUfP szBEACYoPHj7XVAWAo+fqPr6/Kq+aTEAJBDfa4lUg88g0jlUcRJQde9ut0wSkl6o8R0T QKtuZVjHXKbdAlWQnIpS+tLHVc4WkCKLMRCpfm2fF6LA1Utmr7gcQ+duLZ/Ip7ZR8+9K nr1TIZJaOwbzH7bBUa24ujvD6aM6gUTCOtItuhond6iG7TIJzS6IflzuizgJJs8t859E 6/oKunO8LY/Jb5B6gl65pMiY1Q1BnuhiZG54r29gQvrbVWTn2Gu/fhmhykeg+ztfeAzN /s0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783527860; x=1784132660; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gT1mEc3Dr8A1jUKsh6HVw6wMy3cuHVm/hAqGsXnWygs=; b=rNbvn1OdQ+CYrXOSwEEpGDY5SLbhPTH++vRydoglsnflILqL5xAoGw6NjeyGvLnucL PZ2iiXUE0CMhmAU3QrAkw6YNcSMsYlx+P3G023XZfmxsjDPl4Vdant3PrnmSAVmFiZOt 6aq7SCnDVbYFM4T3lNP3HCWTM8Pz+PipzdGd6R1hPzqSvSfhjvRL98AJEnHzMORVG+PV 7VwsoYb4kuy5aJcyMGa6I7fvIjOK/b5baYDfwv+qIrWIqLJV7aodUvOm8ocpuKr0G8hJ J2hyjEVKz0GISHBqKWEfyfG7sSHdsHna/UH2Updcs0lA7C3Rmm9fpXLXZQSE1VhZhloQ dfJQ== X-Forwarded-Encrypted: i=1; AHgh+RpHKsy7m0qSg/tWhuRBgZTbBpZacazzPXAyYQO2Bixr9kxxQd7pU71EIJP+iFRmWGwGi/CchvYU+WEujnU=@vger.kernel.org X-Gm-Message-State: AOJu0YzIAhjiaPmm3i+uQpIch5hUDnG+XoFah+e86zR8+nNL6glN+CHa DXoi/2wpRHA/BSAZ9fCEAHw3u4Y35/qwy6AkalU40AgLWicheds/AKEaFrceq92sQPsL2Dh/Spb xsNV1 X-Gm-Gg: AfdE7clNnYsKQpvE/bUI6mcfYjIrh5rp1IgDwJKQIT1Tp3qO/o1TzkK+fU4TCkO/wVF auJuBGXBT3pdUoB+HFRdOFGb1EylobZOxGol5fgoOKvE82ijKMKOAAnS1EnMquWEMYcIfGYAS1C hwJchmkF6qSFFdWa6uRJRGc1E4i1GnySpcz58wHADHAGlsILwEgX0DJvLdODk6UzEq2WaFL9t05 zEOtMv8r77c73a4MeEojhXw4QZgdwiKPjuP5REpPLXP33mN9g446F3CsWeFUAtkVGkz+a/U9ytP zkunZPmiZXVWoOJlvo8wrk9s8BK3/4+WduDk25extE5BJf8URVIio07FeVp+GsM56YNiHn4PIMI XMgvCct0UH8i+/eKAa0EegeJ8+OwmJFnsLYAo2/XFs8JYceQMIwDu3uIIQPQUnrCYx5pDSlX+Ru uzs0ze81JofKxI+9JxU2IslR7L5lN8Hcg= X-Received: by 2002:a05:600c:3111:b0:493:aab3:c09c with SMTP id 5b1f17b1804b1-493e6a4a8b1mr33097185e9.28.1783527859686; Wed, 08 Jul 2026 09:24:19 -0700 (PDT) Received: from [10.128.60.8] ([81.92.17.128]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493e0f4e3afsm172344925e9.7.2026.07.08.09.24.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 09:24:19 -0700 (PDT) Message-ID: <232723a0-328f-4929-9525-d5f00d498636@suse.com> Date: Wed, 8 Jul 2026 18:24:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] usb: gadget: function: rndis: add length check to response query To: Griffin Kroah-Hartman , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260708-usb-gadget-rndis-v1-0-e77e026dcc6a@kroah.com> <20260708-usb-gadget-rndis-v1-1-e77e026dcc6a@kroah.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: <20260708-usb-gadget-rndis-v1-1-e77e026dcc6a@kroah.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 08.07.26 13:08, Griffin Kroah-Hartman wrote: > @@ -598,6 +599,13 @@ static int rndis_query_response(struct rndis_params *params, > if (!params->dev) > return -ENOTSUPP; > > + BufLength = le32_to_cpu(buf->InformationBufferLength); > + BufOffset = le32_to_cpu(buf->InformationBufferOffset); > + if ((BufLength > RNDIS_MAX_TOTAL_SIZE) || > + (BufOffset > RNDIS_MAX_TOTAL_SIZE) || > + (BufOffset + 8 >= RNDIS_MAX_TOTAL_SIZE)) Wouldn't those last two lines be more efficiently done with: BufOffset >= RNDIS_MAX_TOTAL_SIZE - 8 Regards Oliver